From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511F2C433EF for ; Thu, 10 Feb 2022 16:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244017AbiBJQJL (ORCPT ); Thu, 10 Feb 2022 11:09:11 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244015AbiBJQJL (ORCPT ); Thu, 10 Feb 2022 11:09:11 -0500 Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E6D5C51 for ; Thu, 10 Feb 2022 08:09:12 -0800 (PST) Received: by mail-vs1-xe2c.google.com with SMTP id v6so6935600vsp.11 for ; Thu, 10 Feb 2022 08:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TRwPb5Y+oBkP41XEt/JXjya2Xo5aicaCGmanVBPeNig=; b=R5iXAIJyn5nNTBjra5nrJeFym34vS+blo4YIs4MhOiIkIBJUmO81I8FmYY5J3KdEk3 Ww1crq7HzjrrjAmQ5QZwPZWCRMeHX4fOIecZgF0PmxkHfi5AHsq8KlRk8N9IGnP54gN5 ++QGFkPEC1UCzJC99/P++84QyO/wxA6eaze1+OPL/zsoeRzNNPFK0uCZXBPtFVxg1WlX vpeLsQa0tqTloY6Q/jfdecxSSEY7ANdvIxylQUnmAzz6xuffquxll7kkWEaYecDbM7sY triYS7uch0DbgivVcmsjIwNFf/LliQITrZ801j0Bm90crKwt7BwhWdTMRjhp2mZcXsL1 O5jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TRwPb5Y+oBkP41XEt/JXjya2Xo5aicaCGmanVBPeNig=; b=rv8cjDcGQPGUcnkHWCd6M1qhPxGTv8dDZ1PkSNVNMb3CMbrGCSSE/4fXGMg0eCURTu SWi39jPJfrXVwwAEeUSH9WY8yai9twjOudgXls6YNFsl9ktnbOTJmIojWCZWLPbX+Urp /JyjlPxOGPTiwy3Y1wb/rgDJzUCo9rVeBM9GHdkTdj6IzSQJB3XYPdAkTgSRxMp/7A8E Pu3CBpqiP2I+pDs451xzwhZBUDm1AFCpElA02uRf0zVjWYbY9m5UO4fDbu+XSBqwo8fQ fJyK+vdP6Pl72Ol1xukya+lWVirDot5h2QaL/mmFAH3ls0DW2hQscuTnHJ2R2q3ZMU89 ou5Q== X-Gm-Message-State: AOAM531qCLPS+nzH9SwrCp8xrgvomzjd/n0TKHeLAtJleF3sA9DOUXCb /ltNNRUdIzjR4YH9frOViX+/X+Ssdq8= X-Google-Smtp-Source: ABdhPJziW431hT56R+gU+g/qy8yTXDWfLMXYmlcpuIfYeEfzZWcXPt11JI74DjcWwONaNGfByJ9y3A== X-Received: by 2002:a67:fa83:: with SMTP id f3mr2751555vsq.80.1644509351193; Thu, 10 Feb 2022 08:09:11 -0800 (PST) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com. [209.85.221.179]) by smtp.gmail.com with ESMTPSA id w3sm3904514vkd.5.2022.02.10.08.09.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 08:09:10 -0800 (PST) Received: by mail-vk1-f179.google.com with SMTP id d27so3355456vkn.5 for ; Thu, 10 Feb 2022 08:09:10 -0800 (PST) X-Received: by 2002:a05:6122:507:: with SMTP id x7mr2742625vko.14.1644509350149; Thu, 10 Feb 2022 08:09:10 -0800 (PST) MIME-Version: 1.0 References: <20220210003649.3120861-1-kuba@kernel.org> In-Reply-To: <20220210003649.3120861-1-kuba@kernel.org> From: Willem de Bruijn Date: Thu, 10 Feb 2022 11:08:33 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next 00/11] net: ping6: support basic socket cmsgs To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, lorenzo@google.com, maze@google.com, dsahern@kernel.org, yoshfuji@linux-ipv6.org, shuah@kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 9, 2022 at 7:36 PM Jakub Kicinski wrote: > > Add support for common SOL_SOCKET cmsgs in ICMPv6 sockets. > Extend the cmsg tests to cover more cmsgs and socket types. > > SOL_IPV6 cmsgs to follow. > > Jakub Kicinski (11): > net: ping6: remove a pr_debug() statement > net: ping6: support packet timestamping > net: ping6: support setting socket options via cmsg > selftests: net: rename cmsg_so_mark > selftests: net: make cmsg_so_mark ready for more options > selftests: net: cmsg_sender: support icmp and raw sockets > selftests: net: cmsg_so_mark: test ICMP and RAW sockets > selftests: net: cmsg_so_mark: test with SO_MARK set by setsockopt > selftests: net: cmsg_sender: support setting SO_TXTIME > selftests: net: cmsg_sender: support Tx timestamping > selftests: net: test standard socket cmsgs across UDP and ICMP sockets > > net/ipv6/ping.c | 14 +- > tools/testing/selftests/net/.gitignore | 2 +- > tools/testing/selftests/net/Makefile | 3 +- > tools/testing/selftests/net/cmsg_sender.c | 380 ++++++++++++++++++++ > tools/testing/selftests/net/cmsg_so_mark.c | 67 ---- > tools/testing/selftests/net/cmsg_so_mark.sh | 32 +- > tools/testing/selftests/net/cmsg_time.sh | 83 +++++ > 7 files changed, 499 insertions(+), 82 deletions(-) > create mode 100644 tools/testing/selftests/net/cmsg_sender.c > delete mode 100644 tools/testing/selftests/net/cmsg_so_mark.c > create mode 100755 tools/testing/selftests/net/cmsg_time.sh > Already merged, but since I was on the cc line: overall looks great to me too. Thanks Jakub.