From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A4FC4363D for ; Tue, 6 Oct 2020 11:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3366520866 for ; Tue, 6 Oct 2020 11:58:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A9Ugw8qi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726258AbgJFL6b (ORCPT ); Tue, 6 Oct 2020 07:58:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbgJFL6a (ORCPT ); Tue, 6 Oct 2020 07:58:30 -0400 Received: from mail-vk1-xa42.google.com (mail-vk1-xa42.google.com [IPv6:2607:f8b0:4864:20::a42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F903C061755 for ; Tue, 6 Oct 2020 04:58:29 -0700 (PDT) Received: by mail-vk1-xa42.google.com with SMTP id h74so1620418vkh.6 for ; Tue, 06 Oct 2020 04:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pz8AeeVxKpZa4XGo5SKtXcEDCfIi6kkgPZ59A1EdUnY=; b=A9Ugw8qixRyVlD5gu9wzq4blnlsNIlxTyDImdUZLrPtYxtkNRSsNQ0Qkxtkgtcb8d+ bAIWJ1WWpAPEKK2C2AEvJELRubDVRFWm8l3fcL2Ngl5l0pt6MC6hQ0ION+IY7vinlS3i ++3ZQN2IvhjL8Ns+dBkNtSXY2fS4BTbObltiQrvrnNrC31KC3rRVukbeAy0hbAQEK898 6nshqgh87rOIusnna7GmZJmui8PzUTSmcpZwNkUJcrtRUMJ5bGEG6A9N/mGqj0EudqL1 IK3nq/MFLB/ROYb2Lmqw3sSqGYX+eehO/7kV1VUESdnHmZSWAIokuBQ/rEZ4pnl+qGdl 2zCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pz8AeeVxKpZa4XGo5SKtXcEDCfIi6kkgPZ59A1EdUnY=; b=Bx7Aj0QjxnNnrHA++Q9TaNLxkGEQCaASA/Lia4ubwDur8uVj0hdt4aqnTVmTEDegCB y3YdDDbkuqRl/SSpPBRLSI7KBfoxj6XW8T4LROfajlBZVRAX2p8zKBsdLzgTY7eMoiEs DfJWR5VkqMsEB/e7MQSW1jAuL5M8XSVBlKpA2tx4kfYzfy6/LRsTtC3w7Y1CHbNkd8BJ rlI3urc4Tu1m+vGgZ9NhotfUCb41tgez715rlMfbEzaUVmsE3Wxl7wmPBeD/v8SPr7F9 WJu+aTTYY/IiYGdgQkZtuy7kSknZ6r7RUqiErphYK7ZAyCMrlJhkRZz1aP1TGbrNl13T amLw== X-Gm-Message-State: AOAM532rIsrA5jzHoutLMAKZMnmu0UPWfytiqMqxleAsP7c4CzCOT5on JiiDJhzFTMlCWPW2xIpPKGitM6O4sTk= X-Google-Smtp-Source: ABdhPJzjjWxuVQqj5NqE2NI3swjPo1qjJT+KKYBnkJ/4H8F10gCuwC03bB1QB1ls/lncNohSjS/iwg== X-Received: by 2002:a1f:2508:: with SMTP id l8mr2231528vkl.20.1601985508175; Tue, 06 Oct 2020 04:58:28 -0700 (PDT) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com. [209.85.217.43]) by smtp.gmail.com with ESMTPSA id o22sm368313vsr.12.2020.10.06.04.58.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Oct 2020 04:58:27 -0700 (PDT) Received: by mail-vs1-f43.google.com with SMTP id 5so5940937vsu.5 for ; Tue, 06 Oct 2020 04:58:27 -0700 (PDT) X-Received: by 2002:a67:684e:: with SMTP id d75mr2793797vsc.28.1601985506872; Tue, 06 Oct 2020 04:58:26 -0700 (PDT) MIME-Version: 1.0 References: <20201005144838.851988-1-vladimir.oltean@nxp.com> <20201006114322.aq276lij2ovhdtts@skbuf> In-Reply-To: <20201006114322.aq276lij2ovhdtts@skbuf> From: Willem de Bruijn Date: Tue, 6 Oct 2020 07:57:51 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next] net: always dump full packets with skb_dump To: Vladimir Oltean Cc: Willem de Bruijn , Jacob Keller , Network Development , David Miller , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 6, 2020 at 7:43 AM Vladimir Oltean wrote: > > On Tue, Oct 06, 2020 at 07:30:13AM -0400, Willem de Bruijn wrote: > > skb_dump is called from skb_warn_bad_offload and netdev_rx_csum_fault. > > Previously when these were triggered, a few example bad packets were > > sufficient to debug the issue. > > Yes, and it's only netdev_rx_csum_fault that matters, because > skb_warn_bad_offload calls with full_pkt=false anyway. > > During the times when I had netdev_rx_csum_fault triggered, it was > pretty bad anyway. I don't think that full_pkt getting unset after 5 > skbs made too big of a difference. > > > A full dump can add a lot of data to the kernel log, so I limited to > > what is strictly needed. > > Yes, well my expectation is that other people are using skb_dump for > debugging, even beyond those 2 callers in the mainline kernel. And when > they want to dump with full_pkt=true, they really want to dump with > full_pkt=true. Sure, that makes sense.