All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: tanhuazhong <tanhuazhong@huawei.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	David Miller <davem@davemloft.net>,
	Network Development <netdev@vger.kernel.org>,
	linuxarm@huawei.com, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE_GSO
Date: Thu, 9 Jul 2020 09:34:42 -0400	[thread overview]
Message-ID: <CA+FuTSeJMLW=HHrDjenEeinDc6RZTEynjkQWY6cPnOB-FbOTnA@mail.gmail.com> (raw)
In-Reply-To: <aee519de-c793-a2a7-34d1-c18c90080ca6@huawei.com>

On Wed, Jul 8, 2020 at 10:49 PM tanhuazhong <tanhuazhong@huawei.com> wrote:
>
>
>
> On 2020/7/8 20:11, Willem de Bruijn wrote:
> > On Tue, Jul 7, 2020 at 11:50 PM Huazhong Tan <tanhuazhong@huawei.com> wrote:
> >>
> >> Add NETIF_F_SOFTWARE_GSO to the the list of GSO features with
> >> a software fallback.  This allows UDP GSO to be used even if
> >> the hardware does not support it,
> >
> > That is already the case if just calling UDP_SEGMENT.
> >
> > It seems the specific goal here is to postpone segmentation when
> > going through a vxlan device?
> >
>
> yes. without this patch, the segmentation is handled before calling
> virtual device's .ndo_start_xmit.
> Like TSO, UDP GSO also should be handle as later as possible?

Sure, but the commit message makes it sounds as if UDP GSO cannot be
used if hardware does not support it right now.

  reply	other threads:[~2020-07-09 13:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  3:48 [RFC net-next 0/2] net: two updates related to UDP GSO Huazhong Tan
2020-07-08  3:48 ` [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE_GSO Huazhong Tan
2020-07-08  5:26   ` Eric Dumazet
2020-07-09  2:16     ` tanhuazhong
2020-07-09  2:28       ` Eric Dumazet
2020-07-08 12:11   ` Willem de Bruijn
2020-07-09  2:49     ` tanhuazhong
2020-07-09 13:34       ` Willem de Bruijn [this message]
2020-07-08  3:48 ` [RFC net-next 2/2] net: disable UDP GSO feature when CSUM is disabled Huazhong Tan
2020-07-08  5:36   ` Eric Dumazet
2020-07-09  2:30     ` tanhuazhong
2020-07-09  2:47       ` Eric Dumazet
2020-07-09  2:55         ` tanhuazhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+FuTSeJMLW=HHrDjenEeinDc6RZTEynjkQWY6cPnOB-FbOTnA@mail.gmail.com' \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=tanhuazhong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.