From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
James Prestwood <prestwoj@gmail.com>,
Justin Iurman <justin.iurman@uliege.be>,
Praveen Chaudhary <praveen5582@gmail.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Eric Dumazet <edumazet@google.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v5 net-next 1/3] seg6: export get_srh() for ICMP handling
Date: Mon, 3 Jan 2022 15:52:36 -0500 [thread overview]
Message-ID: <CA+FuTSeydAbz296i_ObW9ci1ddPqOzC=JvYUOwQA2ngaqA8CaA@mail.gmail.com> (raw)
In-Reply-To: <b675e0e5-3469-0854-3767-b2a9ec68bd8f@gmail.com>
On Mon, Jan 3, 2022 at 12:31 PM David Ahern <dsahern@gmail.com> wrote:
>
> On 1/3/22 10:11 AM, Andrew Lunn wrote:
> > An ICMP error message can contain in its message body part of an IPv6
> > packet which invoked the error. Such a packet might contain a segment
> > router header. Export get_srh() so the ICMP code can make use of it.
> >
> > Since his changes the scope of the function from local to global, add
> > the seg6_ prefix to keep the namespace clean. And move it into seg6.c
> > so it is always available, not just when IPV6_SEG6_LWTUNNEL is
> > enabled.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > include/net/seg6.h | 1 +
> > net/ipv6/seg6.c | 29 +++++++++++++++++++++++++++++
> > net/ipv6/seg6_local.c | 33 ++-------------------------------
> > 3 files changed, 32 insertions(+), 31 deletions(-)
> >
>
> Reviewed-by: David Ahern <dsahern@kernel.org>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2022-01-03 20:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 17:11 [PATCH v5 net-next 0/3] Fix traceroute in the presence of SRv6 Andrew Lunn
2022-01-03 17:11 ` [PATCH v5 net-next 1/3] seg6: export get_srh() for ICMP handling Andrew Lunn
2022-01-03 17:31 ` David Ahern
2022-01-03 20:52 ` Willem de Bruijn [this message]
2022-01-03 17:11 ` [PATCH v5 net-next 2/3] icmp: ICMPV6: Examine invoking packet for Segment Route Headers Andrew Lunn
2022-01-03 17:34 ` David Ahern
2022-01-03 20:55 ` Willem de Bruijn
2022-01-03 17:11 ` [PATCH v5 net-next 3/3] udp6: Use Segment Routing Header for dest address if present Andrew Lunn
2022-01-03 17:35 ` David Ahern
2022-01-03 20:55 ` Willem de Bruijn
2022-01-04 12:40 ` [PATCH v5 net-next 0/3] Fix traceroute in the presence of SRv6 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTSeydAbz296i_ObW9ci1ddPqOzC=JvYUOwQA2ngaqA8CaA@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=Jason@zx2c4.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=justin.iurman@uliege.be \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=praveen5582@gmail.com \
--cc=prestwoj@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.