* [RESEND V2] ASoC: max98390: Add reset gpio control
@ 2022-03-12 0:24 Steve Lee
2022-03-12 10:40 ` Krzysztof Kozlowski
2022-03-12 12:58 ` Nuno Sá
0 siblings, 2 replies; 7+ messages in thread
From: Steve Lee @ 2022-03-12 0:24 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, ckeepax, geert, rf, shumingf,
srinivas.kandagatla, krzk, jack.yu, nuno.sa, ryans.lee,
linux-kernel, alsa-devel
Cc: Steve Lee
Add reset gpio control to support RESET PIN connected to gpio.
Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
---
sound/soc/codecs/max98390.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
index 40fd6f363f35..9a9299e5cc5a 100644
--- a/sound/soc/codecs/max98390.c
+++ b/sound/soc/codecs/max98390.c
@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
struct max98390_priv *max98390 = NULL;
struct i2c_adapter *adapter = i2c->adapter;
+ struct gpio_desc *reset_gpio;
ret = i2c_check_functionality(adapter,
I2C_FUNC_SMBUS_BYTE
@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
return ret;
}
+ reset_gpio = devm_gpiod_get_optional(&i2c->dev,
+ "maxim,reset-gpios", GPIOD_OUT_LOW);
+
+ /* Power on device */
+ if (reset_gpio) {
+ usleep_range(1000, 2000);
+ /* bring out of reset */
+ gpiod_set_value_cansleep(reset_gpio, 1);
+ usleep_range(1000, 2000);
+ }
+
/* Check Revision ID */
ret = regmap_read(max98390->regmap,
MAX98390_R24FF_REV_ID, ®);
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND V2] ASoC: max98390: Add reset gpio control
2022-03-12 0:24 [RESEND V2] ASoC: max98390: Add reset gpio control Steve Lee
@ 2022-03-12 10:40 ` Krzysztof Kozlowski
2022-03-13 5:40 ` Lee Steve
2022-03-12 12:58 ` Nuno Sá
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-12 10:40 UTC (permalink / raw)
To: Steve Lee, lgirdwood, broonie, perex, tiwai, ckeepax, geert, rf,
shumingf, srinivas.kandagatla, jack.yu, nuno.sa, ryans.lee,
linux-kernel, alsa-devel
On 12/03/2022 01:24, Steve Lee wrote:
> Add reset gpio control to support RESET PIN connected to gpio.
>
> Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> ---
> sound/soc/codecs/max98390.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
> index 40fd6f363f35..9a9299e5cc5a 100644
> --- a/sound/soc/codecs/max98390.c
> +++ b/sound/soc/codecs/max98390.c
> @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
>
> struct max98390_priv *max98390 = NULL;
> struct i2c_adapter *adapter = i2c->adapter;
> + struct gpio_desc *reset_gpio;
>
> ret = i2c_check_functionality(adapter,
> I2C_FUNC_SMBUS_BYTE
> @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
> return ret;
> }
>
> + reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> + "maxim,reset-gpios", GPIOD_OUT_LOW);
> +
I don't know why did you CC me, but since I am looking at this - you
have to update bindings.
Do not add random properties to drivers without updating bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND V2] ASoC: max98390: Add reset gpio control
2022-03-12 0:24 [RESEND V2] ASoC: max98390: Add reset gpio control Steve Lee
2022-03-12 10:40 ` Krzysztof Kozlowski
@ 2022-03-12 12:58 ` Nuno Sá
2022-03-13 5:42 ` Lee Steve
1 sibling, 1 reply; 7+ messages in thread
From: Nuno Sá @ 2022-03-12 12:58 UTC (permalink / raw)
To: Steve Lee, lgirdwood, broonie, perex, tiwai, ckeepax, geert, rf,
shumingf, srinivas.kandagatla, krzk, jack.yu, nuno.sa, ryans.lee,
linux-kernel, alsa-devel
On Sat, 2022-03-12 at 09:24 +0900, Steve Lee wrote:
> Add reset gpio control to support RESET PIN connected to gpio.
>
> Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> ---
> sound/soc/codecs/max98390.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/sound/soc/codecs/max98390.c
> b/sound/soc/codecs/max98390.c
> index 40fd6f363f35..9a9299e5cc5a 100644
> --- a/sound/soc/codecs/max98390.c
> +++ b/sound/soc/codecs/max98390.c
> @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client
> *i2c,
>
> struct max98390_priv *max98390 = NULL;
> struct i2c_adapter *adapter = i2c->adapter;
> + struct gpio_desc *reset_gpio;
>
> ret = i2c_check_functionality(adapter,
> I2C_FUNC_SMBUS_BYTE
> @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct
> i2c_client *i2c,
> return ret;
> }
>
> + reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> + "maxim,reset-gpios",
> GPIOD_OUT_LOW);
A reset GPIO is a standard property so there's no need for a vendor
prefix. This should be devm_gpiod_get_optional(&i2c->dev, "reset",
...). And, as said before, you need to add a reset-gpios property to
the bindings in a different patch.
I'm also not sure why you have this as RESEND...
- Nuno Sá
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND V2] ASoC: max98390: Add reset gpio control
2022-03-12 10:40 ` Krzysztof Kozlowski
@ 2022-03-13 5:40 ` Lee Steve
0 siblings, 0 replies; 7+ messages in thread
From: Lee Steve @ 2022-03-13 5:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: lgirdwood, Mark Brown, perex, tiwai, ckeepax, geert, rf,
shumingf, srinivas.kandagatla, jack.yu, Sa, Nuno, ryans.lee,
linux-kernel, alsa-devel
On Sat, Mar 12, 2022 at 7:40 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 12/03/2022 01:24, Steve Lee wrote:
> > Add reset gpio control to support RESET PIN connected to gpio.
> >
> > Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> > ---
> > sound/soc/codecs/max98390.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
> > index 40fd6f363f35..9a9299e5cc5a 100644
> > --- a/sound/soc/codecs/max98390.c
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
> >
> > struct max98390_priv *max98390 = NULL;
> > struct i2c_adapter *adapter = i2c->adapter;
> > + struct gpio_desc *reset_gpio;
> >
> > ret = i2c_check_functionality(adapter,
> > I2C_FUNC_SMBUS_BYTE
> > @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
> > return ret;
> > }
> >
> > + reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> > + "maxim,reset-gpios", GPIOD_OUT_LOW);
> > +
>
> I don't know why did you CC me, but since I am looking at this - you
> have to update bindings.
>
> Do not add random properties to drivers without updating bindings.
>
> Best regards,
> Krzysztof
Thanks for comment. Yes, I update bingding too.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND V2] ASoC: max98390: Add reset gpio control
@ 2022-03-13 5:40 ` Lee Steve
0 siblings, 0 replies; 7+ messages in thread
From: Lee Steve @ 2022-03-13 5:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: jack.yu, alsa-devel, ckeepax, ryans.lee, linux-kernel, tiwai,
lgirdwood, Sa, Nuno, Mark Brown, geert, shumingf,
srinivas.kandagatla, rf
On Sat, Mar 12, 2022 at 7:40 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 12/03/2022 01:24, Steve Lee wrote:
> > Add reset gpio control to support RESET PIN connected to gpio.
> >
> > Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> > ---
> > sound/soc/codecs/max98390.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
> > index 40fd6f363f35..9a9299e5cc5a 100644
> > --- a/sound/soc/codecs/max98390.c
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
> >
> > struct max98390_priv *max98390 = NULL;
> > struct i2c_adapter *adapter = i2c->adapter;
> > + struct gpio_desc *reset_gpio;
> >
> > ret = i2c_check_functionality(adapter,
> > I2C_FUNC_SMBUS_BYTE
> > @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
> > return ret;
> > }
> >
> > + reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> > + "maxim,reset-gpios", GPIOD_OUT_LOW);
> > +
>
> I don't know why did you CC me, but since I am looking at this - you
> have to update bindings.
>
> Do not add random properties to drivers without updating bindings.
>
> Best regards,
> Krzysztof
Thanks for comment. Yes, I update bingding too.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND V2] ASoC: max98390: Add reset gpio control
2022-03-12 12:58 ` Nuno Sá
@ 2022-03-13 5:42 ` Lee Steve
0 siblings, 0 replies; 7+ messages in thread
From: Lee Steve @ 2022-03-13 5:42 UTC (permalink / raw)
To: Nuno Sá
Cc: lgirdwood, Mark Brown, perex, tiwai, ckeepax, geert, rf,
shumingf, srinivas.kandagatla, krzk, jack.yu, Sa, Nuno,
ryans.lee, linux-kernel, alsa-devel
On Sat, Mar 12, 2022 at 9:58 PM Nuno Sá <noname.nuno@gmail.com> wrote:
>
> On Sat, 2022-03-12 at 09:24 +0900, Steve Lee wrote:
> > Add reset gpio control to support RESET PIN connected to gpio.
> >
> > Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> > ---
> > sound/soc/codecs/max98390.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/sound/soc/codecs/max98390.c
> > b/sound/soc/codecs/max98390.c
> > index 40fd6f363f35..9a9299e5cc5a 100644
> > --- a/sound/soc/codecs/max98390.c
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client
> > *i2c,
> >
> > struct max98390_priv *max98390 = NULL;
> > struct i2c_adapter *adapter = i2c->adapter;
> > + struct gpio_desc *reset_gpio;
> >
> > ret = i2c_check_functionality(adapter,
> > I2C_FUNC_SMBUS_BYTE
> > @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct
> > i2c_client *i2c,
> > return ret;
> > }
> >
> > + reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> > + "maxim,reset-gpios",
> > GPIOD_OUT_LOW);
>
> A reset GPIO is a standard property so there's no need for a vendor
> prefix. This should be devm_gpiod_get_optional(&i2c->dev, "reset",
> ...). And, as said before, you need to add a reset-gpios property to
> the bindings in a different patch.
>
> I'm also not sure why you have this as RESEND...
>
> - Nuno Sá
> >
>
I forgot to add another patch mail. I will check it before sending patch again.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND V2] ASoC: max98390: Add reset gpio control
@ 2022-03-13 5:42 ` Lee Steve
0 siblings, 0 replies; 7+ messages in thread
From: Lee Steve @ 2022-03-13 5:42 UTC (permalink / raw)
To: Nuno Sá
Cc: jack.yu, alsa-devel, ckeepax, ryans.lee, linux-kernel, tiwai,
krzk, lgirdwood, Sa, Nuno, Mark Brown, geert, shumingf,
srinivas.kandagatla, rf
On Sat, Mar 12, 2022 at 9:58 PM Nuno Sá <noname.nuno@gmail.com> wrote:
>
> On Sat, 2022-03-12 at 09:24 +0900, Steve Lee wrote:
> > Add reset gpio control to support RESET PIN connected to gpio.
> >
> > Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> > ---
> > sound/soc/codecs/max98390.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/sound/soc/codecs/max98390.c
> > b/sound/soc/codecs/max98390.c
> > index 40fd6f363f35..9a9299e5cc5a 100644
> > --- a/sound/soc/codecs/max98390.c
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client
> > *i2c,
> >
> > struct max98390_priv *max98390 = NULL;
> > struct i2c_adapter *adapter = i2c->adapter;
> > + struct gpio_desc *reset_gpio;
> >
> > ret = i2c_check_functionality(adapter,
> > I2C_FUNC_SMBUS_BYTE
> > @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct
> > i2c_client *i2c,
> > return ret;
> > }
> >
> > + reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> > + "maxim,reset-gpios",
> > GPIOD_OUT_LOW);
>
> A reset GPIO is a standard property so there's no need for a vendor
> prefix. This should be devm_gpiod_get_optional(&i2c->dev, "reset",
> ...). And, as said before, you need to add a reset-gpios property to
> the bindings in a different patch.
>
> I'm also not sure why you have this as RESEND...
>
> - Nuno Sá
> >
>
I forgot to add another patch mail. I will check it before sending patch again.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-03-14 7:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-12 0:24 [RESEND V2] ASoC: max98390: Add reset gpio control Steve Lee
2022-03-12 10:40 ` Krzysztof Kozlowski
2022-03-13 5:40 ` Lee Steve
2022-03-13 5:40 ` Lee Steve
2022-03-12 12:58 ` Nuno Sá
2022-03-13 5:42 ` Lee Steve
2022-03-13 5:42 ` Lee Steve
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.