From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D467C433EF for ; Fri, 4 Feb 2022 07:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236503AbiBDHsj (ORCPT ); Fri, 4 Feb 2022 02:48:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230149AbiBDHsi (ORCPT ); Fri, 4 Feb 2022 02:48:38 -0500 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 583C3C061714 for ; Thu, 3 Feb 2022 23:48:38 -0800 (PST) Received: by mail-yb1-xb30.google.com with SMTP id i10so16222440ybt.10 for ; Thu, 03 Feb 2022 23:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FIpf4uvWApsh/ceG6pW+nvDB0Myo7yE0BrCqz+r4aRU=; b=Ko6+QR3SFKvHg4SSgkszZ4jODIJ11+H3RDlwjgPybirCTYR/6laIQjh6XPghVMbG1K 8JMiVEuyCaRTkbjnbNDcL5cuYzFmULSwr9YHKmZmIo7X5lNr9OoJ9ChBqjh5q0fCz4mc 2jEgsbnT3jBPks7HwE6BfzS+T2IfEap3Kuz67dokUCGqwBDSWx6og7W9HVt7oKzqLzTj muymnG+jv4LcQ3wHEAZWPvUd8+0iexVt3GRuX4uiwmMUGFIxavcIFjpMTNu8wyv296wb FR+DDkOhHvsl94ikJaqDef15dquXVjxGtdpY5eZmbFocHVQfWbNJJwwHVFf46/1JkkzW WnbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FIpf4uvWApsh/ceG6pW+nvDB0Myo7yE0BrCqz+r4aRU=; b=Fg0XcAoi7vcFqbTmgf2NcTXrFCbfvfNDXo+LoENC7Y2gGUtS3GNhCRpolodllrfAOR PCje3EKpyHCB96FzR1kg2lcEovq8Gk6dohqPEv2HQmKQbS8dbrjZNIbSiwAnuvltU6AD 8ZSYDIeu4isTTW6itfu5Y2C09/Wco83pjXZiaDNygjLYlMRa3kQ+wS5z0pDQmLMRZunK 44+BmSm9EsWikYnQVFbPq9MNb6ACCEVijMu0ZFh0MbSJEBYIiM1QHigw8IHpiUpvS8f/ f1aQHRXTmD6688g9UDjtdogUF4rqYfLK3K+6CLJda1xY+eERVS8EypfADRm/DEbU15dN 3sgQ== X-Gm-Message-State: AOAM533ltaHR7Aaxj6EEidW6Pl9EOYUXSDaQTFqjiVWgzFxT1PNjRXDK iwCbwntQJ7A2T/DE8gIZ5lgc/C0FOA+hsIItx/s5Eg== X-Google-Smtp-Source: ABdhPJxhYkG8kt166e8BIyfcFNvrkv1EXmgM2pVRAPQ1fWZMhgc4LoTlurfNWXfew+edKAsuJv+VM8vccVUqhDLXVgI= X-Received: by 2002:a25:5143:: with SMTP id f64mr1813491ybb.520.1643960917186; Thu, 03 Feb 2022 23:48:37 -0800 (PST) MIME-Version: 1.0 References: <20220203211150.2912192-1-frowand.list@gmail.com> In-Reply-To: <20220203211150.2912192-1-frowand.list@gmail.com> From: Naresh Kamboju Date: Fri, 4 Feb 2022 13:18:25 +0530 Message-ID: Subject: Re: [PATCH 1/1] of: unittest: print pass messages at same loglevel as fail To: frowand.list@gmail.com Cc: Rob Herring , Brendan Higgins , Anders Roxell , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Feb 2022 at 02:42, wrote: > > From: Frank Rowand > > Printing the devicetree unittest pass message for each passed test > creates much console verbosity. The existing pass messages are > printed at loglevel KERN_DEBUG so they will not print by default. > > Change default to print the pass messages at the same loglevel as > the fail messages. > > The test community expects either a pass or a fail message for each > test in a test suite. The messages are typically post-processed to > report pass/fail results. > > Suppressing printing the pass message for each individual test is > available via the kernel command line parameter unittest.hide_pass. > > Signed-off-by: Frank Rowand Tested-by: Linux Kernel Functional Testing After this patch applied I see the change in test output log from the dmesg, It would be great if you could add fail and skip cases. When we find failures / regressions or when tests change from pass to fail we will report those on the mailing list. output: ------- [ 3.290336] ### dt-test ### start of unittest - you will see error messages [ 3.298352] ### dt-test ### EXPECT \ : Duplicate name in testcase-data, renamed to \"duplicate-name#1\" [ 3.298535] Duplicate name in testcase-data, renamed to \"duplicate-name#1\" [ 3.318485] ### dt-test ### EXPECT / : Duplicate name in testcase-data, renamed to \"duplicate-name#1\" [ 3.319418] ### dt-test ### pass of_unittest_check_tree_linkage():278 [ 3.335123] ### dt-test ### pass of_unittest_check_tree_linkage():279 [ 3.341662] ### dt-test ### pass of_unittest_check_phandles():387 Test job: https://lkft.validation.linaro.org/scheduler/job/4473059#L1019 > --- > Documentation/admin-guide/kernel-parameters.txt | 4 ++++ > drivers/of/unittest.c | 17 ++++++++++++++++- > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index f5a27f067db9..045455f9b7e1 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -5997,6 +5997,10 @@ > Note that genuine overcurrent events won't be > reported either. > > + unittest.hide_pass > + Disable printing individual drivers/of/unittest test > + pass messages. > + > unknown_nmi_panic > [X86] Cause panic on unknown NMI. > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index 70992103c07d..2cfbdc6b29ac 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -32,6 +33,19 @@ > > #include "of_private.h" > > +MODULE_LICENSE("GPL v2"); > +static bool hide_pass; > + > +static int __init hide_pass_setup(char *str) > +{ > + hide_pass = true; > + return 0; > +} > + > +early_param("hide_pass", hide_pass_setup); > +module_param(hide_pass, bool, 0); > +MODULE_PARM_DESC(hide_pass, "Disable printing individual of unittest pass messages"); > + > static struct unittest_results { > int passed; > int failed; > @@ -44,7 +58,8 @@ static struct unittest_results { > pr_err("FAIL %s():%i " fmt, __func__, __LINE__, ##__VA_ARGS__); \ > } else { \ > unittest_results.passed++; \ > - pr_debug("pass %s():%i\n", __func__, __LINE__); \ > + if (!hide_pass) \ > + pr_err("pass %s():%i\n", __func__, __LINE__); \ > } \ > failed; \ > }) > -- > Frank Rowand -- Linaro LKFT https://lkft.linaro.org