From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99132C3A5A2 for ; Tue, 3 Sep 2019 13:52:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D3CF21897 for ; Tue, 3 Sep 2019 13:52:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AigMVgvF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729473AbfICNwz (ORCPT ); Tue, 3 Sep 2019 09:52:55 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:39100 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729362AbfICNwz (ORCPT ); Tue, 3 Sep 2019 09:52:55 -0400 Received: by mail-lf1-f66.google.com with SMTP id l11so12962287lfk.6 for ; Tue, 03 Sep 2019 06:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g2euOzbhuNK7g9XKLpA4C13cCqIJOKkMfXZ8Anqpll8=; b=AigMVgvFEUSHDVBa/i+5lkqDEAGVREdhgJJvzSBL/U+HQt+kQnMOE3nDuOGTf/apwo p52yiCaJsV/bEZxuwg/K2ple75yS+DDIHlOKTscCI7B2/Kz4c5KsrcqnJKjHgFUHKptV yhs8pYweX7RZpXHiXURrisP66Y4zllZ3jw70eASXozYlx1ZYmwbmjzdOVjQPyAHb9ppT 5TIlSuuq12ryfhbxqQVGsZ1tpduyI3JRInxE/cRRrbzIkyFO8v3jtpIOcJX37N82mirx Ca0JGvkGC7zojanFSPMMDrhmr0cEISH04VlmhHKX2OERROew/Lkxv/MSe6GBL0XMWLe3 abGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g2euOzbhuNK7g9XKLpA4C13cCqIJOKkMfXZ8Anqpll8=; b=dCFXsJTXyX2kcW4yfzRhIPJwzffphaHkaVzQPcLwuakoTtEJPyex5xZu85NxEtYK1h sGHhhkWAViJiiSF0jQX/lt7JCz8MkOUeNRZ4g2wFFz8sQD5Pcz5AhziVQRqenWEkSc3b 0TpVczxWT2pIMgVgUW3iC7DRD6oq8JMzOCDbf7bqx7P4zxn0DvgF4BUp5hsaBaquLgjW AUT8lnOCQclgHYX4FbBIIBoTyFi12ioSt5acVHsiHoxWWyDugwrlCWP+RdKqJ+KQs6qg fS7xCbnpM2/p1Q+x3oxbJpvnSmVYspLu4b5yJD3OODB+yCmA1nVWKOjadb/vyXihkXU9 XlxQ== X-Gm-Message-State: APjAAAXQwCo94CBHyNCRp3ktNbA0cy2xkA816Uwi74T7V133PXZVDkhX wnO1da/1LfevJArs6fTPcuauaY7Jx5Y/NCMlYLUMWIsgDGY= X-Google-Smtp-Source: APXvYqzXbbXstoZsJ1pD0/OC7Yb6uxzuiLjL2mqM337AHoyGMIoGY2bUj1X4+V06Ngde7Qx+Rgjqg/LGwW/9SLuKCaw= X-Received: by 2002:ac2:48af:: with SMTP id u15mr13495069lfg.75.1567518773050; Tue, 03 Sep 2019 06:52:53 -0700 (PDT) MIME-Version: 1.0 References: <7C6CCE98-1E22-433C-BF70-A3CBCDED4635@lca.pw> <20190903123719.GF1131@ZenIV.linux.org.uk> <20190903133134.GG1131@ZenIV.linux.org.uk> In-Reply-To: <20190903133134.GG1131@ZenIV.linux.org.uk> From: Naresh Kamboju Date: Tue, 3 Sep 2019 19:22:41 +0530 Message-ID: Subject: Re: "fs/namei.c: keep track of nd->root refcount status" causes boot panic To: Al Viro Cc: Qian Cai , linux-fsdevel@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Tue, 3 Sep 2019 at 19:01, Al Viro wrote: > > On Tue, Sep 03, 2019 at 01:37:19PM +0100, Al Viro wrote: > > On Tue, Sep 03, 2019 at 12:21:36AM -0400, Qian Cai wrote: > > > The linux-next commit "fs/namei.c: keep track of nd->root refcount st= atus=E2=80=9D [1] causes boot panic on all > > > architectures here on today=E2=80=99s linux-next (0902). Reverted it = will fix the issue. > > > > > > > > OK, I see what's going on. Incremental to be folded in: > > ... or, better yet, > > diff --git a/include/linux/namei.h b/include/linux/namei.h > index 20ce2f917ef4..397a08ade6a2 100644 > --- a/include/linux/namei.h > +++ b/include/linux/namei.h > @@ -37,7 +37,7 @@ enum {LAST_NORM, LAST_ROOT, LAST_DOT, LAST_DOTDOT, LAST= _BIND}; > #define LOOKUP_NO_REVAL 0x0080 > #define LOOKUP_JUMPED 0x1000 > #define LOOKUP_ROOT 0x2000 > -#define LOOKUP_ROOT_GRABBED 0x4000 > +#define LOOKUP_ROOT_GRABBED 0x0008 > > extern int path_pts(struct path *path); > I have applied above patch and tested on arm64 juno-r2 and boot pass [1]. Thanks for the fix patch. > > to avoid breaking out-of-tree stuff for now good reason. > Folded and pushed out. [1] https://lkft.validation.linaro.org/scheduler/job/898187#L511 - Naresh