All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	linux-stable <stable@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [stable-rc/4.19.y] Build fails with commit 6642eb4eb918 ("ARM: imx: add missing iounmap()")
Date: Tue, 10 Aug 2021 14:01:27 +0530	[thread overview]
Message-ID: <CA+G9fYuMkVVpLjd652icgmiN6KPPMWTYGhUywU1quxjrpkbMXg@mail.gmail.com> (raw)
In-Reply-To: <YRHj96skjBbU4/9c@sashalap>

On Tue, 10 Aug 2021 at 07:57, Sasha Levin <sashal@kernel.org> wrote:
>
> On Tue, Aug 10, 2021 at 02:24:21AM +0900, Nobuhiro Iwamatsu wrote:
> >Hi,
> >
> >Build failed commit 6642eb4eb918 ("ARM: imx: add missing iounmap()") on
> >stable-rc/linux-4.19.y.
> >
> >````
> >arch/arm/mach-imx/mmdc.c: In function 'imx_mmdc_probe':
> >arch/arm/mach-imx/mmdc.c:568:2: error: 'err' undeclared (first use in this function)
> >  err = imx_mmdc_perf_init(pdev, mmdc_base);
> >  ^~~
> >arch/arm/mach-imx/mmdc.c:568:2: note: each undeclared identifier is reported only once for each function it appears in
> >arch/arm/mach-imx/mmdc.c:573:1: error: control reaches end of non-void function [-Werror=return-type]
> > }
> > ^
> >cc1: some warnings being treated as errors
> >make[1]: *** [scripts/Makefile.build:303: arch/arm/mach-imx/mmdc.o] Error 1

LKFT build system also found this build error on arm.

> >
> >````
> >
> >It seems that err has not been declared.
> >I attached a patch which revise this issue.
>
> Thanks for the report. Instead of fixing up 6642eb4eb918 ("ARM: imx: add
> missing iounmap()"), I'll take 9454a0caff6a ("ARM: imx: add mmdc ipg
> clock operation for mmdc") - this way we'll diverge less from upstream.

Thanks for looking into this issue.

- Naresh

      reply	other threads:[~2021-08-10  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 17:24 [stable-rc/4.19.y] Build fails with commit 6642eb4eb918 ("ARM: imx: add missing iounmap()") Nobuhiro Iwamatsu
2021-08-10  2:27 ` Sasha Levin
2021-08-10  8:31   ` Naresh Kamboju [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+G9fYuMkVVpLjd652icgmiN6KPPMWTYGhUywU1quxjrpkbMXg@mail.gmail.com \
    --to=naresh.kamboju@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.