From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840D3C4332E for ; Fri, 5 Mar 2021 10:03:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6401464FF0 for ; Fri, 5 Mar 2021 10:03:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229938AbhCEKCy (ORCPT ); Fri, 5 Mar 2021 05:02:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbhCEKC1 (ORCPT ); Fri, 5 Mar 2021 05:02:27 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 509E4C061574 for ; Fri, 5 Mar 2021 02:02:27 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id p8so2252833ejb.10 for ; Fri, 05 Mar 2021 02:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4+jzqKGagATPjg/VwwcWdsrDJERQg03vPdEG5QDDx6Y=; b=YNz/PEtm5Ver0vYi7v+xl8TmT0Bq3Heywo9loY0n8mJjOyld490V6BGc3tIo1mNSCr OQp7OA5IoZO1kr6yWzLtHJJv0vGvrtJoF1tJAQh7GkZl0eIEK/1r1+Y9HuX+sUGN031E FoQszYMuIp1vzcavHiTuI7XBrIdVD7FE8fg4Hk4hSHKP33jXeqn4ovK2aY97fyr68weJ bm5+uVh3RvlUXnJXKWxW8y5Nj89Yr8ZN8kwwgpCESzBkkKfRkrta3dbqHvuHUcoHwbsY C4rsGyhWe5NLP1pzAYcaFYhpf8jhtcKViaEctgOStLNT3GTqlXFHkuKtJYJ0XO77GMGL K+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4+jzqKGagATPjg/VwwcWdsrDJERQg03vPdEG5QDDx6Y=; b=PDCns66lnPy0iOiv7Xiz2RelLJ2Mw5e6Kxrq5dRhT73trkOtuYobkAAzcuBt75mM5x hQ48VoUCUeAE6aiEJvyO1x/3qxnsPv65Dd7yPRDfcvGeravBJLWAgPbGgXtJUKQRoAlz AyJCB26D1GwwPhqvdpoJHx6vOwJ0HscTZsaP6HJzA5Ra3Ka5xZIluO2pJAs252enVLkz v1/Bx24kq5ZSmI9rtU9wnnmAwQXdCLdlqQdq/IAzKUbF74sAOJYuuExIgocGV9N3B/MW ci1PwW+DIiiWY+l+71Nnw+dZHW80i6Ri4aN8Pw45fFKMGWcc7eEnxtrXLSaKJyYk4Y36 hviA== X-Gm-Message-State: AOAM5325/bHersBnRkO+oYOn4GZ9bjefMkOc5+nIzjKuRLFUvVnhmWRh opFMWuVD0ebVvMmLUbrvF52Z9qafKXLD4vFEil9oFg== X-Google-Smtp-Source: ABdhPJxz89IE+aAgCF0gMQEoezCLzDvhGBdk15aI7RofQpNcrzsBXMp6cp2s/wF2+k/F3NscWxzuO0v03KoowOttML4= X-Received: by 2002:a17:906:d8ca:: with SMTP id re10mr1587977ejb.18.1614938545934; Fri, 05 Mar 2021 02:02:25 -0800 (PST) MIME-Version: 1.0 References: <20210302192700.399054668@linuxfoundation.org> <175fac9c-ac3f-bd82-9e5d-2c2970cfc519@roeck-us.net> In-Reply-To: From: Naresh Kamboju Date: Fri, 5 Mar 2021 15:32:14 +0530 Message-ID: Subject: Re: [PATCH 5.10 000/657] 5.10.20-rc4 review To: Greg Kroah-Hartman Cc: Linus Torvalds , Guenter Roeck , open list , Shuah Khan , Florian Fainelli , patches@kernelci.org, lkft-triage@lists.linaro.org, Jon Hunter , linux-stable , Pavel Machek , Andrew Morton Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Mar 2021 at 14:22, Greg Kroah-Hartman wrote: > > On Fri, Mar 05, 2021 at 01:39:46PM +0530, Naresh Kamboju wrote: > > On Fri, 5 Mar 2021 at 02:45, Linus Torvalds > > wrote: > > > > > > On Thu, Mar 4, 2021 at 9:56 AM Naresh Kamboju wrote: > > > > > > > > On Thu, 4 Mar 2021 at 01:34, Guenter Roeck wrote: > > > > > > > > > > Upstream has: > > > > > > > > > > e71a8d5cf4b4 tty: fix up iterate_tty_read() EOVERFLOW handling > > > > > ddc5fda74561 tty: fix up hung_up_tty_read() conversion > > > > > > > > I have applied these two patches and the reported problem did not solve. > > > > > > Hmm. Upstream has: > > > > > > * 3342ff2698e9 ("tty: protect tty_write from odd low-level tty disciplines") > > > * a9cbbb80e3e7 ("tty: avoid using vfs_iocb_iter_write() for > > > redirected console writes") > > > * 17749851eb9c ("tty: fix up hung_up_tty_write() conversion") > > > G e71a8d5cf4b4 ("tty: fix up iterate_tty_read() EOVERFLOW handling") > > > G ddc5fda74561 ("tty: fix up hung_up_tty_read() conversion") > > > * c7135bbe5af2 ("tty: fix up hung_up_tty_write() conversion") > > > d7fe75cbc23c ("tty: teach the n_tty ICANON case about the new > > > "cookie continuations" too") > > > 15ea8ae8e03f ("tty: teach n_tty line discipline about the new > > > "cookie continuations"") > > > 64a69892afad ("tty: clean up legacy leftovers from n_tty line discipline") > > > * 9bb48c82aced ("tty: implement write_iter") > > > * dd78b0c483e3 ("tty: implement read_iter") > > > * 3b830a9c34d5 ("tty: convert tty_ldisc_ops 'read()' function to take > > > a kernel pointer") > > > > > > Where those ones marked with '*' seem to be in v5.10.y, and the one > > > prefixed with 'G' are the ones Guenter mentioned. > > > > > > (We seem to have the "tty: fix up hung_up_tty_write() conversion" > > > commit twice. I'm not sure how that happened, but whatever). > > I merged it through two different branches by applying it from email, > one for 5.10-final and one for 5.11-rc1, sorry about that. > > > > But that still leaves three commits that don't seem to be in 5.10.y: > > > > > > d7fe75cbc23c ("tty: teach the n_tty ICANON case about the new > > > "cookie continuations" too") > > > 15ea8ae8e03f ("tty: teach n_tty line discipline about the new > > > "cookie continuations"") > > > 64a69892afad ("tty: clean up legacy leftovers from n_tty line discipline") > > > > > > and they might fix what are otherwise short reads. Which is allowed by > > > POSIX, afaik, but .. > > > > > > Do those three commits fix your test-case? > > > > Yes. > > As per your suggestion I've added these three patches and tested > > and the reported test case PASS now [1]. > > > > This means I have five extra patches on top of the stable v5.10.20 tag. > > > > $ git log --oneline > > 8c1c1de499af tty: teach the n_tty ICANON case about the new "cookie > > continuations" too > > 02aada164879 tty: teach n_tty line discipline about the new "cookie > > continuations" > > fb0df6b17897 tty: clean up legacy leftovers from n_tty line discipline > > 429f7fc84d6a tty: fix up iterate_tty_read() EOVERFLOW handling > > d0d54bca80a8 tty: fix up hung_up_tty_read() conversion > > 83be32b6c9e5 (tag: v5.10.20, origin/linux-5.10.y) Linux 5.10.20 > > That last commit, "tty: fix up hung_up_tty_read() conversion" is already > in 5.10.20 as e018e57fd5c0 ("tty: fix up hung_up_tty_write() > conversion"), it came in at 5.10.11, so how did you apply it again? It is easy to confuse between read() and write(). tty: fix up hung_up_tty_read() conversion tty: fix up hung_up_tty_write() conversion Write() was there but read() is a commit that has been cherry-picked. > Anyway, thanks for these, I've queued up the 4 other commits now to the > 5.10.y and 5.11.y trees, let's see what happens... Thank you ! - Naresh