From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D85C47259 for ; Wed, 6 May 2020 18:58:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B07020708 for ; Wed, 6 May 2020 18:58:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ENs11Z2E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730487AbgEFS6J (ORCPT ); Wed, 6 May 2020 14:58:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730414AbgEFS6H (ORCPT ); Wed, 6 May 2020 14:58:07 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 352EAC0610D5 for ; Wed, 6 May 2020 11:58:07 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id t11so2266903lfe.4 for ; Wed, 06 May 2020 11:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2hhU7YC1mHWJXOQCa9/YtvMX0AvTF/51BQ11Lkp2if0=; b=ENs11Z2E6PTphR/O7XEptV9DrkitQZwLiWGfUE3J1NThoeRLPWDK4tDps5BoTcWit1 zxwc6iaDbar5hppPTNmyGg+DQIeMEcKomHQdFBhyU8VETMfHL8W2a1Jd5FtPT4MSFPlx pW5uAwDfiblCrXtvPdUyMV5XllzXhrrMlu3/oW6uuJTz36qgimok4gbXBH4xnjVurcCX lcUe+U7g7T87tsCxaKgUy1ztqhvZkOlPI1dRGORUz42KQ/uPPuoOll0V3+DBw/rjO1OW I1Q/zUwoATalGf6bzwzmulWBAfKNsUBbxb1ZM1A5ACSkMtfwmtHD9gRLESdsOugAfng+ xmww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2hhU7YC1mHWJXOQCa9/YtvMX0AvTF/51BQ11Lkp2if0=; b=R2eDji65umloZibT2OZiHDB71tXEDluvirSWO5EZ0SrFs7OHriAASfSwzhaAyWu94l heMlQhoPo0SPWmXsvwRHof8VBH1TrU9fklmfx5A5sEPQ35QEf9G3Tq66Z0Z1ZYymK5rh P044w+AkHjJSAj3ZraA9UNr0Z5nM7rFCrwSW4gGqVfreI4QdvVzPGG3JS5wNjzX2CFKX C47QzEUJWiDvGDFnuqEXio2r+AxzJ0/RjN7E4vs2T+hnarienH30TSvRiq/bmaANRbkM lorQo9KEv52V5EoR7K5MsyLeXDEp8oY/8ZaYH5BoZ20LN+I8xtyA6cIdsnt6s947oCR+ vXOg== X-Gm-Message-State: AGi0Pub77S2eGCkZneNde4U95Uc42ci8+XCDcPnCEUBvuxTTNI68bDN6 w+V0uuzaM5bp1nNVJSwOBOofwb5JJLNppffMNzrlxA== X-Google-Smtp-Source: APiQypK2/BS9DNLQgUdve0DnZIP+ggCdF8l9P6mtknH7uy4q8+KLPietCh0cyMKc+/gJFltqkIhzsPf/UxXxP4Q5v8I= X-Received: by 2002:a19:40d2:: with SMTP id n201mr6168784lfa.82.1588791485423; Wed, 06 May 2020 11:58:05 -0700 (PDT) MIME-Version: 1.0 References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> In-Reply-To: <1480357509-28074-12-git-send-email-johan@kernel.org> From: Naresh Kamboju Date: Thu, 7 May 2020 00:27:53 +0530 Message-ID: Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks To: Johan Hovold , linux- stable , Greg Kroah-Hartman , Sasha Levin Cc: "David S. Miller" , Vince Bridgers , Florian Fainelli , Fugang Duan , Pantelis Antoniou , Vitaly Bordug , Claudiu Manoil , Li Yang , Thomas Petazzoni , Felix Fietkau , John Crispin , Matthias Brugger , Sergei Shtylyov , Lars Persson , Mugunthan V N , Grygorii Strashko , Rob Herring , Frank Rowand , Andrew Lunn , Vivien Didelot , Netdev , nios2-dev@lists.rocketboards.org, open list , linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Nov 2016 at 00:00, Johan Hovold wrote: > > Make sure to deregister and free any fixed-link PHY registered using > of_phy_register_fixed_link() on probe errors and on driver unbind. > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > Signed-off-by: Johan Hovold > --- > drivers/net/ethernet/marvell/mvneta.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 0c0a45af950f..707bc4680b9b 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev) > clk_disable_unprepare(pp->clk); > err_put_phy_node: > of_node_put(phy_node); > + if (of_phy_is_fixed_link(dn)) > + of_phy_deregister_fixed_link(dn); While building kernel Image for arm architecture on stable-rc 4.4 branch the following build error found. drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit declaration of function 'of_phy_deregister_fixed_link'; did you mean 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration] | of_phy_deregister_fixed_link(dn); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | of_phy_register_fixed_link ref: https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729 - Naresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21DFEC28CBC for ; Wed, 6 May 2020 19:56:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D4F120747 for ; Wed, 6 May 2020 19:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ENs11Z2E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D4F120747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49HS653KfpzDqvh for ; Thu, 7 May 2020 05:56:45 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::144; helo=mail-lf1-x144.google.com; envelope-from=naresh.kamboju@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ENs11Z2E; dkim-atps=neutral Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49HQpc47KczDqWX for ; Thu, 7 May 2020 04:58:11 +1000 (AEST) Received: by mail-lf1-x144.google.com with SMTP id x73so2277504lfa.2 for ; Wed, 06 May 2020 11:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2hhU7YC1mHWJXOQCa9/YtvMX0AvTF/51BQ11Lkp2if0=; b=ENs11Z2E6PTphR/O7XEptV9DrkitQZwLiWGfUE3J1NThoeRLPWDK4tDps5BoTcWit1 zxwc6iaDbar5hppPTNmyGg+DQIeMEcKomHQdFBhyU8VETMfHL8W2a1Jd5FtPT4MSFPlx pW5uAwDfiblCrXtvPdUyMV5XllzXhrrMlu3/oW6uuJTz36qgimok4gbXBH4xnjVurcCX lcUe+U7g7T87tsCxaKgUy1ztqhvZkOlPI1dRGORUz42KQ/uPPuoOll0V3+DBw/rjO1OW I1Q/zUwoATalGf6bzwzmulWBAfKNsUBbxb1ZM1A5ACSkMtfwmtHD9gRLESdsOugAfng+ xmww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2hhU7YC1mHWJXOQCa9/YtvMX0AvTF/51BQ11Lkp2if0=; b=lvNHJ12boBPG3b6okqXhJPi7le762uJS2W33hp0j8jOuPbF2T1H5k+kw7zvdZFksNR mDyTZLuS4/TEJUySjvu0eFufJYwowH+DJYPxI7dijsgOJLbIRnuJtWq99bBckOWyoB8g shSkrgjpRzXj/Sq7R4u8SBX/8HuXl8oYIde//bpMG1WAhWWmpmUXFgOXHqzlWxswtrc9 IHfoU4YX055XyVX8X6G2AOHrPOwUUTC1mgaEopjw2+B+E62tr8KCxc+Qx7C4o+eUDoKt 7UnMCJPOXgPeroZ4NWiJ7HimBADmfGhxVgbl8JmScl7xMqDOx8gAVx/vtl1yMl6taYk6 YSeg== X-Gm-Message-State: AGi0PuajvrZNizgIuiRoTtqsVqxwjN0VPcIeysNf+81HHm56AghxbAuN WMdVRQ/qByHWQej6EeRgeqMP2afgHlGzsmaYnIfThg== X-Google-Smtp-Source: APiQypK2/BS9DNLQgUdve0DnZIP+ggCdF8l9P6mtknH7uy4q8+KLPietCh0cyMKc+/gJFltqkIhzsPf/UxXxP4Q5v8I= X-Received: by 2002:a19:40d2:: with SMTP id n201mr6168784lfa.82.1588791485423; Wed, 06 May 2020 11:58:05 -0700 (PDT) MIME-Version: 1.0 References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> In-Reply-To: <1480357509-28074-12-git-send-email-johan@kernel.org> From: Naresh Kamboju Date: Thu, 7 May 2020 00:27:53 +0530 Message-ID: Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks To: Johan Hovold , linux- stable , Greg Kroah-Hartman , Sasha Levin Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Thu, 07 May 2020 05:54:52 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org, Frank Rowand , Felix Fietkau , Florian Fainelli , Claudiu Manoil , Li Yang , Mugunthan V N , Grygorii Strashko , linuxppc-dev@lists.ozlabs.org, Rob Herring , linux-mediatek@lists.infradead.org, Lars Persson , Matthias Brugger , linux-omap@vger.kernel.org, John Crispin , Thomas Petazzoni , Fugang Duan , Sergei Shtylyov , Vivien Didelot , Netdev , open list , linux-renesas-soc@vger.kernel.org, Vitaly Bordug , nios2-dev@lists.rocketboards.org, Vince Bridgers , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 29 Nov 2016 at 00:00, Johan Hovold wrote: > > Make sure to deregister and free any fixed-link PHY registered using > of_phy_register_fixed_link() on probe errors and on driver unbind. > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > Signed-off-by: Johan Hovold > --- > drivers/net/ethernet/marvell/mvneta.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 0c0a45af950f..707bc4680b9b 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev) > clk_disable_unprepare(pp->clk); > err_put_phy_node: > of_node_put(phy_node); > + if (of_phy_is_fixed_link(dn)) > + of_phy_deregister_fixed_link(dn); While building kernel Image for arm architecture on stable-rc 4.4 branch the following build error found. drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit declaration of function 'of_phy_deregister_fixed_link'; did you mean 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration] | of_phy_deregister_fixed_link(dn); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | of_phy_register_fixed_link ref: https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729 - Naresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9723FC28CBC for ; Wed, 6 May 2020 18:58:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E05920708 for ; Wed, 6 May 2020 18:58:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u5duKCAA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ENs11Z2E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E05920708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/P5y9PZ2prqSIm98mbjfax1i0WJjaFNwZ2FgNf6IPKQ=; b=u5duKCAAtWumi7 5T4R6/AdAZb17Ik/sUobFwSYdL+Tbm3nCW3NMFnychrAPjwMxAlZNc0S6eWhfwten/Pi1smm3X97R BrUVJlwMV/bMjWEIBrozMOfeMYAtTHopkWeBBfeH0OF2RXMP3u4j2tqq9gHo38W5nYebGxCHqYCl9 RVgqGkPGsBxiwhgsgKta/zgt5AxyFmQBQXy5bzGbo3HbtT9GaSs1sWmXct3lPimYgex6YZ2AWIgOR AoD2bwZzenduGnmfiO/dx1/FNI1qNB+WsaV/apP8VX4hmjW2u4H+R94uBmRCk7wPYmltlPPEeLC0P mkGuNdZA2OHuvDaQL3Wg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWPFF-0008VR-Fz; Wed, 06 May 2020 18:58:13 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWPFC-0008Sd-C3 for linux-mediatek@lists.infradead.org; Wed, 06 May 2020 18:58:11 +0000 Received: by mail-lf1-x141.google.com with SMTP id h26so2273635lfg.6 for ; Wed, 06 May 2020 11:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2hhU7YC1mHWJXOQCa9/YtvMX0AvTF/51BQ11Lkp2if0=; b=ENs11Z2E6PTphR/O7XEptV9DrkitQZwLiWGfUE3J1NThoeRLPWDK4tDps5BoTcWit1 zxwc6iaDbar5hppPTNmyGg+DQIeMEcKomHQdFBhyU8VETMfHL8W2a1Jd5FtPT4MSFPlx pW5uAwDfiblCrXtvPdUyMV5XllzXhrrMlu3/oW6uuJTz36qgimok4gbXBH4xnjVurcCX lcUe+U7g7T87tsCxaKgUy1ztqhvZkOlPI1dRGORUz42KQ/uPPuoOll0V3+DBw/rjO1OW I1Q/zUwoATalGf6bzwzmulWBAfKNsUBbxb1ZM1A5ACSkMtfwmtHD9gRLESdsOugAfng+ xmww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2hhU7YC1mHWJXOQCa9/YtvMX0AvTF/51BQ11Lkp2if0=; b=N/A+u+X77SW55hwl8QheMrXxFwdH9edU7mrd9eFo+KNZgHxvi1G3acrEEdnW8I7kWm L5W3jP72uO8GMpdTYtkeA3Xj86fMqKP006tNcfx+5t7vHwpCD7aRhygXETgzwlIghgAp 8+wek86dhChiVhXUQ55PvfhC75KAtcfMlkiyz9dJZeC3EauuaHXVI8EKQSysw3bwOJ96 mzWuo84QqKzf7jnFULELo8Q1d5aI0pY3DSAhjb9yYetsIEAUTm5S1L/3v80YWnqWNq+K BGwj63378+q1ccjHNerXbrn/XgfDNHFWka1fUbcQTbjrCu+Kejk4408ifnY5qqOlQeAt SpYQ== X-Gm-Message-State: AGi0PubwuEHshO8Sg1ypqXl/hDVgWpQEQIGAMkR8Abo0Mca/SVCVJX1w MHdzcZwq7+cPiFobO7clYg3nTGEzopIS6jgJt3Bajw== X-Google-Smtp-Source: APiQypK2/BS9DNLQgUdve0DnZIP+ggCdF8l9P6mtknH7uy4q8+KLPietCh0cyMKc+/gJFltqkIhzsPf/UxXxP4Q5v8I= X-Received: by 2002:a19:40d2:: with SMTP id n201mr6168784lfa.82.1588791485423; Wed, 06 May 2020 11:58:05 -0700 (PDT) MIME-Version: 1.0 References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> In-Reply-To: <1480357509-28074-12-git-send-email-johan@kernel.org> From: Naresh Kamboju Date: Thu, 7 May 2020 00:27:53 +0530 Message-ID: Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks To: Johan Hovold , linux- stable , Greg Kroah-Hartman , Sasha Levin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_115810_450659_3901BF0A X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org, Pantelis Antoniou , Frank Rowand , Felix Fietkau , Florian Fainelli , Claudiu Manoil , Li Yang , Mugunthan V N , Grygorii Strashko , linuxppc-dev@lists.ozlabs.org, Rob Herring , linux-mediatek@lists.infradead.org, Lars Persson , Matthias Brugger , linux-omap@vger.kernel.org, John Crispin , Thomas Petazzoni , Fugang Duan , Sergei Shtylyov , Vivien Didelot , Netdev , open list , linux-renesas-soc@vger.kernel.org, Vitaly Bordug , nios2-dev@lists.rocketboards.org, Vince Bridgers , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 29 Nov 2016 at 00:00, Johan Hovold wrote: > > Make sure to deregister and free any fixed-link PHY registered using > of_phy_register_fixed_link() on probe errors and on driver unbind. > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > Signed-off-by: Johan Hovold > --- > drivers/net/ethernet/marvell/mvneta.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 0c0a45af950f..707bc4680b9b 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev) > clk_disable_unprepare(pp->clk); > err_put_phy_node: > of_node_put(phy_node); > + if (of_phy_is_fixed_link(dn)) > + of_phy_deregister_fixed_link(dn); While building kernel Image for arm architecture on stable-rc 4.4 branch the following build error found. drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit declaration of function 'of_phy_deregister_fixed_link'; did you mean 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration] | of_phy_deregister_fixed_link(dn); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | of_phy_register_fixed_link ref: https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729 - Naresh _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek