From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2423C4708F for ; Mon, 31 May 2021 08:43:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D60F60FEE for ; Mon, 31 May 2021 08:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230300AbhEaIoh (ORCPT ); Mon, 31 May 2021 04:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230143AbhEaIog (ORCPT ); Mon, 31 May 2021 04:44:36 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B336C061574 for ; Mon, 31 May 2021 01:42:56 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id o21so11151231iow.13 for ; Mon, 31 May 2021 01:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9Mi3Wc4wHLv8tIa+hLjhTLDdoH9+eOQcDbBHus3jcwY=; b=hmCoSp24fBHkpCJ28/A6H2mG7drh7iE2gbHVnUjd1F1/a3qgfa8Zg5buYb8D+kPRKA vFIN03NL5UJpHITGd5GvRt2B0XSEAd4ecFyCDFA7WEOA0mhkiJdQDdF829F9kuTzdweg AnTkvd2kPIDZJjnUlirre/MzXhHQ1Wjf/n5S4lBrOhMGBjUGBs5hENrV6jnpcdMO3mzM uFwS7sT4URADbSCEQ3RfqHu3QeVJ3+Qbcgq1B6BEAmYglRBWh/QzhYWzSbQHDftubtsn Kkzls7I1UsFqwsYL74ajif2EmBraY2OzRKm77LradLFjvKjm5TF9i1rJAC86RKTIATRn p+cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9Mi3Wc4wHLv8tIa+hLjhTLDdoH9+eOQcDbBHus3jcwY=; b=J/4SGtFGe0ASCNyXk6mAU2C6dZViIZOJ4+gArbHBuchS7+0sIK/ZMlxx7VYFS7FPVq Sw3awCTofNKtzj4yXMbOM6fQaW8pi/c9YhC1imCUWyLyVazjJ6eWS/W0yd9rqPKu5DFQ AuDDb4Wk7JCkQ1lJV0BJjGRkzYsjufOp60M2ERMc9ZTSt+/volbztXxpY6luFU4JBkHF n4fz9e1xcZFZDC8ssrb6eB/uyps1EYskk30L+ACkctFnGGnqPAJjGX/+1hrauR3YGxEy zIQRNZdA/suTo0f24XqUfddxEKdRIvuwj5Ce1Gr3gSK2v8PECFPIX/e5Clz6bM9pAoDx zLzA== X-Gm-Message-State: AOAM533Tco1l6w804/NCc6GoHMkXKXYMQMeQfTjygtQQCuCdVurue4sU 55v/hXEKXhFiTEmhfn7thy/tcVl7DANy/2BfTbOfJw== X-Google-Smtp-Source: ABdhPJyEWiPmm+WC4L8StZTlomC4jIjIdzDIxQp1eeRM1WySUE3xGQ8LMbo3OEoapR/arPt9GZt+Javtp/uLoK2sWmE= X-Received: by 2002:a05:6602:189:: with SMTP id m9mr16236035ioo.88.1622450575393; Mon, 31 May 2021 01:42:55 -0700 (PDT) MIME-Version: 1.0 References: <20210524120539.3267145-1-robert.marko@sartura.hr> <20210524120539.3267145-3-robert.marko@sartura.hr> <20210524230940.GA1350504@robh.at.kernel.org> <20210525074649.GC4005783@dell> <20210526075255.GG4005783@dell> In-Reply-To: <20210526075255.GG4005783@dell> From: Robert Marko Date: Mon, 31 May 2021 10:42:44 +0200 Message-ID: Subject: Re: [PATCH v2 3/4] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings To: Lee Jones Cc: Rob Herring , Linus Walleij , bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luka Perkov , jmp@epiphyte.org, Paul Menzel , Donald Buczek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, May 26, 2021 at 9:52 AM Lee Jones wrote: > > On Tue, 25 May 2021, Robert Marko wrote: > > > On Tue, May 25, 2021 at 9:46 AM Lee Jones wrote: > > > > > > On Mon, 24 May 2021, Rob Herring wrote: > > > > > > > On Mon, May 24, 2021 at 02:05:38PM +0200, Robert Marko wrote: > > > > > Add binding documents for the Delta TN48M CPLD drivers. > > > > > > > > > > Signed-off-by: Robert Marko > > > > > --- > > > > > Changes in v2: > > > > > * Implement MFD as a simple I2C MFD > > > > > * Add GPIO bindings as separate > > > > > > > > I don't understand why this changed. This doesn't look like an MFD = to > > > > me. Make your binding complete if there are missing functions. > > > > Otherwise, stick with what I already ok'ed. > > > > > > Right. What else, besides GPIO, does this do? > > > > It currently does not do anything else as hwmon driver was essentially > > NACK-ed for not exposing standard attributes. > > Once this provides more than GPIO capabilities i.e. becomes a proper > Multi-Function Device, then it can use the MFD framework. Until then, > it's a GPIO device I'm afraid. > > Are you going to re-author the HWMON driver to conform? hwmon cannot be reathored as it has no standard hwmon attributes. > > > The CPLD itself has PSU status-related information, bootstrap related > > information, > > various resets for the CPU-s, OOB ethernet PHY, information on the exac= t board > > model it's running etc. > > > > PSU and model-related info stuff is gonna be exposed via a misc driver > > in debugfs as > > we have user-space SW depending on that. > > I thought we agreed on that as v1 MFD driver was exposing those directl= y and > > not doing anything else. > > Yes, we agreed that creating an MFD driver just to expose chip > attributes was not an acceptable solution. > > > So I moved to use the simple I2C MFD driver, this is all modeled on the= sl28cpld > > which currently uses the same driver and then GPIO regmap as I do. > > > > Other stuff like the resets is probably gonna get exposed later when > > it's required > > to control it directly. > > In order for this driver to tick the MFD box, it's going to need more > than one function. Understood, would a debug driver count or I can expose the resets via a reset driver as we have a future use for them? Regards, Robert > > > > > > .../bindings/gpio/delta,tn48m-gpio.yaml | 42 ++++++++++ > > > > > .../bindings/mfd/delta,tn48m-cpld.yaml | 81 +++++++++++++= ++++++ > > > > > 2 files changed, 123 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/gpio/delta,= tn48m-gpio.yaml > > > > > create mode 100644 Documentation/devicetree/bindings/mfd/delta,t= n48m-cpld.yaml > > > > > > > > > > > -- > Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] > Senior Technical Lead - Developer Services > Linaro.org =E2=94=82 Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog --=20 Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr