From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ramon Fried Date: Mon, 28 May 2018 23:01:21 +0300 Subject: [U-Boot] [U-Boot,v2,4/7] mach-snapdragon: Fix UART clock flow In-Reply-To: <50f2b0f7-6f39-d368-7482-cca49d20659a@baylibre.com> References: <20180516091342.7509-4-ramon.fried@gmail.com> <20180528191241.GD21194@bill-the-cat.ec.rr.com> <75456e68-d6e0-5fd8-f906-53a232dec488@baylibre.com> <50f2b0f7-6f39-d368-7482-cca49d20659a@baylibre.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 28, 2018 at 10:59 PM, Jorge Ramirez-Ortiz wrote: > On 05/28/2018 09:48 PM, Ramon Fried wrote: >> >> On Mon, May 28, 2018 at 10:24 PM, Ramon Fried >> wrote: >>> >>> On Mon, May 28, 2018 at 10:19 PM, Jorge Ramirez-Ortiz >>> wrote: >>>> >>>> On 05/28/2018 09:12 PM, Tom Rini wrote: >>>>> >>>>> On Wed, May 16, 2018 at 12:13:39PM +0300, Ramon Fried wrote: >>>>> >>>>>> UART clock enabling flow was wrong. >>>>>> Changed the flow according to downstream implementation in LK. >>>>>> >>>>>> Signed-off-by: Ramon Fried >>>>> >>>>> Applied to u-boot/master, thanks! >>>>> >>>> Ramon, did you re-test this one on the 820 as we discussed? >>>> Sorry Tom, when I tested this on Friday it broke my 820 (I should have >>>> reported it to the ML). >>>> >>>> I think it introduces a regression but I'll let Ramon to confirm. >>> >>> Hi. >>> It's funny, I'm debugging it now. don't have any conclusions yet but I >>> was under the assumption that it won't get merged as it was >>> missing Reviewed-by. >>> Let me get back to you on these one in couple of hours. >>> Thanks, >>> Ramon. >> >> I just toasted my 820 board...:( >> I can only get a replacement by Thursday. >> I can't find any explanation why the 820 should be affected, as the >> clock configuration for it is empty. >> and it's pre-initalized by the uart. >> Jorge, you previously tested from my branch, care to test from master >> to see if it's working ? > > > so just pull your master branch again and retest? not mine. upstream master. > > >> Thanks. >> Ramon. > >