From: Ramon Fried <ramon.fried@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,v2,4/7] mach-snapdragon: Fix UART clock flow
Date: Mon, 28 May 2018 22:48:36 +0300 [thread overview]
Message-ID: <CA+Kvs9kVSU60m5z4vOJq4h0H6S95cN98bymEOGLr=N0Q1aqxtg@mail.gmail.com> (raw)
In-Reply-To: <CA+Kvs9n6ujAmjgin7fbmcADqC+NMyrE6Jq63MX4dbntC8O6tUw@mail.gmail.com>
On Mon, May 28, 2018 at 10:24 PM, Ramon Fried <ramon.fried@gmail.com> wrote:
> On Mon, May 28, 2018 at 10:19 PM, Jorge Ramirez-Ortiz
> <jramirez@baylibre.com> wrote:
>> On 05/28/2018 09:12 PM, Tom Rini wrote:
>>>
>>> On Wed, May 16, 2018 at 12:13:39PM +0300, Ramon Fried wrote:
>>>
>>>> UART clock enabling flow was wrong.
>>>> Changed the flow according to downstream implementation in LK.
>>>>
>>>> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
>>>
>>> Applied to u-boot/master, thanks!
>>>
>>
>> Ramon, did you re-test this one on the 820 as we discussed?
>> Sorry Tom, when I tested this on Friday it broke my 820 (I should have
>> reported it to the ML).
>>
>> I think it introduces a regression but I'll let Ramon to confirm.
> Hi.
> It's funny, I'm debugging it now. don't have any conclusions yet but I
> was under the assumption that it won't get merged as it was
> missing Reviewed-by.
> Let me get back to you on these one in couple of hours.
> Thanks,
> Ramon.
>>
I just toasted my 820 board...:(
I can only get a replacement by Thursday.
I can't find any explanation why the 820 should be affected, as the
clock configuration for it is empty.
and it's pre-initalized by the uart.
Jorge, you previously tested from my branch, care to test from master
to see if it's working ?
Thanks.
Ramon.
next prev parent reply other threads:[~2018-05-28 19:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 9:13 [U-Boot] [PATCH v2 1/7] db820c: set clk node to be probed before relocation Ramon Fried
2018-05-16 9:13 ` [U-Boot] [PATCH v2 2/7] serial: serial_msm: fail probe if settings clocks fails Ramon Fried
2018-05-16 15:40 ` Simon Glass
2018-05-28 19:12 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-05-16 9:13 ` [U-Boot] [PATCH v2 3/7] serial: serial_msm: initialize uart only before relocation Ramon Fried
2018-05-16 20:57 ` Simon Glass
2018-05-28 19:12 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-05-16 9:13 ` [U-Boot] [PATCH v2 4/7] mach-snapdragon: Fix UART clock flow Ramon Fried
2018-05-28 19:12 ` [U-Boot] [U-Boot,v2,4/7] " Tom Rini
2018-05-28 19:19 ` Jorge Ramirez-Ortiz
2018-05-28 19:24 ` Ramon Fried
2018-05-28 19:26 ` Tom Rini
2018-05-28 19:28 ` Ramon Fried
2018-05-28 19:35 ` Tom Rini
2018-05-28 19:37 ` Ramon Fried
2018-05-28 19:48 ` Ramon Fried [this message]
2018-05-28 19:59 ` Jorge Ramirez-Ortiz
2018-05-28 20:01 ` Ramon Fried
2018-05-28 20:07 ` Jorge Ramirez-Ortiz
2018-05-28 20:14 ` Ramon Fried
2018-05-28 20:25 ` Ramon Fried
2018-05-28 21:07 ` Jorge Ramirez-Ortiz
2018-05-28 21:11 ` Jorge Ramirez-Ortiz
2018-05-28 21:28 ` Ramon Fried
2018-05-16 9:13 ` [U-Boot] [PATCH v2 5/7] mach-snapdragon: Introduce pinctrl driver Ramon Fried
2018-05-16 15:40 ` Simon Glass
2018-05-28 19:12 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-05-16 9:13 ` [U-Boot] [PATCH v2 6/7] db410: added pinctrl node and serial bindings Ramon Fried
2018-05-28 19:12 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-05-16 9:13 ` [U-Boot] [PATCH v2 7/7] serial: serial_msm: added pinmux & config Ramon Fried
2018-05-28 19:12 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-05-16 20:57 ` [U-Boot] [PATCH v2 1/7] db820c: set clk node to be probed before relocation Simon Glass
2018-05-28 19:12 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Kvs9kVSU60m5z4vOJq4h0H6S95cN98bymEOGLr=N0Q1aqxtg@mail.gmail.com' \
--to=ramon.fried@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.