From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v2 1/2] pinctrl/samsung: Correct EINTG banks order Date: Tue, 17 Apr 2018 11:12:38 +0900 Message-ID: References: <1523893966-8884-1-git-send-email-pawel.mikolaj.chmiel@gmail.com> <1523893966-8884-2-git-send-email-pawel.mikolaj.chmiel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1523893966-8884-2-git-send-email-pawel.mikolaj.chmiel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?Q?Pawe=C5=82_Chmiel?= Cc: Krzysztof Kozlowski , Sylwester Nawrocki , "linus.walleij@linaro.org" , Kukjin Kim , linux-arm-kernel , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , linux-gpio@vger.kernel.org, linux-kernel , stable@vger.kernel.org List-Id: linux-gpio@vger.kernel.org 2018-04-17 0:52 GMT+09:00 Pawe=C5=82 Chmiel : > All banks with GPIO interrupts should be at beginning > of bank array and without any other types of banks between them. > This order is expected by exynos_eint_gpio_irq, when doing > interrupt group to bank translation. > Otherwise, kernel NULL pointer dereference would happen > when trying to handle interrupt, due to wrong bank being looked up. > Observed on s5pv210, when trying to handle gpj0 interrupt, > where kernel was mapping it to gpi bank. > > Cc: stable@vger.kernel.org > Fixes: 023e06dfa6882f500b9c86fd61f0b1913aa07f36 ("pinctrl: exynos: add ex= ynos5410 SoC specific data") > Fixes: 608a26a7bc04a39cfd7041f31ca2b2100113d14e ("pinctrl: Add s5pv210 su= pport to pinctrl-exynos) > Signed-off-by: Pawe=C5=82 Chmiel > --- > > Changes from v1: > - Limit changes to s5pv210 and Exynos5410. Exynos3250 will be handled l= ater. > - Added cc stable > - Added fixes tag > --- > drivers/pinctrl/samsung/pinctrl-exynos-arm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Tomasz Figa Thanks for the patch! Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Tue, 17 Apr 2018 11:12:38 +0900 Subject: [PATCH v2 1/2] pinctrl/samsung: Correct EINTG banks order In-Reply-To: <1523893966-8884-2-git-send-email-pawel.mikolaj.chmiel@gmail.com> References: <1523893966-8884-1-git-send-email-pawel.mikolaj.chmiel@gmail.com> <1523893966-8884-2-git-send-email-pawel.mikolaj.chmiel@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2018-04-17 0:52 GMT+09:00 Pawe? Chmiel : > All banks with GPIO interrupts should be at beginning > of bank array and without any other types of banks between them. > This order is expected by exynos_eint_gpio_irq, when doing > interrupt group to bank translation. > Otherwise, kernel NULL pointer dereference would happen > when trying to handle interrupt, due to wrong bank being looked up. > Observed on s5pv210, when trying to handle gpj0 interrupt, > where kernel was mapping it to gpi bank. > > Cc: stable at vger.kernel.org > Fixes: 023e06dfa6882f500b9c86fd61f0b1913aa07f36 ("pinctrl: exynos: add exynos5410 SoC specific data") > Fixes: 608a26a7bc04a39cfd7041f31ca2b2100113d14e ("pinctrl: Add s5pv210 support to pinctrl-exynos) > Signed-off-by: Pawe? Chmiel > --- > > Changes from v1: > - Limit changes to s5pv210 and Exynos5410. Exynos3250 will be handled later. > - Added cc stable > - Added fixes tag > --- > drivers/pinctrl/samsung/pinctrl-exynos-arm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Tomasz Figa Thanks for the patch! Best regards, Tomasz