From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753776AbcJIHEr (ORCPT ); Sun, 9 Oct 2016 03:04:47 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:34122 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898AbcJIHEo (ORCPT ); Sun, 9 Oct 2016 03:04:44 -0400 MIME-Version: 1.0 In-Reply-To: <1472987060-28293-1-git-send-email-krzk@kernel.org> References: <1472987060-28293-1-git-send-email-krzk@kernel.org> From: Tomasz Figa Date: Sun, 9 Oct 2016 16:04:11 +0900 Message-ID: Subject: Re: [PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Rob Herring , Mark Rutland , linux-kernel , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" , devicetree , Kukjin Kim , Arnd Bergmann , Javier Martinez Canillas , Linus Walleij , Bartlomiej Zolnierkiewicz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, 2016-09-04 20:04 GMT+09:00 Krzysztof Kozlowski : > > Hi, > > Changes since v2 > ================ > 1. Combine separate patchsets into one. Previously I sent separately the fixes > and changes for S3C platforms. > 2. Fix issues pointed during review. > 3. Add review tags. > > Changes since v1 > ================ > 1. Follow Arnd's suggestion about moving the macros to common place. > 2. Subjects: replace "GPIO" with "pinctrl". > 3. There were some major changes here so I did not add Javier's > reviewed-by and tested-by tags. > > Merging > ======= > Patches #1 and #2 should probably go through pinctrl tree. In that case I would > appreciate a stable branch/tag so DTS could base on top of it. > > Goal > ==== > Increase readability: > uart0_data: uart0-data { > samsung,pins = "gpa0-0", "gpa0-1"; > - samsung,pin-function = <2>; > - samsung,pin-pud = <0>; > - samsung,pin-drv = <0>; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; I like the idea, thanks for cleaning this up. However I'd like to bikeshed the prefix a bit. Since the properties are already prefixed by "samsung,", I think it would make much more sense to also prefix the generic values with "SAMSUNG_". Of course for soc/family-specific values, the soc/family name prefix sounds right. Similarly for rest of the value names, such as SAMSUNG_PIN_PUD instead of SAMSUNG_PIN_PULL, which obviously sounds more like correct English, however hurts the consistency and could confuse the people writing new dts files. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration Date: Sun, 9 Oct 2016 16:04:11 +0900 Message-ID: References: <1472987060-28293-1-git-send-email-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1472987060-28293-1-git-send-email-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Rob Herring , Mark Rutland , linux-kernel , linux-arm-kernel , "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , devicetree , Kukjin Kim , Arnd Bergmann , Javier Martinez Canillas , Linus Walleij , Bartlomiej Zolnierkiewicz List-Id: devicetree@vger.kernel.org Hi Krzysztof, 2016-09-04 20:04 GMT+09:00 Krzysztof Kozlowski : > > Hi, > > Changes since v2 > ================ > 1. Combine separate patchsets into one. Previously I sent separately the fixes > and changes for S3C platforms. > 2. Fix issues pointed during review. > 3. Add review tags. > > Changes since v1 > ================ > 1. Follow Arnd's suggestion about moving the macros to common place. > 2. Subjects: replace "GPIO" with "pinctrl". > 3. There were some major changes here so I did not add Javier's > reviewed-by and tested-by tags. > > Merging > ======= > Patches #1 and #2 should probably go through pinctrl tree. In that case I would > appreciate a stable branch/tag so DTS could base on top of it. > > Goal > ==== > Increase readability: > uart0_data: uart0-data { > samsung,pins = "gpa0-0", "gpa0-1"; > - samsung,pin-function = <2>; > - samsung,pin-pud = <0>; > - samsung,pin-drv = <0>; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; I like the idea, thanks for cleaning this up. However I'd like to bikeshed the prefix a bit. Since the properties are already prefixed by "samsung,", I think it would make much more sense to also prefix the generic values with "SAMSUNG_". Of course for soc/family-specific values, the soc/family name prefix sounds right. Similarly for rest of the value names, such as SAMSUNG_PIN_PUD instead of SAMSUNG_PIN_PULL, which obviously sounds more like correct English, however hurts the consistency and could confuse the people writing new dts files. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Sun, 9 Oct 2016 16:04:11 +0900 Subject: [PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration In-Reply-To: <1472987060-28293-1-git-send-email-krzk@kernel.org> References: <1472987060-28293-1-git-send-email-krzk@kernel.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Krzysztof, 2016-09-04 20:04 GMT+09:00 Krzysztof Kozlowski : > > Hi, > > Changes since v2 > ================ > 1. Combine separate patchsets into one. Previously I sent separately the fixes > and changes for S3C platforms. > 2. Fix issues pointed during review. > 3. Add review tags. > > Changes since v1 > ================ > 1. Follow Arnd's suggestion about moving the macros to common place. > 2. Subjects: replace "GPIO" with "pinctrl". > 3. There were some major changes here so I did not add Javier's > reviewed-by and tested-by tags. > > Merging > ======= > Patches #1 and #2 should probably go through pinctrl tree. In that case I would > appreciate a stable branch/tag so DTS could base on top of it. > > Goal > ==== > Increase readability: > uart0_data: uart0-data { > samsung,pins = "gpa0-0", "gpa0-1"; > - samsung,pin-function = <2>; > - samsung,pin-pud = <0>; > - samsung,pin-drv = <0>; > + samsung,pin-function = ; > + samsung,pin-pud = ; > + samsung,pin-drv = ; I like the idea, thanks for cleaning this up. However I'd like to bikeshed the prefix a bit. Since the properties are already prefixed by "samsung,", I think it would make much more sense to also prefix the generic values with "SAMSUNG_". Of course for soc/family-specific values, the soc/family name prefix sounds right. Similarly for rest of the value names, such as SAMSUNG_PIN_PUD instead of SAMSUNG_PIN_PULL, which obviously sounds more like correct English, however hurts the consistency and could confuse the people writing new dts files. Best regards, Tomasz