From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932388AbaLAQHQ (ORCPT ); Mon, 1 Dec 2014 11:07:16 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:35419 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932300AbaLAQHM (ORCPT ); Mon, 1 Dec 2014 11:07:12 -0500 MIME-Version: 1.0 In-Reply-To: <1416834177-11170-1-git-send-email-gautam.vivek@samsung.com> References: <1416834177-11170-1-git-send-email-gautam.vivek@samsung.com> Date: Tue, 2 Dec 2014 01:07:11 +0900 Message-ID: Subject: Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7 From: Tomasz Figa To: Vivek Gautam Cc: linux-kernel , "linux-samsung-soc@vger.kernel.org" , USB list , devicetree , Sylwester Nawrocki , Rob Herring , Kukjin Kim , Alim Akhtar , Linus Walleij Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vivek, Please see my comments below. 2014-11-24 22:02 GMT+09:00 Vivek Gautam : > USB and Power regulator on Exynos7 require gpios available > in BUS1 pin controller block. > So adding the BUS1 pinctrl support. > > Signed-off-by: Naveen Krishna Ch > Signed-off-by: Vivek Gautam > Cc: Linus Walleij > --- > > This patch was part of series: > "[PATCH 00/11] Exynos7: Adding USB 3.0 support" > https://lkml.org/lkml/2014/11/21/247 > > Changes since V1: > - Added support for all pin banks which are part of BUS1 pin controller. > > drivers/pinctrl/samsung/pinctrl-exynos.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) I have missed this with previous patch, but DT bindings documentation should list all aliases for all supported compatible strings, because they are required for correct operation. There is a small section about aliases in [1] already, so please add there information about aliases for Exynos7 pin controllers along with their names, e.g. Aliases for controllers compatible with "samsung,exynos7-pinctrl": - pinctrl0: pin controller of ALIVE block, - pinctrl1: pin controller of BUS0 block, [...] - pinctrl8: pin controller of BUS1 block. [1] Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt I guess you can do this in separate patch or respin this one with this added. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7 Date: Tue, 2 Dec 2014 01:07:11 +0900 Message-ID: References: <1416834177-11170-1-git-send-email-gautam.vivek@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1416834177-11170-1-git-send-email-gautam.vivek@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Vivek Gautam Cc: linux-kernel , "linux-samsung-soc@vger.kernel.org" , USB list , devicetree , Sylwester Nawrocki , Rob Herring , Kukjin Kim , Alim Akhtar , Linus Walleij List-Id: devicetree@vger.kernel.org Hi Vivek, Please see my comments below. 2014-11-24 22:02 GMT+09:00 Vivek Gautam : > USB and Power regulator on Exynos7 require gpios available > in BUS1 pin controller block. > So adding the BUS1 pinctrl support. > > Signed-off-by: Naveen Krishna Ch > Signed-off-by: Vivek Gautam > Cc: Linus Walleij > --- > > This patch was part of series: > "[PATCH 00/11] Exynos7: Adding USB 3.0 support" > https://lkml.org/lkml/2014/11/21/247 > > Changes since V1: > - Added support for all pin banks which are part of BUS1 pin controller. > > drivers/pinctrl/samsung/pinctrl-exynos.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) I have missed this with previous patch, but DT bindings documentation should list all aliases for all supported compatible strings, because they are required for correct operation. There is a small section about aliases in [1] already, so please add there information about aliases for Exynos7 pin controllers along with their names, e.g. Aliases for controllers compatible with "samsung,exynos7-pinctrl": - pinctrl0: pin controller of ALIVE block, - pinctrl1: pin controller of BUS0 block, [...] - pinctrl8: pin controller of BUS1 block. [1] Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt I guess you can do this in separate patch or respin this one with this added. Best regards, Tomasz