From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC9CC433E1 for ; Mon, 17 Aug 2020 17:01:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 396B620716 for ; Mon, 17 Aug 2020 17:01:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHgr2XhL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730108AbgHQRB0 (ORCPT ); Mon, 17 Aug 2020 13:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730003AbgHQRBN (ORCPT ); Mon, 17 Aug 2020 13:01:13 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D920C061389; Mon, 17 Aug 2020 10:01:11 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id g19so18316221ioh.8; Mon, 17 Aug 2020 10:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7QBcITzR7oBFEugc9nX1hxSt40e3uHeGjBJ8k9Ii1wk=; b=fHgr2XhLG9zj5YkcLQCd22NWhIzfoaeu5QeDS+zuPzhgz6A9WrGtRdh1mQGvYcgzgH 6fj9TEyhln/WsR5x6BeC/423hYjuYZ9wlMXn5FPXN6T07cqvK8Y0oPlHotB2Gh5KOdJT LJif1UzKeOQupsxHtrzDH/KPmIbvLLTsQG6KiVJJ3NvgHwx1pmdFar1M/FHW0UasC8Ll R6VPhg+9IY93n8I8ad7FHyBc+B1u5jept/EHHoEy+14aujf43pE8VBOGQoTiOWPAvjEb WdQW5G6QLx6h4Ma3swlKqupxWiwrjKAcA1iKiIuVFJMfGb0ZdOml/F6Vl6D2fImHN7d0 gJ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7QBcITzR7oBFEugc9nX1hxSt40e3uHeGjBJ8k9Ii1wk=; b=fMWw829erfdWc35n5lKmlLLiIh+9HmNE0hB41ezzkPTMFGq6g+qSR7mFqY5/MIMddl 5ODHUeaBkz3PtE+NBtBBHbi0a2E4TBMZin4QWu1iuI1AlnYpNm546DDhKaq5FPwStpte HIXUuPNUvvny0duPb7L9gB8/V6wRjFOG0bt3izbF2x/2vallDC4vh3ncRb5H/UpphGL/ ZYfU8bEIDhmjWT+pkleAjy+xrJadkmPGvjS2CwIewhShllbqYwuJTfVGZV2fMonyYYuw 9zYAGo2mQiduADRfYKfq4WFaPI+tcG+3LnxFdxeeAVUkdxCxY7QtJ5t6yliIlaj8fwac qlNQ== X-Gm-Message-State: AOAM533gSSOdGpkkFLrZ6P7QYFJJfyB+B0uX7AeAsatiXMpdviaDGjeM sxC1uD0pX/E3CYCKHN0MGSWceRJTL9Z/fJ+6wtvHBkx6 X-Google-Smtp-Source: ABdhPJyXrGoxJReNPAI+1RpBbwcrrU2PnQSgVLTs6ychSyck01qgTlPaYHYMzi+J5YyRvm1QP4hn4zCwUZeN4+VdjeU= X-Received: by 2002:a02:95ae:: with SMTP id b43mr15158386jai.19.1597683670733; Mon, 17 Aug 2020 10:01:10 -0700 (PDT) MIME-Version: 1.0 References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-7-krzk@kernel.org> <20200817165748.GA29664@kozik-lap> In-Reply-To: <20200817165748.GA29664@kozik-lap> From: Tomasz Figa Date: Mon, 17 Aug 2020 19:00:54 +0200 Message-ID: Subject: Re: [PATCH v2 06/13] ARM: samsung: remove HAVE_S3C2410_WATCHDOG and use direct dependencies To: Krzysztof Kozlowski Cc: Guenter Roeck , Russell King , Kukjin Kim , Simtec Linux Team , Arnd Bergmann , Maxime Coquelin , Alexandre Torgue , Kyungmin Park , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Chanwoo Choi , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , linux-arm-kernel , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, "open list:COMMON CLK FRAMEWORK" , linux-watchdog@vger.kernel.org, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org 2020=E5=B9=B48=E6=9C=8817=E6=97=A5(=E6=9C=88) 18:57 Krzysztof Kozlowski : > > On Tue, Aug 04, 2020 at 09:26:47PM +0200, Krzysztof Kozlowski wrote: > > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs is not > > really needed and the s3c24xx watchdog driver can depend on Samsung ARM > > architectures instead. > > > > The "HAVE_xxx_WATCHDOG" pattern of dependency is not popular and Samsun= g > > platforms are here exceptions. All others just depend on > > CONFIG_ARCH_xxx. > > > > This makes the code slightly smaller without any change in > > functionality. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v1: > > 1. Re-add the dependency on architectures to keep same functionality. > > Hi Guenter, Tomasz, > > Does such removal of HAVE_S3C2410_WATCHDOG makes sense for you? I don't have any objections and the patch itself is trivial. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74486C433E1 for ; Mon, 17 Aug 2020 17:02:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 436202067C for ; Mon, 17 Aug 2020 17:02:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AqeCHCbe"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHgr2XhL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 436202067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TZ6Le1oJEnmjTlX9lIpDX1viPQE+wahk2yISK9MkhaY=; b=AqeCHCbeK7IV8Mao9ESdHnRpp 15Pmvxzin5TV/ddmf9dn8mxQDARZoRwhQ7NnUmI0DZzjtpPql7MQ2kAbM29a0h4cDnOTuJJUJ/F7I 9pjMMDJu8CMnA94rWYcqppA66XM5QW15RGkWE4wvHcNLxnidHKbAOqa+HLd2dunjvgmyJiElRFWwJ K+WGrkCaEt00hQcUYLcsyYDmEcZ3DK6uYErpRl3Ff6KumAMdN8MbTdm+3M251V5LA7RMGpN/UuoYR 4W8CD/kmBzfnOg6E4FQXCxRueqx6GEZSvWyEhOxc8abEhT1nW4nXC8BdaZkbmjY1FtQUTjoNogPqm iXOBJUuDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7iVa-0006jD-5z; Mon, 17 Aug 2020 17:01:18 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7iVW-0006hR-Gx for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 17:01:15 +0000 Received: by mail-io1-xd42.google.com with SMTP id b17so18308076ion.7 for ; Mon, 17 Aug 2020 10:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7QBcITzR7oBFEugc9nX1hxSt40e3uHeGjBJ8k9Ii1wk=; b=fHgr2XhLG9zj5YkcLQCd22NWhIzfoaeu5QeDS+zuPzhgz6A9WrGtRdh1mQGvYcgzgH 6fj9TEyhln/WsR5x6BeC/423hYjuYZ9wlMXn5FPXN6T07cqvK8Y0oPlHotB2Gh5KOdJT LJif1UzKeOQupsxHtrzDH/KPmIbvLLTsQG6KiVJJ3NvgHwx1pmdFar1M/FHW0UasC8Ll R6VPhg+9IY93n8I8ad7FHyBc+B1u5jept/EHHoEy+14aujf43pE8VBOGQoTiOWPAvjEb WdQW5G6QLx6h4Ma3swlKqupxWiwrjKAcA1iKiIuVFJMfGb0ZdOml/F6Vl6D2fImHN7d0 gJ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7QBcITzR7oBFEugc9nX1hxSt40e3uHeGjBJ8k9Ii1wk=; b=PZKHleaMlxSjv8NGCf8D1EbQIuY4il6DxZuHWLhsXpx4jx4sf1hvc3Yi5b2FcqhUU9 TZglvLSj49FQxMZENrk8MpVh+bOxtfQ3UKE54G1+XeNhaTLIfTsTuGS2R/eYWjw2Tfdy BNw+aAYI6M5hgOZYYh5Pi9WMgPNgZQyXsPQBXirDGa2EsB2IETpBKILQgAEYIu4Rk/+o eWSuVgJ1/Bojj6rI1KWdXusnRrimvCQ24smP9efuFheacmLM6A+WPWahGeFpYByawqAN rD/uzPLSaEkXdxR3uZsNAVILCuu8RjBVo3HHiaEyc1lfkp7dq2GfRqlTjvN3X/17+sfs cBuw== X-Gm-Message-State: AOAM532bvPTuCLR5uj2wmFm3HWSG8pV0vnsppGARmWwSi1r28vDfrLaL rFzixU6p1N69sOfUD5EytpqskqR5wMXnDn53qIw= X-Google-Smtp-Source: ABdhPJyXrGoxJReNPAI+1RpBbwcrrU2PnQSgVLTs6ychSyck01qgTlPaYHYMzi+J5YyRvm1QP4hn4zCwUZeN4+VdjeU= X-Received: by 2002:a02:95ae:: with SMTP id b43mr15158386jai.19.1597683670733; Mon, 17 Aug 2020 10:01:10 -0700 (PDT) MIME-Version: 1.0 References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-7-krzk@kernel.org> <20200817165748.GA29664@kozik-lap> In-Reply-To: <20200817165748.GA29664@kozik-lap> From: Tomasz Figa Date: Mon, 17 Aug 2020 19:00:54 +0200 Message-ID: Subject: Re: [PATCH v2 06/13] ARM: samsung: remove HAVE_S3C2410_WATCHDOG and use direct dependencies To: Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_130114_705953_BB6EC11A X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Sylwester Nawrocki , Will Deacon , "open list:COMMON CLK FRAMEWORK" , linux-watchdog@vger.kernel.org, "moderated list:SAMSUNG SOC CLOCK DRIVERS" , Sylwester Nawrocki , Cedric Roux , Russell King , linux-stm32@st-md-mailman.stormreply.com, Lihua Yao , Chanwoo Choi , Kukjin Kim , Marek Szyprowski , Guenter Roeck , Sergio Prado , Alexandre Torgue , Arnd Bergmann , Wim Van Sebroeck , Simtec Linux Team , linux-arm-kernel , Stephen Boyd , patches@opensource.cirrus.com, Kyungmin Park , Maxime Coquelin Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjAyMOW5tDjmnIgxN+aXpSjmnIgpIDE4OjU3IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtAa2Vy bmVsLm9yZz46Cj4KPiBPbiBUdWUsIEF1ZyAwNCwgMjAyMCBhdCAwOToyNjo0N1BNICswMjAwLCBL cnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+ID4gQSBzZXBhcmF0ZSBLY29uZmlnIG9wdGlvbiBI QVZFX1MzQzI0MTBfV0FUQ0hET0cgZm9yIFNhbXN1bmcgU29DcyBpcyBub3QKPiA+IHJlYWxseSBu ZWVkZWQgYW5kIHRoZSBzM2MyNHh4IHdhdGNoZG9nIGRyaXZlciBjYW4gZGVwZW5kIG9uIFNhbXN1 bmcgQVJNCj4gPiBhcmNoaXRlY3R1cmVzIGluc3RlYWQuCj4gPgo+ID4gVGhlICJIQVZFX3h4eF9X QVRDSERPRyIgcGF0dGVybiBvZiBkZXBlbmRlbmN5IGlzIG5vdCBwb3B1bGFyIGFuZCBTYW1zdW5n Cj4gPiBwbGF0Zm9ybXMgYXJlIGhlcmUgZXhjZXB0aW9ucy4gIEFsbCBvdGhlcnMganVzdCBkZXBl bmQgb24KPiA+IENPTkZJR19BUkNIX3h4eC4KPiA+Cj4gPiBUaGlzIG1ha2VzIHRoZSBjb2RlIHNs aWdodGx5IHNtYWxsZXIgd2l0aG91dCBhbnkgY2hhbmdlIGluCj4gPiBmdW5jdGlvbmFsaXR5Lgo+ ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9y Zz4KPiA+Cj4gPiAtLS0KPiA+Cj4gPiBDaGFuZ2VzIHNpbmNlIHYxOgo+ID4gMS4gUmUtYWRkIHRo ZSBkZXBlbmRlbmN5IG9uIGFyY2hpdGVjdHVyZXMgdG8ga2VlcCBzYW1lIGZ1bmN0aW9uYWxpdHku Cj4KPiBIaSBHdWVudGVyLCBUb21hc3osCj4KPiBEb2VzIHN1Y2ggcmVtb3ZhbCBvZiBIQVZFX1Mz QzI0MTBfV0FUQ0hET0cgbWFrZXMgc2Vuc2UgZm9yIHlvdT8KCkkgZG9uJ3QgaGF2ZSBhbnkgb2Jq ZWN0aW9ucyBhbmQgdGhlIHBhdGNoIGl0c2VsZiBpcyB0cml2aWFsLgoKQmVzdCByZWdhcmRzLApU b21hc3oKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK