All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/crtc-helper: use drm_framebuffer flags
@ 2014-07-01 12:40 Fabien DESSENNE
  2014-07-10  8:01 ` Fabien DESSENNE
  0 siblings, 1 reply; 7+ messages in thread
From: Fabien DESSENNE @ 2014-07-01 12:40 UTC (permalink / raw)
  To: dri-devel; +Cc: Fabien Dessenne, Benjamin Gaignard

The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be
propagated and used by the driver.
The only possible value of flags is DRM_MODE_FB_INTERLACED.

Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Reviewed-by: Benjamin GAIGNARD <benjamin.gaignard@st.com>
---
 drivers/gpu/drm/drm_crtc_helper.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index 23500c0..5974489 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb,
 	drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth,
 				    &fb->bits_per_pixel);
 	fb->pixel_format = mode_cmd->pixel_format;
+	fb->flags = mode_cmd->flags;
 
 	return 0;
 }
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* RE: [PATCH] drm/crtc-helper: use drm_framebuffer flags
  2014-07-01 12:40 [PATCH] drm/crtc-helper: use drm_framebuffer flags Fabien DESSENNE
@ 2014-07-10  8:01 ` Fabien DESSENNE
  2014-07-22 15:40     ` Benjamin Gaignard
  0 siblings, 1 reply; 7+ messages in thread
From: Fabien DESSENNE @ 2014-07-10  8:01 UTC (permalink / raw)
  To: dri-devel; +Cc: Benjamin Gaignard

Hi,
Can anyone review this patch ?
Thanks for your time.
Fabien

> -----Original Message-----
> From: Fabien DESSENNE [mailto:fabien.dessenne@st.com]
> Sent: mardi 1 juillet 2014 14:41
> To: dri-devel@lists.freedesktop.org
> Cc: Benjamin Gaignard; Vincent ABRIOU; Fabien DESSENNE
> Subject: [PATCH] drm/crtc-helper: use drm_framebuffer flags
> 
> The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be
> propagated and used by the driver.
> The only possible value of flags is DRM_MODE_FB_INTERLACED.
> 
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> Reviewed-by: Benjamin GAIGNARD <benjamin.gaignard@st.com>
> ---
>  drivers/gpu/drm/drm_crtc_helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> b/drivers/gpu/drm/drm_crtc_helper.c
> index 23500c0..5974489 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct
> drm_framebuffer *fb,
>  	drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth,
>  				    &fb->bits_per_pixel);
>  	fb->pixel_format = mode_cmd->pixel_format;
> +	fb->flags = mode_cmd->flags;
> 
>  	return 0;
>  }
> --
> 1.9.1

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/crtc-helper: use drm_framebuffer flags
  2014-07-10  8:01 ` Fabien DESSENNE
@ 2014-07-22 15:40     ` Benjamin Gaignard
  0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Gaignard @ 2014-07-22 15:40 UTC (permalink / raw)
  To: Fabien DESSENNE, Linux Kernel Mailing List, David Airlie
  Cc: dri-devel, Vincent ABRIOU

Adding LKML and David in diffusion list to get an opinion on this patch

2014-07-10 10:01 GMT+02:00 Fabien DESSENNE <fabien.dessenne@st.com>:
> Hi,
> Can anyone review this patch ?
> Thanks for your time.
> Fabien
>
>> -----Original Message-----
>> From: Fabien DESSENNE [mailto:fabien.dessenne@st.com]
>> Sent: mardi 1 juillet 2014 14:41
>> To: dri-devel@lists.freedesktop.org
>> Cc: Benjamin Gaignard; Vincent ABRIOU; Fabien DESSENNE
>> Subject: [PATCH] drm/crtc-helper: use drm_framebuffer flags
>>
>> The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be
>> propagated and used by the driver.
>> The only possible value of flags is DRM_MODE_FB_INTERLACED.
>>
>> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
>> Reviewed-by: Benjamin GAIGNARD <benjamin.gaignard@st.com>
>> ---
>>  drivers/gpu/drm/drm_crtc_helper.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
>> b/drivers/gpu/drm/drm_crtc_helper.c
>> index 23500c0..5974489 100644
>> --- a/drivers/gpu/drm/drm_crtc_helper.c
>> +++ b/drivers/gpu/drm/drm_crtc_helper.c
>> @@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct
>> drm_framebuffer *fb,
>>       drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth,
>>                                   &fb->bits_per_pixel);
>>       fb->pixel_format = mode_cmd->pixel_format;
>> +     fb->flags = mode_cmd->flags;
>>
>>       return 0;
>>  }
>> --
>> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/crtc-helper: use drm_framebuffer flags
@ 2014-07-22 15:40     ` Benjamin Gaignard
  0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Gaignard @ 2014-07-22 15:40 UTC (permalink / raw)
  To: Fabien DESSENNE, Linux Kernel Mailing List, David Airlie; +Cc: dri-devel

Adding LKML and David in diffusion list to get an opinion on this patch

2014-07-10 10:01 GMT+02:00 Fabien DESSENNE <fabien.dessenne@st.com>:
> Hi,
> Can anyone review this patch ?
> Thanks for your time.
> Fabien
>
>> -----Original Message-----
>> From: Fabien DESSENNE [mailto:fabien.dessenne@st.com]
>> Sent: mardi 1 juillet 2014 14:41
>> To: dri-devel@lists.freedesktop.org
>> Cc: Benjamin Gaignard; Vincent ABRIOU; Fabien DESSENNE
>> Subject: [PATCH] drm/crtc-helper: use drm_framebuffer flags
>>
>> The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be
>> propagated and used by the driver.
>> The only possible value of flags is DRM_MODE_FB_INTERLACED.
>>
>> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
>> Reviewed-by: Benjamin GAIGNARD <benjamin.gaignard@st.com>
>> ---
>>  drivers/gpu/drm/drm_crtc_helper.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
>> b/drivers/gpu/drm/drm_crtc_helper.c
>> index 23500c0..5974489 100644
>> --- a/drivers/gpu/drm/drm_crtc_helper.c
>> +++ b/drivers/gpu/drm/drm_crtc_helper.c
>> @@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct
>> drm_framebuffer *fb,
>>       drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth,
>>                                   &fb->bits_per_pixel);
>>       fb->pixel_format = mode_cmd->pixel_format;
>> +     fb->flags = mode_cmd->flags;
>>
>>       return 0;
>>  }
>> --
>> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/crtc-helper: use drm_framebuffer flags
  2014-07-22 15:40     ` Benjamin Gaignard
@ 2014-07-22 22:37       ` Dave Airlie
  -1 siblings, 0 replies; 7+ messages in thread
From: Dave Airlie @ 2014-07-22 22:37 UTC (permalink / raw)
  To: Benjamin Gaignard
  Cc: Fabien DESSENNE, Linux Kernel Mailing List, David Airlie, dri-devel

On 23 July 2014 01:40, Benjamin Gaignard <benjamin.gaignard@linaro.org> wrote:
> Adding LKML and David in diffusion list to get an opinion on this patch
>
> 2014-07-10 10:01 GMT+02:00 Fabien DESSENNE <fabien.dessenne@st.com>:
>> Hi,
>> Can anyone review this patch ?

It's been in drm-next for a few weeks.

Dave.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/crtc-helper: use drm_framebuffer flags
@ 2014-07-22 22:37       ` Dave Airlie
  0 siblings, 0 replies; 7+ messages in thread
From: Dave Airlie @ 2014-07-22 22:37 UTC (permalink / raw)
  To: Benjamin Gaignard; +Cc: dri-devel, Linux Kernel Mailing List, Fabien DESSENNE

On 23 July 2014 01:40, Benjamin Gaignard <benjamin.gaignard@linaro.org> wrote:
> Adding LKML and David in diffusion list to get an opinion on this patch
>
> 2014-07-10 10:01 GMT+02:00 Fabien DESSENNE <fabien.dessenne@st.com>:
>> Hi,
>> Can anyone review this patch ?

It's been in drm-next for a few weeks.

Dave.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] drm/crtc-helper: use drm_framebuffer flags
@ 2014-07-01 12:28 Fabien DESSENNE
  0 siblings, 0 replies; 7+ messages in thread
From: Fabien DESSENNE @ 2014-07-01 12:28 UTC (permalink / raw)
  To: dri-devel; +Cc: Fabien Dessenne, Benjamin Gaignard

The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be
propagated and used by the driver.
The only possible value of flags is DRM_MODE_FB_INTERLACED.

Change-Id: I989c01b1e6eef753eb004a5ac876665ea8ab0da6
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Change-Id: I2350ad8bd1553a4a7388e8d8b7733e65f1e8caef
Reviewed-on: https://gerrit.st.com/8141
Reviewed-by: Benjamin GAIGNARD <benjamin.gaignard@st.com>
---
 drivers/gpu/drm/drm_crtc_helper.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index 23500c0..5974489 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -966,6 +966,7 @@ int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb,
 	drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth,
 				    &fb->bits_per_pixel);
 	fb->pixel_format = mode_cmd->pixel_format;
+	fb->flags = mode_cmd->flags;
 
 	return 0;
 }
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-07-22 22:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-01 12:40 [PATCH] drm/crtc-helper: use drm_framebuffer flags Fabien DESSENNE
2014-07-10  8:01 ` Fabien DESSENNE
2014-07-22 15:40   ` Benjamin Gaignard
2014-07-22 15:40     ` Benjamin Gaignard
2014-07-22 22:37     ` Dave Airlie
2014-07-22 22:37       ` Dave Airlie
  -- strict thread matches above, loose matches on Subject: below --
2014-07-01 12:28 Fabien DESSENNE

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.