From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Subject: Re: [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs Date: Mon, 15 Oct 2018 11:12:55 +0200 Message-ID: References: <20181013151707.32210-1-hch@lst.de> <20181013151707.32210-8-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20181013151707.32210-8-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, ML dri-devel , linux-media@vger.kernel.org, linux-spi@vger.kernel.org, Linux Fbdev development list , alsa-devel@alsa-project.org, Linux Kernel Mailing List List-Id: linux-tegra@vger.kernel.org Le sam. 13 oct. 2018 =C3=A0 17:18, Christoph Hellwig a =C3=A9c= rit : > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig Reviewed-by: Benjamin Gaignard > --- > drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/= platform/sti/bdisp/bdisp-hw.c > index 26d9fa7aeb5f..4372abbb5950 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c > @@ -510,7 +510,7 @@ int bdisp_hw_alloc_filters(struct device *dev) > > /* Allocate all the filters within a single memory page */ > size =3D (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER= ); > - base =3D dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA, > + base =3D dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL, > DMA_ATTR_WRITE_COMBINE); > if (!base) > return -ENOMEM; > -- > 2.19.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --=20 Benjamin Gaignard Graphic Study Group Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Date: Mon, 15 Oct 2018 09:12:55 +0000 Subject: Re: [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs Message-Id: List-Id: References: <20181013151707.32210-1-hch@lst.de> <20181013151707.32210-8-hch@lst.de> In-Reply-To: <20181013151707.32210-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Christoph Hellwig Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, ML dri-devel , linux-media@vger.kernel.org, linux-spi@vger.kernel.org, Linux Fbdev development list , alsa-devel@alsa-project.org, Linux Kernel Mailing List Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig a écrit : > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig Reviewed-by: Benjamin Gaignard > --- > drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c > index 26d9fa7aeb5f..4372abbb5950 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c > @@ -510,7 +510,7 @@ int bdisp_hw_alloc_filters(struct device *dev) > > /* Allocate all the filters within a single memory page */ > size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER); > - base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA, > + base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL, > DMA_ATTR_WRITE_COMBINE); > if (!base) > return -ENOMEM; > -- > 2.19.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog