From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756685AbdAJI4M (ORCPT ); Tue, 10 Jan 2017 03:56:12 -0500 Received: from mail-qt0-f170.google.com ([209.85.216.170]:36851 "EHLO mail-qt0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755059AbdAJI4J (ORCPT ); Tue, 10 Jan 2017 03:56:09 -0500 MIME-Version: 1.0 In-Reply-To: <20170109180051.uwd4su3maj5gkf5l@rob-hp-laptop> References: <1483608344-9012-1-git-send-email-benjamin.gaignard@st.com> <1483608344-9012-3-git-send-email-benjamin.gaignard@st.com> <20170109180051.uwd4su3maj5gkf5l@rob-hp-laptop> From: Benjamin Gaignard Date: Tue, 10 Jan 2017 09:56:08 +0100 Message-ID: Subject: Re: [PATCH v7 2/8] MFD: add STM32 Timers driver To: Rob Herring Cc: Lee Jones , Mark Rutland , Alexandre Torgue , devicetree@vger.kernel.org, Linux Kernel Mailing List , Thierry Reding , Linux PWM List , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabrice Gasnier , Gerald Baeza , Arnaud Pouliquen , Linus Walleij , Linaro Kernel Mailman List , Benjamin Gaignard Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0A8uIN1026647 2017-01-09 19:00 GMT+01:00 Rob Herring : > On Thu, Jan 05, 2017 at 10:25:38AM +0100, Benjamin Gaignard wrote: >> This hardware block could at used at same time for PWM generation >> and IIO timers. >> PWM and IIO timer configuration are mixed in the same registers >> so we need a multi fonction driver to be able to share those registers. >> >> version 7: >> - rebase on v4.10-rc2 >> >> version 6: >> - rename files to stm32-timers >> - rename functions to stm32_timers_xxx >> >> version 5: >> - fix Lee comments about detect function >> - add missing dependency on REGMAP_MMIO >> >> version 4: >> - add a function to detect Auto Reload Register (ARR) size >> - rename the structure shared with other drivers >> >> version 2: >> - rename driver "stm32-gptimer" to be align with SoC documentation >> - only keep one compatible >> - use of_platform_populate() instead of devm_mfd_add_devices() >> >> Signed-off-by: Benjamin Gaignard >> --- >> .../devicetree/bindings/mfd/stm32-timers.txt | 2 +- >> drivers/mfd/Kconfig | 11 +++ >> drivers/mfd/Makefile | 2 + >> drivers/mfd/stm32-timers.c | 80 ++++++++++++++++++++++ >> include/linux/mfd/stm32-timers.h | 71 +++++++++++++++++++ >> 5 files changed, 165 insertions(+), 1 deletion(-) >> create mode 100644 drivers/mfd/stm32-timers.c >> create mode 100644 include/linux/mfd/stm32-timers.h >> >> diff --git a/Documentation/devicetree/bindings/mfd/stm32-timers.txt b/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> index a73301d..897e7c2 100644 >> --- a/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> +++ b/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> @@ -12,7 +12,7 @@ Required parameters: >> >> - reg: Physical base address and length of the controller's >> registers. >> -- clock-names: Set to "int". >> +- clock-names: Set to "int". > > This hunk should be dropped or moved to previous patch. I will move it in the previous patch > >> - clocks: Phandle to the clock used by the timer module. >> For Clk properties, please refer to ../clock/clock-bindings.txt >> -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Subject: Re: [PATCH v7 2/8] MFD: add STM32 Timers driver Date: Tue, 10 Jan 2017 09:56:08 +0100 Message-ID: References: <1483608344-9012-1-git-send-email-benjamin.gaignard@st.com> <1483608344-9012-3-git-send-email-benjamin.gaignard@st.com> <20170109180051.uwd4su3maj5gkf5l@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20170109180051.uwd4su3maj5gkf5l@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Lee Jones , Mark Rutland , Alexandre Torgue , devicetree@vger.kernel.org, Linux Kernel Mailing List , Thierry Reding , Linux PWM List , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabrice Gasnier , Gerald Baeza , Arnaud Pouliquen , Linus Walleij , Linaro Kernel Mailman List , Benjamin Gaignard List-Id: devicetree@vger.kernel.org 2017-01-09 19:00 GMT+01:00 Rob Herring : > On Thu, Jan 05, 2017 at 10:25:38AM +0100, Benjamin Gaignard wrote: >> This hardware block could at used at same time for PWM generation >> and IIO timers. >> PWM and IIO timer configuration are mixed in the same registers >> so we need a multi fonction driver to be able to share those registers. >> >> version 7: >> - rebase on v4.10-rc2 >> >> version 6: >> - rename files to stm32-timers >> - rename functions to stm32_timers_xxx >> >> version 5: >> - fix Lee comments about detect function >> - add missing dependency on REGMAP_MMIO >> >> version 4: >> - add a function to detect Auto Reload Register (ARR) size >> - rename the structure shared with other drivers >> >> version 2: >> - rename driver "stm32-gptimer" to be align with SoC documentation >> - only keep one compatible >> - use of_platform_populate() instead of devm_mfd_add_devices() >> >> Signed-off-by: Benjamin Gaignard >> --- >> .../devicetree/bindings/mfd/stm32-timers.txt | 2 +- >> drivers/mfd/Kconfig | 11 +++ >> drivers/mfd/Makefile | 2 + >> drivers/mfd/stm32-timers.c | 80 +++++++++++++++= +++++++ >> include/linux/mfd/stm32-timers.h | 71 +++++++++++++++= ++++ >> 5 files changed, 165 insertions(+), 1 deletion(-) >> create mode 100644 drivers/mfd/stm32-timers.c >> create mode 100644 include/linux/mfd/stm32-timers.h >> >> diff --git a/Documentation/devicetree/bindings/mfd/stm32-timers.txt b/Do= cumentation/devicetree/bindings/mfd/stm32-timers.txt >> index a73301d..897e7c2 100644 >> --- a/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> +++ b/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> @@ -12,7 +12,7 @@ Required parameters: >> >> - reg: Physical base address and length of the co= ntroller's >> registers. >> -- clock-names: Set to "int". >> +- clock-names: Set to "int". > > This hunk should be dropped or moved to previous patch. I will move it in the previous patch > >> - clocks: Phandle to the clock used by the timer module. >> For Clk properties, please refer to ../clock/clock= -bindings.txt >> --=20 Benjamin Gaignard Graphic Study Group Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f169.google.com ([209.85.216.169]:36851 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756579AbdAJI4J (ORCPT ); Tue, 10 Jan 2017 03:56:09 -0500 Received: by mail-qt0-f169.google.com with SMTP id k15so389153996qtg.3 for ; Tue, 10 Jan 2017 00:56:09 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170109180051.uwd4su3maj5gkf5l@rob-hp-laptop> References: <1483608344-9012-1-git-send-email-benjamin.gaignard@st.com> <1483608344-9012-3-git-send-email-benjamin.gaignard@st.com> <20170109180051.uwd4su3maj5gkf5l@rob-hp-laptop> From: Benjamin Gaignard Date: Tue, 10 Jan 2017 09:56:08 +0100 Message-ID: Subject: Re: [PATCH v7 2/8] MFD: add STM32 Timers driver To: Rob Herring Cc: Lee Jones , Mark Rutland , Alexandre Torgue , devicetree@vger.kernel.org, Linux Kernel Mailing List , Thierry Reding , Linux PWM List , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabrice Gasnier , Gerald Baeza , Arnaud Pouliquen , Linus Walleij , Linaro Kernel Mailman List , Benjamin Gaignard Content-Type: text/plain; charset=UTF-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org 2017-01-09 19:00 GMT+01:00 Rob Herring : > On Thu, Jan 05, 2017 at 10:25:38AM +0100, Benjamin Gaignard wrote: >> This hardware block could at used at same time for PWM generation >> and IIO timers. >> PWM and IIO timer configuration are mixed in the same registers >> so we need a multi fonction driver to be able to share those registers. >> >> version 7: >> - rebase on v4.10-rc2 >> >> version 6: >> - rename files to stm32-timers >> - rename functions to stm32_timers_xxx >> >> version 5: >> - fix Lee comments about detect function >> - add missing dependency on REGMAP_MMIO >> >> version 4: >> - add a function to detect Auto Reload Register (ARR) size >> - rename the structure shared with other drivers >> >> version 2: >> - rename driver "stm32-gptimer" to be align with SoC documentation >> - only keep one compatible >> - use of_platform_populate() instead of devm_mfd_add_devices() >> >> Signed-off-by: Benjamin Gaignard >> --- >> .../devicetree/bindings/mfd/stm32-timers.txt | 2 +- >> drivers/mfd/Kconfig | 11 +++ >> drivers/mfd/Makefile | 2 + >> drivers/mfd/stm32-timers.c | 80 +++++++++++++++= +++++++ >> include/linux/mfd/stm32-timers.h | 71 +++++++++++++++= ++++ >> 5 files changed, 165 insertions(+), 1 deletion(-) >> create mode 100644 drivers/mfd/stm32-timers.c >> create mode 100644 include/linux/mfd/stm32-timers.h >> >> diff --git a/Documentation/devicetree/bindings/mfd/stm32-timers.txt b/Do= cumentation/devicetree/bindings/mfd/stm32-timers.txt >> index a73301d..897e7c2 100644 >> --- a/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> +++ b/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> @@ -12,7 +12,7 @@ Required parameters: >> >> - reg: Physical base address and length of the co= ntroller's >> registers. >> -- clock-names: Set to "int". >> +- clock-names: Set to "int". > > This hunk should be dropped or moved to previous patch. I will move it in the previous patch > >> - clocks: Phandle to the clock used by the timer module. >> For Clk properties, please refer to ../clock/clock= -bindings.txt >> --=20 Benjamin Gaignard Graphic Study Group Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: benjamin.gaignard@linaro.org (Benjamin Gaignard) Date: Tue, 10 Jan 2017 09:56:08 +0100 Subject: [PATCH v7 2/8] MFD: add STM32 Timers driver In-Reply-To: <20170109180051.uwd4su3maj5gkf5l@rob-hp-laptop> References: <1483608344-9012-1-git-send-email-benjamin.gaignard@st.com> <1483608344-9012-3-git-send-email-benjamin.gaignard@st.com> <20170109180051.uwd4su3maj5gkf5l@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2017-01-09 19:00 GMT+01:00 Rob Herring : > On Thu, Jan 05, 2017 at 10:25:38AM +0100, Benjamin Gaignard wrote: >> This hardware block could at used at same time for PWM generation >> and IIO timers. >> PWM and IIO timer configuration are mixed in the same registers >> so we need a multi fonction driver to be able to share those registers. >> >> version 7: >> - rebase on v4.10-rc2 >> >> version 6: >> - rename files to stm32-timers >> - rename functions to stm32_timers_xxx >> >> version 5: >> - fix Lee comments about detect function >> - add missing dependency on REGMAP_MMIO >> >> version 4: >> - add a function to detect Auto Reload Register (ARR) size >> - rename the structure shared with other drivers >> >> version 2: >> - rename driver "stm32-gptimer" to be align with SoC documentation >> - only keep one compatible >> - use of_platform_populate() instead of devm_mfd_add_devices() >> >> Signed-off-by: Benjamin Gaignard >> --- >> .../devicetree/bindings/mfd/stm32-timers.txt | 2 +- >> drivers/mfd/Kconfig | 11 +++ >> drivers/mfd/Makefile | 2 + >> drivers/mfd/stm32-timers.c | 80 ++++++++++++++++++++++ >> include/linux/mfd/stm32-timers.h | 71 +++++++++++++++++++ >> 5 files changed, 165 insertions(+), 1 deletion(-) >> create mode 100644 drivers/mfd/stm32-timers.c >> create mode 100644 include/linux/mfd/stm32-timers.h >> >> diff --git a/Documentation/devicetree/bindings/mfd/stm32-timers.txt b/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> index a73301d..897e7c2 100644 >> --- a/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> +++ b/Documentation/devicetree/bindings/mfd/stm32-timers.txt >> @@ -12,7 +12,7 @@ Required parameters: >> >> - reg: Physical base address and length of the controller's >> registers. >> -- clock-names: Set to "int". >> +- clock-names: Set to "int". > > This hunk should be dropped or moved to previous patch. I will move it in the previous patch > >> - clocks: Phandle to the clock used by the timer module. >> For Clk properties, please refer to ../clock/clock-bindings.txt >> -- Benjamin Gaignard Graphic Study Group Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog