From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbdKGN5c (ORCPT ); Tue, 7 Nov 2017 08:57:32 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:53598 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865AbdKGN5b (ORCPT ); Tue, 7 Nov 2017 08:57:31 -0500 X-Google-Smtp-Source: ABhQp+TKI+oFBp+PVgMQ1/CYRqLPJlcezcR00Zfqz9ezV4i/lWxeQJh/t9M0B9mNN3ePHsT28JJz+R9NcfYYg+KRp+4= MIME-Version: 1.0 In-Reply-To: <20171101113301.GD4111@jade> References: <1509013473-18365-1-git-send-email-philippe.cornu@st.com> <20171101113301.GD4111@jade> From: Benjamin Gaignard Date: Tue, 7 Nov 2017 14:57:30 +0100 Message-ID: Subject: Re: [PATCH] drm/stm: checkpatch strict minor updates To: Gustavo Padovan Cc: Philippe Cornu , Yannick Fertre , Vincent Abriou , David Airlie , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Alexandre Torgue , Fabien Dessenne , Maxime Coquelin , Mickael Reulier , Gabriel Fernandez , Ludovic Barre Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-11-01 12:33 GMT+01:00 Gustavo Padovan : > 2017-10-26 Philippe Cornu : > >> Minor fixes detected with "scripts/checkpatch.pl --strict" >> >> Signed-off-by: Philippe Cornu >> --- >> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++-- >> drivers/gpu/drm/stm/ltdc.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c >> index 10b2b77..3e8b9ed 100644 >> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c >> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c >> @@ -129,7 +129,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz, >> int fvco_min, fvco_max, delta, best_delta; /* all in khz */ >> >> /* Early checks preventing division by 0 & odd results */ >> - if ((clkin_khz <= 0) || (clkout_khz <= 0)) >> + if (clkin_khz <= 0 || clkout_khz <= 0) >> return -EINVAL; >> >> fvco_min = LANE_MIN_KBPS * 2 * ODF_MAX; >> @@ -155,7 +155,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz, >> for (o = ODF_MIN; o <= ODF_MAX; o *= 2) { >> n = DIV_ROUND_CLOSEST(i * o * clkout_khz, clkin_khz); >> /* Check ndiv according to vco range */ >> - if ((n < n_min) || (n > n_max)) >> + if (n < n_min || n > n_max) >> continue; >> /* Check if new delta is better & saves parameters */ >> delta = dsi_pll_get_clkout_khz(clkin_khz, i, n, o) - >> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c >> index 735c908..7be6710 100644 >> --- a/drivers/gpu/drm/stm/ltdc.c >> +++ b/drivers/gpu/drm/stm/ltdc.c >> @@ -556,7 +556,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane, >> src_h = state->src_h >> 16; >> >> /* Reject scaling */ >> - if ((src_w != state->crtc_w) || (src_h != state->crtc_h)) { >> + if (src_w != state->crtc_w || src_h != state->crtc_h) { >> DRM_ERROR("Scaling is not supported"); >> return -EINVAL; > > Reviewed-by: Gustavo Padovan > Applied on drm-misc-next. Thanks Benjamin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Subject: Re: [PATCH] drm/stm: checkpatch strict minor updates Date: Tue, 7 Nov 2017 14:57:30 +0100 Message-ID: References: <1509013473-18365-1-git-send-email-philippe.cornu@st.com> <20171101113301.GD4111@jade> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-x243.google.com (mail-qk0-x243.google.com [IPv6:2607:f8b0:400d:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7451689C16 for ; Tue, 7 Nov 2017 13:57:31 +0000 (UTC) Received: by mail-qk0-x243.google.com with SMTP id 78so8357266qkz.0 for ; Tue, 07 Nov 2017 05:57:31 -0800 (PST) In-Reply-To: <20171101113301.GD4111@jade> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: Alexandre Torgue , David Airlie , Philippe Cornu , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Yannick Fertre , Fabien Dessenne , Maxime Coquelin , Mickael Reulier , Vincent Abriou , Gabriel Fernandez , Ludovic Barre List-Id: dri-devel@lists.freedesktop.org MjAxNy0xMS0wMSAxMjozMyBHTVQrMDE6MDAgR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvQHBhZG92 YW4ub3JnPjoKPiAyMDE3LTEwLTI2IFBoaWxpcHBlIENvcm51IDxwaGlsaXBwZS5jb3JudUBzdC5j b20+Ogo+Cj4+IE1pbm9yIGZpeGVzIGRldGVjdGVkIHdpdGggInNjcmlwdHMvY2hlY2twYXRjaC5w bCAtLXN0cmljdCIKPj4KPj4gU2lnbmVkLW9mZi1ieTogUGhpbGlwcGUgQ29ybnUgPHBoaWxpcHBl LmNvcm51QHN0LmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vc3RtL2R3X21pcGlfZHNp LXN0bS5jIHwgNCArKy0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vc3RtL2x0ZGMuYyAgICAgICAgICAg IHwgMiArLQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RtL2R3X21pcGlfZHNpLXN0 bS5jIGIvZHJpdmVycy9ncHUvZHJtL3N0bS9kd19taXBpX2RzaS1zdG0uYwo+PiBpbmRleCAxMGIy Yjc3Li4zZThiOWVkIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3RtL2R3X21pcGlf ZHNpLXN0bS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9zdG0vZHdfbWlwaV9kc2ktc3RtLmMK Pj4gQEAgLTEyOSw3ICsxMjksNyBAQCBzdGF0aWMgaW50IGRzaV9wbGxfZ2V0X3BhcmFtcyhpbnQg Y2xraW5fa2h6LCBpbnQgY2xrb3V0X2toeiwKPj4gICAgICAgaW50IGZ2Y29fbWluLCBmdmNvX21h eCwgZGVsdGEsIGJlc3RfZGVsdGE7IC8qIGFsbCBpbiBraHogKi8KPj4KPj4gICAgICAgLyogRWFy bHkgY2hlY2tzIHByZXZlbnRpbmcgZGl2aXNpb24gYnkgMCAmIG9kZCByZXN1bHRzICovCj4+IC0g ICAgIGlmICgoY2xraW5fa2h6IDw9IDApIHx8IChjbGtvdXRfa2h6IDw9IDApKQo+PiArICAgICBp ZiAoY2xraW5fa2h6IDw9IDAgfHwgY2xrb3V0X2toeiA8PSAwKQo+PiAgICAgICAgICAgICAgIHJl dHVybiAtRUlOVkFMOwo+Pgo+PiAgICAgICBmdmNvX21pbiA9IExBTkVfTUlOX0tCUFMgKiAyICog T0RGX01BWDsKPj4gQEAgLTE1NSw3ICsxNTUsNyBAQCBzdGF0aWMgaW50IGRzaV9wbGxfZ2V0X3Bh cmFtcyhpbnQgY2xraW5fa2h6LCBpbnQgY2xrb3V0X2toeiwKPj4gICAgICAgICAgICAgICBmb3Ig KG8gPSBPREZfTUlOOyBvIDw9IE9ERl9NQVg7IG8gKj0gMikgewo+PiAgICAgICAgICAgICAgICAg ICAgICAgbiA9IERJVl9ST1VORF9DTE9TRVNUKGkgKiBvICogY2xrb3V0X2toeiwgY2xraW5fa2h6 KTsKPj4gICAgICAgICAgICAgICAgICAgICAgIC8qIENoZWNrIG5kaXYgYWNjb3JkaW5nIHRvIHZj byByYW5nZSAqLwo+PiAtICAgICAgICAgICAgICAgICAgICAgaWYgKChuIDwgbl9taW4pIHx8IChu ID4gbl9tYXgpKQo+PiArICAgICAgICAgICAgICAgICAgICAgaWYgKG4gPCBuX21pbiB8fCBuID4g bl9tYXgpCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+PiAgICAg ICAgICAgICAgICAgICAgICAgLyogQ2hlY2sgaWYgbmV3IGRlbHRhIGlzIGJldHRlciAmIHNhdmVz IHBhcmFtZXRlcnMgKi8KPj4gICAgICAgICAgICAgICAgICAgICAgIGRlbHRhID0gZHNpX3BsbF9n ZXRfY2xrb3V0X2toeihjbGtpbl9raHosIGksIG4sIG8pIC0KPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9zdG0vbHRkYy5jIGIvZHJpdmVycy9ncHUvZHJtL3N0bS9sdGRjLmMKPj4gaW5k ZXggNzM1YzkwOC4uN2JlNjcxMCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N0bS9s dGRjLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N0bS9sdGRjLmMKPj4gQEAgLTU1Niw3ICs1 NTYsNyBAQCBzdGF0aWMgaW50IGx0ZGNfcGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lLAo+PiAgICAgICBzcmNfaCA9IHN0YXRlLT5zcmNfaCA+PiAxNjsKPj4KPj4gICAg ICAgLyogUmVqZWN0IHNjYWxpbmcgKi8KPj4gLSAgICAgaWYgKChzcmNfdyAhPSBzdGF0ZS0+Y3J0 Y193KSB8fCAoc3JjX2ggIT0gc3RhdGUtPmNydGNfaCkpIHsKPj4gKyAgICAgaWYgKHNyY193ICE9 IHN0YXRlLT5jcnRjX3cgfHwgc3JjX2ggIT0gc3RhdGUtPmNydGNfaCkgewo+PiAgICAgICAgICAg ICAgIERSTV9FUlJPUigiU2NhbGluZyBpcyBub3Qgc3VwcG9ydGVkIik7Cj4+ICAgICAgICAgICAg ICAgcmV0dXJuIC1FSU5WQUw7Cj4KPiBSZXZpZXdlZC1ieTogR3VzdGF2byBQYWRvdmFuIDxndXN0 YXZvLnBhZG92YW5AY29sbGFib3JhLmNvbT4KPgoKQXBwbGllZCBvbiBkcm0tbWlzYy1uZXh0LgpU aGFua3MKCkJlbmphbWluCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=