From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933314AbcGLM7v (ORCPT ); Tue, 12 Jul 2016 08:59:51 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34523 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932139AbcGLM7t convert rfc822-to-8bit (ORCPT ); Tue, 12 Jul 2016 08:59:49 -0400 MIME-Version: 1.0 In-Reply-To: <1467684294-20111-5-git-send-email-peter.chen@nxp.com> References: <1467684294-20111-1-git-send-email-peter.chen@nxp.com> <1467684294-20111-5-git-send-email-peter.chen@nxp.com> From: Benjamin Gaignard Date: Tue, 12 Jul 2016 14:59:48 +0200 Message-ID: Subject: Re: [PATCH 4/7] gpu: drm: sti_hqvdp: add missing of_node_put after calling of_parse_phandle To: Peter Chen Cc: David Airlie , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Vincent Abriou Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Benjamin Gaignard 2016-07-05 4:04 GMT+02:00 Peter Chen : > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Peter Chen > --- > drivers/gpu/drm/sti/sti_hqvdp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c > index 1edec29..4f052fa 100644 > --- a/drivers/gpu/drm/sti/sti_hqvdp.c > +++ b/drivers/gpu/drm/sti/sti_hqvdp.c > @@ -1346,6 +1346,7 @@ static int sti_hqvdp_probe(struct platform_device *pdev) > vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 0); > if (vtg_np) > hqvdp->vtg = of_vtg_find(vtg_np); > + of_node_put(vtg_np); > > platform_set_drvdata(pdev, hqvdp); > > -- > 1.9.1 > -- Benjamin Gaignard Graphic Working Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Subject: Re: [PATCH 4/7] gpu: drm: sti_hqvdp: add missing of_node_put after calling of_parse_phandle Date: Tue, 12 Jul 2016 14:59:48 +0200 Message-ID: References: <1467684294-20111-1-git-send-email-peter.chen@nxp.com> <1467684294-20111-5-git-send-email-peter.chen@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-oi0-x22c.google.com (mail-oi0-x22c.google.com [IPv6:2607:f8b0:4003:c06::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id A621A6E555 for ; Tue, 12 Jul 2016 12:59:49 +0000 (UTC) Received: by mail-oi0-x22c.google.com with SMTP id j185so14504938oih.0 for ; Tue, 12 Jul 2016 05:59:49 -0700 (PDT) In-Reply-To: <1467684294-20111-5-git-send-email-peter.chen@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Chen Cc: Vincent Abriou , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org QWNrZWQtYnk6IEJlbmphbWluIEdhaWduYXJkIDxiZW5qYW1pbi5nYWlnbmFyZEBsaW5hcm8ub3Jn PgoKMjAxNi0wNy0wNSA0OjA0IEdNVCswMjowMCBQZXRlciBDaGVuIDxwZXRlci5jaGVuQG54cC5j b20+Ogo+IG9mX25vZGVfcHV0IG5lZWRzIHRvIGJlIGNhbGxlZCB3aGVuIHRoZSBkZXZpY2Ugbm9k ZSB3aGljaCBpcyBnb3QKPiBmcm9tIG9mX3BhcnNlX3BoYW5kbGUgaGFzIGZpbmlzaGVkIHVzaW5n Lgo+Cj4gQ2M6IEJlbmphbWluIEdhaWduYXJkIDxiZW5qYW1pbi5nYWlnbmFyZEBsaW5hcm8ub3Jn Pgo+IENjOiBWaW5jZW50IEFicmlvdSA8dmluY2VudC5hYnJpb3VAc3QuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IFBldGVyIENoZW4gPHBldGVyLmNoZW5AbnhwLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL3N0aS9zdGlfaHF2ZHAuYyB8IDEgKwo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9ocXZkcC5jIGIv ZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfaHF2ZHAuYwo+IGluZGV4IDFlZGVjMjkuLjRmMDUyZmEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfaHF2ZHAuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9zdGkvc3RpX2hxdmRwLmMKPiBAQCAtMTM0Niw2ICsxMzQ2LDcgQEAgc3Rh dGljIGludCBzdGlfaHF2ZHBfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAg ICAgICAgIHZ0Z19ucCA9IG9mX3BhcnNlX3BoYW5kbGUocGRldi0+ZGV2Lm9mX25vZGUsICJzdCx2 dGciLCAwKTsKPiAgICAgICAgIGlmICh2dGdfbnApCj4gICAgICAgICAgICAgICAgIGhxdmRwLT52 dGcgPSBvZl92dGdfZmluZCh2dGdfbnApOwo+ICsgICAgICAgb2Zfbm9kZV9wdXQodnRnX25wKTsK Pgo+ICAgICAgICAgcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgaHF2ZHApOwo+Cj4gLS0KPiAx LjkuMQo+CgoKCi0tIApCZW5qYW1pbiBHYWlnbmFyZAoKR3JhcGhpYyBXb3JraW5nIEdyb3VwCgpM aW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKCkZvbGxvdyBM aW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==