From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Date: Tue, 20 Jun 2017 17:07:46 +0200 Message-ID: References: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> <20170620100348.zh4ygvjjgnhxvmvl@piout.net> <20170620121011.GA13221@amd> <20170620122400.sm7qqvwyj6cuzarw@piout.net> <20170620132620.GA16881@amd> <6ED8E3B22081A4459DAC7699F3695FB7018CD96FCD@SW-EX-MBX02.diasemi.com> <20170620134458.GA10104@amd> <20170620134827.ubvzhh25klaotupv@piout.net> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170620134827.ubvzhh25klaotupv-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Alexandre Belloni Cc: Pavel Machek , Steve Twiss , "linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org" , "adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Alessandro Zummo , Gregory Clement , Ingo Molnar , Jason Cooper , John Stultz , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linus Walleij , Michael Chan , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , Sebastian Hesselbarth , Support Opensource List-Id: linux-tegra@vger.kernel.org 2017-06-20 15:48 GMT+02:00 Alexandre Belloni : > On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: >> On Tue 2017-06-20 13:37:22, Steve Twiss wrote: >> > Hi Pavel, >> > >> > On 20 June 2017 14:26, Pavel Machek wrote: >> > >> > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions >> > > >> > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: >> > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: >> > > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: >> > > > > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: >> > > > > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they >> > > > > > > rely on 32bits variables and that will make rtc break in y2038/2016. >> > > > > > >> > > > > > Please don't, because this hide the fact that the hardware will not >> > > > > > handle dates in y2038 anyway and as pointed by Russell a few month ago, >> > > > > > rtc_time_to_tm will be able to catch it but the 64 bit version will >> > > > > > silently ignore it. >> > > > > >> > > > > Reference? Because rtc on PCs stores date in binary coded decimal, so >> > > > > it is likely to break in 2100, not 2038... >> > > > >> > > > I'm not saying it should be done but clearly, that is not the correct >> > > > thing to do for RTCs that are using a single 32 bits register to store >> > > > the time. >> > > > You give one example, I can give you three: armada38x, at91sam9, >> > > > at32ap700x and that just in the beginning of the series. >> > > >> > > I wanted reference to Russell's mail. >> > >> > This is it. >> > https://patchwork.kernel.org/patch/6219401/ >> >> Thanks. >> >> Yes, that's argument against changing rtc _drivers_ for hardware that >> can not do better than 32bit. For generic code (such as 44/51 sysfs, >> 51/51 suspend test), the change still makes sense. What I had in mind when writing those patches was to remove the limitations coming from those functions usage, even more since they been marked has deprecated. I agree that will change nothing of hardware limitation but at least the limit will not come from the framework. >> > > Yes, we agree on that but I won't cherry pick working patches from a 51 > patches series. maybe only the acked ones ? > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdFTPHu (ORCPT ); Tue, 20 Jun 2017 11:07:50 -0400 Received: from mail-qt0-f169.google.com ([209.85.216.169]:35247 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbdFTPHr (ORCPT ); Tue, 20 Jun 2017 11:07:47 -0400 MIME-Version: 1.0 In-Reply-To: <20170620134827.ubvzhh25klaotupv@piout.net> References: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> <20170620100348.zh4ygvjjgnhxvmvl@piout.net> <20170620121011.GA13221@amd> <20170620122400.sm7qqvwyj6cuzarw@piout.net> <20170620132620.GA16881@amd> <6ED8E3B22081A4459DAC7699F3695FB7018CD96FCD@SW-EX-MBX02.diasemi.com> <20170620134458.GA10104@amd> <20170620134827.ubvzhh25klaotupv@piout.net> From: Benjamin Gaignard Date: Tue, 20 Jun 2017 17:07:46 +0200 Message-ID: Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions To: Alexandre Belloni Cc: Pavel Machek , Steve Twiss , "linaro-kernel@lists.linaro.org" , "adi-buildroot-devel@lists.sourceforge.net" , Alessandro Zummo , Gregory Clement , Ingo Molnar , Jason Cooper , John Stultz , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Linus Walleij , Michael Chan , "netdev@vger.kernel.org" , "rtc-linux@googlegroups.com" , Sebastian Hesselbarth , Support Opensource , Thomas Gleixner , "x86@kernel.org" , Baruch Siach , Hans Ulli Kroll , Vladimir Zapolskiy , Sylvain Lemieux , Barry Song , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , Jonathan Hunter , "linux-tegra@vger.kernel.org" , "patches@opensource.wolfsonmicro.com" , "Rafael J. Wysocki" , Len Brown , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-06-20 15:48 GMT+02:00 Alexandre Belloni : > On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: >> On Tue 2017-06-20 13:37:22, Steve Twiss wrote: >> > Hi Pavel, >> > >> > On 20 June 2017 14:26, Pavel Machek wrote: >> > >> > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions >> > > >> > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: >> > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: >> > > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: >> > > > > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: >> > > > > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they >> > > > > > > rely on 32bits variables and that will make rtc break in y2038/2016. >> > > > > > >> > > > > > Please don't, because this hide the fact that the hardware will not >> > > > > > handle dates in y2038 anyway and as pointed by Russell a few month ago, >> > > > > > rtc_time_to_tm will be able to catch it but the 64 bit version will >> > > > > > silently ignore it. >> > > > > >> > > > > Reference? Because rtc on PCs stores date in binary coded decimal, so >> > > > > it is likely to break in 2100, not 2038... >> > > > >> > > > I'm not saying it should be done but clearly, that is not the correct >> > > > thing to do for RTCs that are using a single 32 bits register to store >> > > > the time. >> > > > You give one example, I can give you three: armada38x, at91sam9, >> > > > at32ap700x and that just in the beginning of the series. >> > > >> > > I wanted reference to Russell's mail. >> > >> > This is it. >> > https://patchwork.kernel.org/patch/6219401/ >> >> Thanks. >> >> Yes, that's argument against changing rtc _drivers_ for hardware that >> can not do better than 32bit. For generic code (such as 44/51 sysfs, >> 51/51 suspend test), the change still makes sense. What I had in mind when writing those patches was to remove the limitations coming from those functions usage, even more since they been marked has deprecated. I agree that will change nothing of hardware limitation but at least the limit will not come from the framework. >> > > Yes, we agree on that but I won't cherry pick working patches from a 51 > patches series. maybe only the acked ones ? > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-qt0-x233.google.com (mail-qt0-x233.google.com. [2607:f8b0:400d:c0d::233]) by gmr-mx.google.com with ESMTPS id p68si876575ywg.9.2017.06.20.08.07.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2017 08:07:46 -0700 (PDT) Received: by mail-qt0-x233.google.com with SMTP id w1so134925326qtg.2 for ; Tue, 20 Jun 2017 08:07:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170620134827.ubvzhh25klaotupv@piout.net> References: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> <20170620100348.zh4ygvjjgnhxvmvl@piout.net> <20170620121011.GA13221@amd> <20170620122400.sm7qqvwyj6cuzarw@piout.net> <20170620132620.GA16881@amd> <6ED8E3B22081A4459DAC7699F3695FB7018CD96FCD@SW-EX-MBX02.diasemi.com> <20170620134458.GA10104@amd> <20170620134827.ubvzhh25klaotupv@piout.net> From: Benjamin Gaignard Date: Tue, 20 Jun 2017 17:07:46 +0200 Message-ID: Subject: [rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions To: Alexandre Belloni Cc: Pavel Machek , Steve Twiss , "linaro-kernel@lists.linaro.org" , "adi-buildroot-devel@lists.sourceforge.net" , Alessandro Zummo , Gregory Clement , Ingo Molnar , Jason Cooper , John Stultz , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Linus Walleij , Michael Chan , "netdev@vger.kernel.org" , "rtc-linux@googlegroups.com" , Sebastian Hesselbarth , Support Opensource , Thomas Gleixner , "x86@kernel.org" , Baruch Siach , Hans Ulli Kroll , Vladimir Zapolskiy , Sylvain Lemieux , Barry Song , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , Jonathan Hunter , "linux-tegra@vger.kernel.org" , "patches@opensource.wolfsonmicro.com" , "Rafael J. Wysocki" , Len Brown , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , 2017-06-20 15:48 GMT+02:00 Alexandre Belloni : > On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: >> On Tue 2017-06-20 13:37:22, Steve Twiss wrote: >> > Hi Pavel, >> > >> > On 20 June 2017 14:26, Pavel Machek wrote: >> > >> > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions >> > > >> > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: >> > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: >> > > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: >> > > > > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: >> > > > > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they >> > > > > > > rely on 32bits variables and that will make rtc break in y2038/2016. >> > > > > > >> > > > > > Please don't, because this hide the fact that the hardware will not >> > > > > > handle dates in y2038 anyway and as pointed by Russell a few month ago, >> > > > > > rtc_time_to_tm will be able to catch it but the 64 bit version will >> > > > > > silently ignore it. >> > > > > >> > > > > Reference? Because rtc on PCs stores date in binary coded decimal, so >> > > > > it is likely to break in 2100, not 2038... >> > > > >> > > > I'm not saying it should be done but clearly, that is not the correct >> > > > thing to do for RTCs that are using a single 32 bits register to store >> > > > the time. >> > > > You give one example, I can give you three: armada38x, at91sam9, >> > > > at32ap700x and that just in the beginning of the series. >> > > >> > > I wanted reference to Russell's mail. >> > >> > This is it. >> > https://patchwork.kernel.org/patch/6219401/ >> >> Thanks. >> >> Yes, that's argument against changing rtc _drivers_ for hardware that >> can not do better than 32bit. For generic code (such as 44/51 sysfs, >> 51/51 suspend test), the change still makes sense. What I had in mind when writing those patches was to remove the limitations coming from those functions usage, even more since they been marked has deprecated. I agree that will change nothing of hardware limitation but at least the limit will not come from the framework. >> > > Yes, we agree on that but I won't cherry pick working patches from a 51 > patches series. maybe only the acked ones ? > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Date: Tue, 20 Jun 2017 17:07:46 +0200 Message-ID: References: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> <20170620100348.zh4ygvjjgnhxvmvl@piout.net> <20170620121011.GA13221@amd> <20170620122400.sm7qqvwyj6cuzarw@piout.net> <20170620132620.GA16881@amd> <6ED8E3B22081A4459DAC7699F3695FB7018CD96FCD@SW-EX-MBX02.diasemi.com> <20170620134458.GA10104@amd> <20170620134827.ubvzhh25klaotupv@piout.net> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Pavel Machek , Steve Twiss , "linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org" , "adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Alessandro Zummo , Gregory Clement , Ingo Molnar , Jason Cooper , John Stultz , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linus Walleij , Michael Chan , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , Sebastian Hesselbarth , Support Opensource Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170620134827.ubvzhh25klaotupv-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: netdev.vger.kernel.org 2017-06-20 15:48 GMT+02:00 Alexandre Belloni : > On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: >> On Tue 2017-06-20 13:37:22, Steve Twiss wrote: >> > Hi Pavel, >> > >> > On 20 June 2017 14:26, Pavel Machek wrote: >> > >> > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions >> > > >> > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: >> > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: >> > > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: >> > > > > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: >> > > > > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they >> > > > > > > rely on 32bits variables and that will make rtc break in y2038/2016. >> > > > > > >> > > > > > Please don't, because this hide the fact that the hardware will not >> > > > > > handle dates in y2038 anyway and as pointed by Russell a few month ago, >> > > > > > rtc_time_to_tm will be able to catch it but the 64 bit version will >> > > > > > silently ignore it. >> > > > > >> > > > > Reference? Because rtc on PCs stores date in binary coded decimal, so >> > > > > it is likely to break in 2100, not 2038... >> > > > >> > > > I'm not saying it should be done but clearly, that is not the correct >> > > > thing to do for RTCs that are using a single 32 bits register to store >> > > > the time. >> > > > You give one example, I can give you three: armada38x, at91sam9, >> > > > at32ap700x and that just in the beginning of the series. >> > > >> > > I wanted reference to Russell's mail. >> > >> > This is it. >> > https://patchwork.kernel.org/patch/6219401/ >> >> Thanks. >> >> Yes, that's argument against changing rtc _drivers_ for hardware that >> can not do better than 32bit. For generic code (such as 44/51 sysfs, >> 51/51 suspend test), the change still makes sense. What I had in mind when writing those patches was to remove the limitations coming from those functions usage, even more since they been marked has deprecated. I agree that will change nothing of hardware limitation but at least the limit will not come from the framework. >> > > Yes, we agree on that but I won't cherry pick working patches from a 51 > patches series. maybe only the acked ones ? > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: benjamin.gaignard@linaro.org (Benjamin Gaignard) Date: Tue, 20 Jun 2017 17:07:46 +0200 Subject: [PATCH 00/51] rtc: stop using rtc deprecated functions In-Reply-To: <20170620134827.ubvzhh25klaotupv@piout.net> References: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> <20170620100348.zh4ygvjjgnhxvmvl@piout.net> <20170620121011.GA13221@amd> <20170620122400.sm7qqvwyj6cuzarw@piout.net> <20170620132620.GA16881@amd> <6ED8E3B22081A4459DAC7699F3695FB7018CD96FCD@SW-EX-MBX02.diasemi.com> <20170620134458.GA10104@amd> <20170620134827.ubvzhh25klaotupv@piout.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2017-06-20 15:48 GMT+02:00 Alexandre Belloni : > On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: >> On Tue 2017-06-20 13:37:22, Steve Twiss wrote: >> > Hi Pavel, >> > >> > On 20 June 2017 14:26, Pavel Machek wrote: >> > >> > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions >> > > >> > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: >> > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: >> > > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: >> > > > > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: >> > > > > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they >> > > > > > > rely on 32bits variables and that will make rtc break in y2038/2016. >> > > > > > >> > > > > > Please don't, because this hide the fact that the hardware will not >> > > > > > handle dates in y2038 anyway and as pointed by Russell a few month ago, >> > > > > > rtc_time_to_tm will be able to catch it but the 64 bit version will >> > > > > > silently ignore it. >> > > > > >> > > > > Reference? Because rtc on PCs stores date in binary coded decimal, so >> > > > > it is likely to break in 2100, not 2038... >> > > > >> > > > I'm not saying it should be done but clearly, that is not the correct >> > > > thing to do for RTCs that are using a single 32 bits register to store >> > > > the time. >> > > > You give one example, I can give you three: armada38x, at91sam9, >> > > > at32ap700x and that just in the beginning of the series. >> > > >> > > I wanted reference to Russell's mail. >> > >> > This is it. >> > https://patchwork.kernel.org/patch/6219401/ >> >> Thanks. >> >> Yes, that's argument against changing rtc _drivers_ for hardware that >> can not do better than 32bit. For generic code (such as 44/51 sysfs, >> 51/51 suspend test), the change still makes sense. What I had in mind when writing those patches was to remove the limitations coming from those functions usage, even more since they been marked has deprecated. I agree that will change nothing of hardware limitation but at least the limit will not come from the framework. >> > > Yes, we agree on that but I won't cherry pick working patches from a 51 > patches series. maybe only the acked ones ? > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com