From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933234AbcGLM7n (ORCPT ); Tue, 12 Jul 2016 08:59:43 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:34347 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932139AbcGLM7l convert rfc822-to-8bit (ORCPT ); Tue, 12 Jul 2016 08:59:41 -0400 MIME-Version: 1.0 In-Reply-To: <1467684294-20111-4-git-send-email-peter.chen@nxp.com> References: <1467684294-20111-1-git-send-email-peter.chen@nxp.com> <1467684294-20111-4-git-send-email-peter.chen@nxp.com> From: Benjamin Gaignard Date: Tue, 12 Jul 2016 14:59:35 +0200 Message-ID: Subject: Re: [PATCH 3/7] gpu: drm: sti_vdo: add missing of_node_put after calling of_parse_phandle To: Peter Chen Cc: David Airlie , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Vincent Abriou Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Benjamin Gaignard 2016-07-05 4:04 GMT+02:00 Peter Chen : > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Peter Chen > --- > drivers/gpu/drm/sti/sti_dvo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c > index 25f7663..7e211a8 100644 > --- a/drivers/gpu/drm/sti/sti_dvo.c > +++ b/drivers/gpu/drm/sti/sti_dvo.c > @@ -602,6 +602,7 @@ static int sti_dvo_probe(struct platform_device *pdev) > dvo->panel_node = of_parse_phandle(np, "sti,panel", 0); > if (!dvo->panel_node) > DRM_ERROR("No panel associated to the dvo output\n"); > + of_node_put(dvo->panel_node); > > platform_set_drvdata(pdev, dvo); > > -- > 1.9.1 > -- Benjamin Gaignard Graphic Working Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Subject: Re: [PATCH 3/7] gpu: drm: sti_vdo: add missing of_node_put after calling of_parse_phandle Date: Tue, 12 Jul 2016 14:59:35 +0200 Message-ID: References: <1467684294-20111-1-git-send-email-peter.chen@nxp.com> <1467684294-20111-4-git-send-email-peter.chen@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F3C66E239 for ; Tue, 12 Jul 2016 12:59:36 +0000 (UTC) Received: by mail-oi0-x231.google.com with SMTP id j185so14496101oih.0 for ; Tue, 12 Jul 2016 05:59:36 -0700 (PDT) In-Reply-To: <1467684294-20111-4-git-send-email-peter.chen@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Chen Cc: Vincent Abriou , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org QWNrZWQtYnk6IEJlbmphbWluIEdhaWduYXJkIDxiZW5qYW1pbi5nYWlnbmFyZEBsaW5hcm8ub3Jn PgoKMjAxNi0wNy0wNSA0OjA0IEdNVCswMjowMCBQZXRlciBDaGVuIDxwZXRlci5jaGVuQG54cC5j b20+Ogo+IG9mX25vZGVfcHV0IG5lZWRzIHRvIGJlIGNhbGxlZCB3aGVuIHRoZSBkZXZpY2Ugbm9k ZSB3aGljaCBpcyBnb3QKPiBmcm9tIG9mX3BhcnNlX3BoYW5kbGUgaGFzIGZpbmlzaGVkIHVzaW5n Lgo+Cj4gQ2M6IEJlbmphbWluIEdhaWduYXJkIDxiZW5qYW1pbi5nYWlnbmFyZEBsaW5hcm8ub3Jn Pgo+IENjOiBWaW5jZW50IEFicmlvdSA8dmluY2VudC5hYnJpb3VAc3QuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IFBldGVyIENoZW4gPHBldGVyLmNoZW5AbnhwLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL3N0aS9zdGlfZHZvLmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfZHZvLmMgYi9kcml2 ZXJzL2dwdS9kcm0vc3RpL3N0aV9kdm8uYwo+IGluZGV4IDI1Zjc2NjMuLjdlMjExYTggMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfZHZvLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vc3RpL3N0aV9kdm8uYwo+IEBAIC02MDIsNiArNjAyLDcgQEAgc3RhdGljIGludCBzdGlf ZHZvX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAgICAgICBkdm8tPnBh bmVsX25vZGUgPSBvZl9wYXJzZV9waGFuZGxlKG5wLCAic3RpLHBhbmVsIiwgMCk7Cj4gICAgICAg ICBpZiAoIWR2by0+cGFuZWxfbm9kZSkKPiAgICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJObyBw YW5lbCBhc3NvY2lhdGVkIHRvIHRoZSBkdm8gb3V0cHV0XG4iKTsKPiArICAgICAgIG9mX25vZGVf cHV0KGR2by0+cGFuZWxfbm9kZSk7Cj4KPiAgICAgICAgIHBsYXRmb3JtX3NldF9kcnZkYXRhKHBk ZXYsIGR2byk7Cj4KPiAtLQo+IDEuOS4xCj4KCgoKLS0gCkJlbmphbWluIEdhaWduYXJkCgpHcmFw aGljIFdvcmtpbmcgR3JvdXAKCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZv ciBBUk0gU29DcwoKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK