From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754476AbdCIKAt (ORCPT ); Thu, 9 Mar 2017 05:00:49 -0500 Received: from mail-qk0-f178.google.com ([209.85.220.178]:35678 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753918AbdCIKAq (ORCPT ); Thu, 9 Mar 2017 05:00:46 -0500 MIME-Version: 1.0 In-Reply-To: <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> References: <1488491084-17252-1-git-send-email-labbott@redhat.com> <20170303132949.GC31582@dhcp22.suse.cz> <20170306074258.GA27953@dhcp22.suse.cz> <20170306104041.zghsicrnadoap7lp@phenom.ffwll.local> <20170306105805.jsq44kfxhsvazkm6@sirena.org.uk> <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> From: Benjamin Gaignard Date: Thu, 9 Mar 2017 11:00:39 +0100 Message-ID: Subject: Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging To: Mark Brown , Michal Hocko , Laura Abbott , Sumit Semwal , Riley Andrews , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Rom Lemarchand , devel@driverdev.osuosl.org, Linux Kernel Mailing List , "linaro-mm-sig@lists.linaro.org" , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Brian Starkey , Daniel Vetter , Benjamin Gaignard , linux-mm@kvack.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-03-06 17:04 GMT+01:00 Daniel Vetter : > On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >> >> > No one gave a thing about android in upstream, so Greg KH just dumped it >> > all into staging/android/. We've discussed ION a bunch of times, recorded >> > anything we'd like to fix in staging/android/TODO, and Laura's patch >> > series here addresses a big chunk of that. >> >> > This is pretty much the same approach we (gpu folks) used to de-stage the >> > syncpt stuff. >> >> Well, there's also the fact that quite a few people have issues with the >> design (like Laurent). It seems like a lot of them have either got more >> comfortable with it over time, or at least not managed to come up with >> any better ideas in the meantime. > > See the TODO, it has everything a really big group (look at the patch for > the full Cc: list) figured needs to be improved at LPC 2015. We don't just > merge stuff because merging stuff is fun :-) > > Laurent was even in that group ... > -Daniel For me those patches are going in the right direction. I still have few questions: - since alignment management has been remove from ion-core, should it be also removed from ioctl structure ? - can you we ride off ion_handle (at least in userland) and only export a dma-buf descriptor ? In the future how can we add new heaps ? Some platforms have very specific memory allocation requirements (just have a look in the number of gem custom allocator in drm) Do you plan to add heap type/mask for each ? Benjamin > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200]) by kanga.kvack.org (Postfix) with ESMTP id 3B2096B0409 for ; Thu, 9 Mar 2017 05:00:41 -0500 (EST) Received: by mail-qk0-f200.google.com with SMTP id a189so131300045qkc.4 for ; Thu, 09 Mar 2017 02:00:41 -0800 (PST) Received: from mail-qk0-x22a.google.com (mail-qk0-x22a.google.com. [2607:f8b0:400d:c09::22a]) by mx.google.com with ESMTPS id d10si5285507qkj.240.2017.03.09.02.00.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Mar 2017 02:00:40 -0800 (PST) Received: by mail-qk0-x22a.google.com with SMTP id v125so108881386qkh.2 for ; Thu, 09 Mar 2017 02:00:40 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> References: <1488491084-17252-1-git-send-email-labbott@redhat.com> <20170303132949.GC31582@dhcp22.suse.cz> <20170306074258.GA27953@dhcp22.suse.cz> <20170306104041.zghsicrnadoap7lp@phenom.ffwll.local> <20170306105805.jsq44kfxhsvazkm6@sirena.org.uk> <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> From: Benjamin Gaignard Date: Thu, 9 Mar 2017 11:00:39 +0100 Message-ID: Subject: Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Mark Brown , Michal Hocko , Laura Abbott , Sumit Semwal , Riley Andrews , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Rom Lemarchand , devel@driverdev.osuosl.org, Linux Kernel Mailing List , "linaro-mm-sig@lists.linaro.org" , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Brian Starkey , Daniel Vetter , Benjamin Gaignard , linux-mm@kvack.org 2017-03-06 17:04 GMT+01:00 Daniel Vetter : > On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >> >> > No one gave a thing about android in upstream, so Greg KH just dumped it >> > all into staging/android/. We've discussed ION a bunch of times, recorded >> > anything we'd like to fix in staging/android/TODO, and Laura's patch >> > series here addresses a big chunk of that. >> >> > This is pretty much the same approach we (gpu folks) used to de-stage the >> > syncpt stuff. >> >> Well, there's also the fact that quite a few people have issues with the >> design (like Laurent). It seems like a lot of them have either got more >> comfortable with it over time, or at least not managed to come up with >> any better ideas in the meantime. > > See the TODO, it has everything a really big group (look at the patch for > the full Cc: list) figured needs to be improved at LPC 2015. We don't just > merge stuff because merging stuff is fun :-) > > Laurent was even in that group ... > -Daniel For me those patches are going in the right direction. I still have few questions: - since alignment management has been remove from ion-core, should it be also removed from ioctl structure ? - can you we ride off ion_handle (at least in userland) and only export a dma-buf descriptor ? In the future how can we add new heaps ? Some platforms have very specific memory allocation requirements (just have a look in the number of gem custom allocator in drm) Do you plan to add heap type/mask for each ? Benjamin > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: benjamin.gaignard@linaro.org (Benjamin Gaignard) Date: Thu, 9 Mar 2017 11:00:39 +0100 Subject: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging In-Reply-To: <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> References: <1488491084-17252-1-git-send-email-labbott@redhat.com> <20170303132949.GC31582@dhcp22.suse.cz> <20170306074258.GA27953@dhcp22.suse.cz> <20170306104041.zghsicrnadoap7lp@phenom.ffwll.local> <20170306105805.jsq44kfxhsvazkm6@sirena.org.uk> <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2017-03-06 17:04 GMT+01:00 Daniel Vetter : > On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >> >> > No one gave a thing about android in upstream, so Greg KH just dumped it >> > all into staging/android/. We've discussed ION a bunch of times, recorded >> > anything we'd like to fix in staging/android/TODO, and Laura's patch >> > series here addresses a big chunk of that. >> >> > This is pretty much the same approach we (gpu folks) used to de-stage the >> > syncpt stuff. >> >> Well, there's also the fact that quite a few people have issues with the >> design (like Laurent). It seems like a lot of them have either got more >> comfortable with it over time, or at least not managed to come up with >> any better ideas in the meantime. > > See the TODO, it has everything a really big group (look at the patch for > the full Cc: list) figured needs to be improved at LPC 2015. We don't just > merge stuff because merging stuff is fun :-) > > Laurent was even in that group ... > -Daniel For me those patches are going in the right direction. I still have few questions: - since alignment management has been remove from ion-core, should it be also removed from ioctl structure ? - can you we ride off ion_handle (at least in userland) and only export a dma-buf descriptor ? In the future how can we add new heaps ? Some platforms have very specific memory allocation requirements (just have a look in the number of gem custom allocator in drm) Do you plan to add heap type/mask for each ? Benjamin > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Gaignard Subject: Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Date: Thu, 9 Mar 2017 11:00:39 +0100 Message-ID: References: <1488491084-17252-1-git-send-email-labbott@redhat.com> <20170303132949.GC31582@dhcp22.suse.cz> <20170306074258.GA27953@dhcp22.suse.cz> <20170306104041.zghsicrnadoap7lp@phenom.ffwll.local> <20170306105805.jsq44kfxhsvazkm6@sirena.org.uk> <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-x22b.google.com (mail-qk0-x22b.google.com [IPv6:2607:f8b0:400d:c09::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB9BF6EB95 for ; Thu, 9 Mar 2017 10:00:40 +0000 (UTC) Received: by mail-qk0-x22b.google.com with SMTP id y76so111032788qkb.0 for ; Thu, 09 Mar 2017 02:00:40 -0800 (PST) In-Reply-To: <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Brown , Michal Hocko , Laura Abbott , Sumit Semwal , Riley Andrews , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Rom Lemarchand , devel@driverdev.osuosl.org, Linux Kernel Mailing List , "linaro-mm-sig@lists.linaro.org" , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Brian Starkey , Daniel Vetter , Benjamin Gaignard , linux-mm@kvack.org List-Id: dri-devel@lists.freedesktop.org MjAxNy0wMy0wNiAxNzowNCBHTVQrMDE6MDAgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNo PjoKPiBPbiBNb24sIE1hciAwNiwgMjAxNyBhdCAxMTo1ODowNUFNICswMTAwLCBNYXJrIEJyb3du IHdyb3RlOgo+PiBPbiBNb24sIE1hciAwNiwgMjAxNyBhdCAxMTo0MDo0MUFNICswMTAwLCBEYW5p ZWwgVmV0dGVyIHdyb3RlOgo+Pgo+PiA+IE5vIG9uZSBnYXZlIGEgdGhpbmcgYWJvdXQgYW5kcm9p ZCBpbiB1cHN0cmVhbSwgc28gR3JlZyBLSCBqdXN0IGR1bXBlZCBpdAo+PiA+IGFsbCBpbnRvIHN0 YWdpbmcvYW5kcm9pZC8uIFdlJ3ZlIGRpc2N1c3NlZCBJT04gYSBidW5jaCBvZiB0aW1lcywgcmVj b3JkZWQKPj4gPiBhbnl0aGluZyB3ZSdkIGxpa2UgdG8gZml4IGluIHN0YWdpbmcvYW5kcm9pZC9U T0RPLCBhbmQgTGF1cmEncyBwYXRjaAo+PiA+IHNlcmllcyBoZXJlIGFkZHJlc3NlcyBhIGJpZyBj aHVuayBvZiB0aGF0Lgo+Pgo+PiA+IFRoaXMgaXMgcHJldHR5IG11Y2ggdGhlIHNhbWUgYXBwcm9h Y2ggd2UgKGdwdSBmb2xrcykgdXNlZCB0byBkZS1zdGFnZSB0aGUKPj4gPiBzeW5jcHQgc3R1ZmYu Cj4+Cj4+IFdlbGwsIHRoZXJlJ3MgYWxzbyB0aGUgZmFjdCB0aGF0IHF1aXRlIGEgZmV3IHBlb3Bs ZSBoYXZlIGlzc3VlcyB3aXRoIHRoZQo+PiBkZXNpZ24gKGxpa2UgTGF1cmVudCkuICBJdCBzZWVt cyBsaWtlIGEgbG90IG9mIHRoZW0gaGF2ZSBlaXRoZXIgZ290IG1vcmUKPj4gY29tZm9ydGFibGUg d2l0aCBpdCBvdmVyIHRpbWUsIG9yIGF0IGxlYXN0IG5vdCBtYW5hZ2VkIHRvIGNvbWUgdXAgd2l0 aAo+PiBhbnkgYmV0dGVyIGlkZWFzIGluIHRoZSBtZWFudGltZS4KPgo+IFNlZSB0aGUgVE9ETywg aXQgaGFzIGV2ZXJ5dGhpbmcgYSByZWFsbHkgYmlnIGdyb3VwIChsb29rIGF0IHRoZSBwYXRjaCBm b3IKPiB0aGUgZnVsbCBDYzogbGlzdCkgZmlndXJlZCBuZWVkcyB0byBiZSBpbXByb3ZlZCBhdCBM UEMgMjAxNS4gV2UgZG9uJ3QganVzdAo+IG1lcmdlIHN0dWZmIGJlY2F1c2UgbWVyZ2luZyBzdHVm ZiBpcyBmdW4gOi0pCj4KPiBMYXVyZW50IHdhcyBldmVuIGluIHRoYXQgZ3JvdXAgLi4uCj4gLURh bmllbAoKRm9yIG1lIHRob3NlIHBhdGNoZXMgYXJlIGdvaW5nIGluIHRoZSByaWdodCBkaXJlY3Rp b24uCgpJIHN0aWxsIGhhdmUgZmV3IHF1ZXN0aW9uczoKLSBzaW5jZSBhbGlnbm1lbnQgbWFuYWdl bWVudCBoYXMgYmVlbiByZW1vdmUgZnJvbSBpb24tY29yZSwgc2hvdWxkIGl0CmJlIGFsc28gcmVt b3ZlZCBmcm9tIGlvY3RsIHN0cnVjdHVyZSA/Ci0gY2FuIHlvdSB3ZSByaWRlIG9mZiBpb25faGFu ZGxlIChhdCBsZWFzdCBpbiB1c2VybGFuZCkgYW5kIG9ubHkKZXhwb3J0IGEgZG1hLWJ1ZiBkZXNj cmlwdG9yID8KCkluIHRoZSBmdXR1cmUgaG93IGNhbiB3ZSBhZGQgbmV3IGhlYXBzID8KU29tZSBw bGF0Zm9ybXMgaGF2ZSB2ZXJ5IHNwZWNpZmljIG1lbW9yeSBhbGxvY2F0aW9uCnJlcXVpcmVtZW50 cyAoanVzdCBoYXZlIGEgbG9vayBpbiB0aGUgbnVtYmVyIG9mIGdlbSBjdXN0b20gYWxsb2NhdG9y IGluIGRybSkKRG8geW91IHBsYW4gdG8gYWRkIGhlYXAgdHlwZS9tYXNrIGZvciBlYWNoID8KCkJl bmphbWluCgo+IC0tCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgoKRm9sbG93IExpbmFybzogRmFjZWJv b2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK