From: Benjamin Gaignard <benjamin.gaignard@linaro.org> To: Philippe CORNU <philippe.cornu@st.com> Cc: Yannick FERTRE <yannick.fertre@st.com>, Benjamin GAIGNARD <benjamin.gaignard@st.com>, Vincent ABRIOU <vincent.abriou@st.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre TORGUE <alexandre.torgue@st.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2] drm/stm: ltdc: remove clk_round_rate comment Date: Fri, 24 May 2019 10:35:10 +0200 [thread overview] Message-ID: <CA+M3ks77XPTZubS8icLdTF3mpQ3OHsvSqX35hHQik3ygRiGSZg@mail.gmail.com> (raw) In-Reply-To: <317f94d6-846f-92e2-bd0f-b44377ea7845@st.com> Le lun. 13 mai 2019 à 16:46, Philippe CORNU <philippe.cornu@st.com> a écrit : > > Dear Yannick, > > Acked-by: Philippe Cornu <philippe.cornu@st.com> > Applied on drm-misc-next, Benjamin > Thank you, > > Philippe :-) > > On 5/13/19 3:15 PM, Yannick Fertré wrote: > > Clk_round_rate returns rounded clock without changing > > the hardware in any way. > > This function couldn't replace set_rate/get_rate calls. > > Todo comment has been removed & a new log inserted. > > > > Signed-off-by: Yannick Fertré <yannick.fertre@st.com> > > --- > > Changes in v2: > > - Clk_enable & clk_disable are needed for the SOC STM32F7 > > (not for STM32MP1). I return this part of the patch to make sure the > > driver is compatible with all SOC STM32. > > > > drivers/gpu/drm/stm/ltdc.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > > index 97912e2..1104e78 100644 > > --- a/drivers/gpu/drm/stm/ltdc.c > > +++ b/drivers/gpu/drm/stm/ltdc.c > > @@ -507,11 +507,6 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *crtc, > > struct ltdc_device *ldev = crtc_to_ltdc(crtc); > > int rate = mode->clock * 1000; > > > > - /* > > - * TODO clk_round_rate() does not work yet. When ready, it can > > - * be used instead of clk_set_rate() then clk_get_rate(). > > - */ > > - > > clk_disable(ldev->pixel_clk); > > if (clk_set_rate(ldev->pixel_clk, rate) < 0) { > > DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate); > > @@ -521,6 +516,9 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *crtc, > > > > adjusted_mode->clock = clk_get_rate(ldev->pixel_clk) / 1000; > > > > + DRM_DEBUG_DRIVER("requested clock %dkHz, adjusted clock %dkHz\n", > > + mode->clock, adjusted_mode->clock); > > + > > return true; > > } > > > > -- > > 2.7.4 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard@linaro.org> To: Philippe CORNU <philippe.cornu@st.com> Cc: Benjamin GAIGNARD <benjamin.gaignard@st.com>, David Airlie <airlied@linux.ie>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Yannick FERTRE <yannick.fertre@st.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Vincent ABRIOU <vincent.abriou@st.com>, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Alexandre TORGUE <alexandre.torgue@st.com> Subject: Re: [PATCH v2] drm/stm: ltdc: remove clk_round_rate comment Date: Fri, 24 May 2019 10:35:10 +0200 [thread overview] Message-ID: <CA+M3ks77XPTZubS8icLdTF3mpQ3OHsvSqX35hHQik3ygRiGSZg@mail.gmail.com> (raw) In-Reply-To: <317f94d6-846f-92e2-bd0f-b44377ea7845@st.com> Le lun. 13 mai 2019 à 16:46, Philippe CORNU <philippe.cornu@st.com> a écrit : > > Dear Yannick, > > Acked-by: Philippe Cornu <philippe.cornu@st.com> > Applied on drm-misc-next, Benjamin > Thank you, > > Philippe :-) > > On 5/13/19 3:15 PM, Yannick Fertré wrote: > > Clk_round_rate returns rounded clock without changing > > the hardware in any way. > > This function couldn't replace set_rate/get_rate calls. > > Todo comment has been removed & a new log inserted. > > > > Signed-off-by: Yannick Fertré <yannick.fertre@st.com> > > --- > > Changes in v2: > > - Clk_enable & clk_disable are needed for the SOC STM32F7 > > (not for STM32MP1). I return this part of the patch to make sure the > > driver is compatible with all SOC STM32. > > > > drivers/gpu/drm/stm/ltdc.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > > index 97912e2..1104e78 100644 > > --- a/drivers/gpu/drm/stm/ltdc.c > > +++ b/drivers/gpu/drm/stm/ltdc.c > > @@ -507,11 +507,6 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *crtc, > > struct ltdc_device *ldev = crtc_to_ltdc(crtc); > > int rate = mode->clock * 1000; > > > > - /* > > - * TODO clk_round_rate() does not work yet. When ready, it can > > - * be used instead of clk_set_rate() then clk_get_rate(). > > - */ > > - > > clk_disable(ldev->pixel_clk); > > if (clk_set_rate(ldev->pixel_clk, rate) < 0) { > > DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate); > > @@ -521,6 +516,9 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *crtc, > > > > adjusted_mode->clock = clk_get_rate(ldev->pixel_clk) / 1000; > > > > + DRM_DEBUG_DRIVER("requested clock %dkHz, adjusted clock %dkHz\n", > > + mode->clock, adjusted_mode->clock); > > + > > return true; > > } > > > > -- > > 2.7.4 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-24 8:35 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-13 13:15 [PATCH v2] drm/stm: ltdc: remove clk_round_rate comment Yannick Fertré 2019-05-13 13:15 ` Yannick Fertré 2019-05-13 13:15 ` Yannick Fertré 2019-05-13 14:45 ` Philippe CORNU 2019-05-13 14:45 ` Philippe CORNU 2019-05-13 14:45 ` Philippe CORNU 2019-05-24 8:35 ` Benjamin Gaignard [this message] 2019-05-24 8:35 ` Benjamin Gaignard 2019-05-24 8:35 ` Benjamin Gaignard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+M3ks77XPTZubS8icLdTF3mpQ3OHsvSqX35hHQik3ygRiGSZg@mail.gmail.com \ --to=benjamin.gaignard@linaro.org \ --cc=airlied@linux.ie \ --cc=alexandre.torgue@st.com \ --cc=benjamin.gaignard@st.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=philippe.cornu@st.com \ --cc=vincent.abriou@st.com \ --cc=yannick.fertre@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.