From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sat, 8 Sep 2012 19:14:22 -0700 Subject: [U-Boot] [PATCH v3 5/6] da850/omap-l138: davinci_emac: Suppress auto negotiation if needed In-Reply-To: References: <1346538565-1821-1-git-send-email-agust@denx.de> <1346911659-3080-5-git-send-email-Bastian.Ruppert@Sewerin.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Sep 7, 2012 at 1:08 AM, Prabhakar Lad wrote: > Hi Bastian, > > Thanks for the patch. > > On Thu, Sep 6, 2012 at 11:37 AM, Bastian Ruppert > wrote: >> From this commit id: b78375a806ed04eb22b963255cfdef8df702de47 auto >> negotiation is enabled in RMII mode. Some boards based on da850 need >> to suppress this procedure. >> >> CC: Rajashekhara, Sudhakar >> CC: Lad, Prabhakar >> CC: Hadli, Manjunath >> CC: sbabic at denx.de >> Acked-by: Stefano Babic >> CC: Tom Rini >> Signed-off-by: Bastian Ruppert >> --- >> drivers/net/davinci_emac.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c >> index b2516d1..fe988d7 100644 >> --- a/drivers/net/davinci_emac.c >> +++ b/drivers/net/davinci_emac.c >> @@ -897,7 +897,8 @@ int davinci_emac_initialize(void) >> } >> >> #if defined(CONFIG_DRIVER_TI_EMAC_USE_RMII) && \ >> - defined(CONFIG_MACH_DAVINCI_DA850_EVM) >> + defined(CONFIG_MACH_DAVINCI_DA850_EVM) && \ >> + !defined(CONFIG_DRIVER_TI_EMAC_RMII_NONEG) > instead of CONFIG_DRIVER_TI_EMAC_RMII_NONEG why not have > CONFIG_DRIVER_TI_EMAC_RMII_AUTO_NEGOTIATE ? Good idea, opt-in is better than opt-out, please make it so. -- Tom