[U-Boot] [PATCH 2/9] OMAP3: DIG297: Use generic MMC driver

[Tom Rini <tom.rini@gmail.com>]

On Wed, Aug 24, 2011 at 6:43 AM, Luca Ceresoli <luca.ceresoli@comelit.it> wrote:
> Tom Rini wrote:
>> Switch from the legacy omap3 mmc driver to the new generic omap hsmmc
>> driver. ?This patch is based on the work done for Beagle, etc.
>>
>> Signed-off-by: Tom Rini<trini@ti.com>
>
> Again, please Cc: the board maintainers in the future, thanks.

Oh, sorry, used to other lists where people complain about too many CCs.

[snip]
>> diff --git a/include/configs/dig297.h b/include/configs/dig297.h
>> index b68f073..0e05df3 100644
>> --- a/include/configs/dig297.h
>> +++ b/include/configs/dig297.h
>> @@ -97,8 +97,9 @@
>> ? #define CONFIG_BAUDRATE ? ? ? ? ? ? ? ? ? ? 115200
>> ? #define CONFIG_SYS_BAUDRATE_TABLE ? {4800, 9600, 19200, 38400, 57600,\
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? 115200}
>> -#define CONFIG_MMC
>> -#define CONFIG_OMAP3_MMC
>> +#define CONFIG_GENERIC_MMC ? ? ? ? ? 1
>> +#define CONFIG_MMC ? ? ? ? ? ? ? ? ? 1
>> +#define CONFIG_OMAP_HSMMC ? ? ? ? ? ?1
>
> IIRC the coding style says you should define the y/n constants without
> a value, e.g.:
> ? #define CONFIG_GENERIC_MMC
> not:
> ? #define CONFIG_GENERIC_MMC 1
>
> Apart for this:
> Tested-by: Luca Ceresoli <luca.ceresoli@comelit.it>

OK, thanks, I'll respin this patch (all of the other boards were doing
the define CONFIG_FOO 1 everywhere) shortly.

-- 
Tom