From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 10 Jan 2012 07:53:40 -0700 Subject: [U-Boot] [PATCH 13/15] New board support: Nokia RX-51 aka N900 In-Reply-To: <1371135.5S9UhYtKBZ@pali-elitebook> References: <1778406.ezGto4lKnu@pali-elitebook> <1324244051-25756-13-git-send-email-pali.rohar@gmail.com> <1371135.5S9UhYtKBZ@pali-elitebook> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jan 10, 2012 at 6:14 AM, Pali Roh?r wrote: > On Tuesday 03 January 2012 09:05:17 Tom Rini wrote: >> On Sun, Dec 18, 2011 at 2:34 PM, Pali Roh?r wrote: >> > This board definition results in a u-boot.bin which can be chainloaded >> > from NOLO in qemu or on a real N900. It does very little hardware config >> > because NOLO has already configured the board. Only needed is enabling >> > internal eMMC memory via twl4030 regulator which is not enabled by NOLO. [snip] >> [snip] >> >> > +/* >> > + * High Level Configuration Options >> > + */ >> > + >> > +#define CONFIG_ARMV7 ? ? ? ? ? ? ? ? ? /* This is an ARM V7 CPU core */ >> >> This isn't used. >> >> > +#define CONFIG_L2_OFF ? ? ? ? ? ? ? ? ?/* kernel won't boot if l2 enabled >> > */ >> This isn't correct for disabling L2 now and doesn't do anything. ?So >> L2 is probably enabled :) > > and #define CONFIG_SYS_L2CACHE_OFF is correct? Yes. [snip] >> > +/*----------------------------------------------------------------------- >> > + * Physical Memory Map >> > + */ >> > +#define CONFIG_NR_DRAM_BANKS ? ? ? ? ? 2 /* CS1 may or may not be >> > populated */ +#define PHYS_SDRAM_1 ? ? ? ? ? ? ? ? ? OMAP34XX_SDRC_CS0 >> > +#define PHYS_SDRAM_2 ? ? ? ? ? ? ? ? ? OMAP34XX_SDRC_CS1 >> > + >> > +/* SDRAM Bank Allocation method */ >> > +#define SDRC_R_B_C ? ? ? ? ? ? ? ? ? ? 1 >> >> And I'm not sure if any of these are really needed now. >> > > When I deleted this code, I cannot compile U-Boot. Here is error message: > include/asm/u-boot.h:48:17: error: ?CONFIG_NR_DRAM_BANKS? undeclared here (not > in a function) I just meant the SDRC_R_B_C part, sorry. -- Tom