All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.keller@gmail.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] Remove --no-gui option from difftool usage string
Date: Fri, 3 Feb 2017 21:58:09 -0800	[thread overview]
Message-ID: <CA+P7+xoXWP=Cuqw3Pa1sFCChiw6wbNTEpvNm3WDuBHQPc_OjnA@mail.gmail.com> (raw)
In-Reply-To: <20170204025617.GA9221@arch-attack.localdomain>

On Fri, Feb 3, 2017 at 6:56 PM, Denton Liu <liu.denton@gmail.com> wrote:
> The --no-gui option not documented in the manpage, nor is it actually
> used in the source code. This change removes it from the usage help
> that's printed.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
>  git-difftool.perl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/git-difftool.perl b/git-difftool.perl
> index a5790d03a..657d5622d 100755
> --- a/git-difftool.perl
> +++ b/git-difftool.perl
> @@ -29,8 +29,8 @@ sub usage
>         print << 'USAGE';
>  usage: git difftool [-t|--tool=<tool>] [--tool-help]
>                      [-x|--extcmd=<cmd>]
> -                    [-g|--gui] [--no-gui]
> -                    [--prompt] [-y|--no-prompt]
> +                    [-g|--gui] [--prompt]
> +                    [-y|--no-prompt]
>                      [-d|--dir-diff]
>                      ['git diff' options]
>  USAGE
> --
> 2.11.0
>

Aren't "--no-foo" options automatically created for booleans when
using our option parsing code?

Thanks,
Jake

  reply	other threads:[~2017-02-04  5:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-04  2:56 [PATCH] Remove --no-gui option from difftool usage string Denton Liu
2017-02-04  5:58 ` Jacob Keller [this message]
2017-02-04  6:23   ` Denton Liu
2017-02-05 10:22     ` David Aguilar
2017-02-05 20:17 ` [BUG] was: " David Aguilar
2017-02-05 21:23   ` [PATCH] difftool: fix bug when printing usage David Aguilar
2017-02-06 16:58     ` Johannes Schindelin
2017-02-06 18:13       ` Junio C Hamano
2017-02-07 11:21         ` Johannes Schindelin
2017-02-07 20:03           ` Junio C Hamano
2017-02-07 20:06             ` Junio C Hamano
2017-02-08 15:06               ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+P7+xoXWP=Cuqw3Pa1sFCChiw6wbNTEpvNm3WDuBHQPc_OjnA@mail.gmail.com' \
    --to=jacob.keller@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.