From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A8CDC433DF for ; Wed, 19 Aug 2020 15:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D8F020639 for ; Wed, 19 Aug 2020 15:42:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vyFC/q8s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728730AbgHSPmq (ORCPT ); Wed, 19 Aug 2020 11:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728699AbgHSPmj (ORCPT ); Wed, 19 Aug 2020 11:42:39 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 057A6C061757 for ; Wed, 19 Aug 2020 08:42:40 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id a5so25064612ioa.13 for ; Wed, 19 Aug 2020 08:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ueFYm1qfrvuVokkg4cIykC1xT41ucWkogT7CDyG2LEU=; b=vyFC/q8s7Zxi5luvZu57+hMwrLU8LK8+zh8k/3QGJnwNPklGHQVFn2JSh/YLamJcLL dVyeG61lKntoHmN6060nH0IO4HWaUJX0LqqBgWtxW8WyLrtmgssiU5sjKlg4yhOX/q1t fdGs7fiCQ+sU2oEF/hOCkMLAqsZwGnmJHj4OpaUMI9oUOu7iL/SI8A5yu3wC5+GerAdd pl3GHIdx7erT7nBPzRnndZ08iGPoyojlCOo4MiTJ7ZXnz6wULYITEeIaKSor5wagiy/M mgDddCeDdC1Kn1z3f/ICNgJ4KaVFxiCrb1r/cqyLXk1krv+su7Z571TImb/kFrQFwsY7 OjAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ueFYm1qfrvuVokkg4cIykC1xT41ucWkogT7CDyG2LEU=; b=DOIrtS3Udl5DQLlGWNAYf6I1c3DdbaRLJvXle5I/oGp5cSD1c00XkU8lGxHJbOoQV5 cRMotxgPB+JZRyNLiWjkJ2EuLo13ZR//olU4pJfBvaz1mRush1ee19PIqeFiwQwUWV4g W+3DKuyflnqKBQOZEvc2RoFvEeQYAayuGEv1a9xsRR4SaNeDlr0/6EY+zyBBnuZOGVmu O8SlF/gDtcAYvtc3EpjUSCn2/a2kCVXC1Qo/gy3W7Dd1IvJhOT5G4qcymEpbYFWIEIQ3 3Ccu85QUm40OmvHfSGMrZSaQM6IK9yTT8GWWsKGXDat9BZkeLtXj8aoxWbAQ1OFkmRR9 rOtw== X-Gm-Message-State: AOAM533CsWgYxrKWl0Xr2Qjb0BlZvmnP4A/m2zpv9ZdtJxxrLVm0LRa6 jQ1YEHnFtULPX3+jjdce6t1bLGf606TK72S3JKAmdQ== X-Google-Smtp-Source: ABdhPJwRnmRf3OMplQbhMziRPhYyjn2uBddwGEzf/xhJv6+J11j8DMc8iwUkJYiK9rDVOAjuTBdAroFLZAE/nvkCCKE= X-Received: by 2002:a02:a584:: with SMTP id b4mr23503993jam.68.1597851758905; Wed, 19 Aug 2020 08:42:38 -0700 (PDT) MIME-Version: 1.0 References: <1597644455-8216-1-git-send-email-jiaxin.yu@mediatek.com> <1597644455-8216-3-git-send-email-jiaxin.yu@mediatek.com> <20200819103730.GB5441@sirena.org.uk> In-Reply-To: <20200819103730.GB5441@sirena.org.uk> From: Tzung-Bi Shih Date: Wed, 19 Aug 2020 23:42:27 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document To: Mark Brown Cc: Jiaxin Yu , Matthias Brugger , Rob Herring , Takashi Iwai , Linux Kernel Mailing List , ALSA development , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, howie.huang@mediatek.com, eason.yen@mediatek.com, shane.chien@mediatek.com, bicycle.tsai@mediatek.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 6:38 PM Mark Brown wrote: > > On Mon, Aug 17, 2020 at 04:11:03PM +0800, Tzung-Bi Shih wrote: > > I misunderstood. It still needs the compatible string to match the > > corresponding driver. > > No, it doesn't. The MFD should be registering the platform device. I guess I see. It lists the mfd_cell when calling devm_mfd_add_devices() in drivers/mfd/mt6397-core.c. It falls back to use driver name and device name to match. As long as the name provided in mfd_cell matches the platform driver name, it works. But I found struct mfd_cell also contains member .of_compatible. What is the difference if we use compatible string (as is) for this device instead of falling back to use device name to match? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95246C433E1 for ; Wed, 19 Aug 2020 15:43:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A18A20639 for ; Wed, 19 Aug 2020 15:43:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="fRvIlAJ9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="vyFC/q8s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A18A20639 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 841F61831; Wed, 19 Aug 2020 17:42:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 841F61831 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597851820; bh=iyLDMze120Dap9xfbK+vtIun0eQHgAdF9GHOiGij++g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fRvIlAJ9iKf9SJzAdMCIvakLNPjYJ9AUEPGlfZHiiyYkaKp6etb9sGwed/hE51Tlj Em9I5uuDfrb9H/AA1gVF437LPbCCUwX0xg4CFJ1bBrDIveow7A8T7q0iCGp/XVNbDQ maUCdcrSHvjL0jX2lhnjck/1evqbBnPHmER9O8Tw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1950AF80216; Wed, 19 Aug 2020 17:42:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8753CF80218; Wed, 19 Aug 2020 17:42:48 +0200 (CEST) Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3CC02F800D3 for ; Wed, 19 Aug 2020 17:42:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3CC02F800D3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vyFC/q8s" Received: by mail-io1-xd42.google.com with SMTP id u126so25064909iod.12 for ; Wed, 19 Aug 2020 08:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ueFYm1qfrvuVokkg4cIykC1xT41ucWkogT7CDyG2LEU=; b=vyFC/q8s7Zxi5luvZu57+hMwrLU8LK8+zh8k/3QGJnwNPklGHQVFn2JSh/YLamJcLL dVyeG61lKntoHmN6060nH0IO4HWaUJX0LqqBgWtxW8WyLrtmgssiU5sjKlg4yhOX/q1t fdGs7fiCQ+sU2oEF/hOCkMLAqsZwGnmJHj4OpaUMI9oUOu7iL/SI8A5yu3wC5+GerAdd pl3GHIdx7erT7nBPzRnndZ08iGPoyojlCOo4MiTJ7ZXnz6wULYITEeIaKSor5wagiy/M mgDddCeDdC1Kn1z3f/ICNgJ4KaVFxiCrb1r/cqyLXk1krv+su7Z571TImb/kFrQFwsY7 OjAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ueFYm1qfrvuVokkg4cIykC1xT41ucWkogT7CDyG2LEU=; b=rtVS8yKq/GjXERdel4JYr26dcfYtZS4szLKRfUzj6uB2QtiT+voqZtOZ1q0ijqyTlc YCGjT6MI/jAS3bg5cgtp48GT5AKWcanZuCWXhS0krKC3Vb7iXXWCuQrxaY7GVilNjQNW pJmuyJHvJEkuI5ML5uaT7gN+wzbvepTL8CeU2VhLudLJgKqPVUgvWDkSk7nhPMenxEqq 3Zrmv3A4Zr8oy0+4EX0xji9yMFlo1OvK5WhkHPJQ3/nNTHO6fRGYKbPd+ypDoaSiGDOS F+T0eWbv6yBXbDqqI/CYWtsunsp6B0gdilH3wfrZxr6H9xV2wJE9jICH9rqczl81QE/Y VGoA== X-Gm-Message-State: AOAM530f6CT3UVjHaH2dLXIQBfUW3b4SWnrXs+7iKzlcRELUIa7exDM8 noqJgiWrlq+DjDjnoeO19+8VGKefAVdw+i8Blq2lkA== X-Google-Smtp-Source: ABdhPJwRnmRf3OMplQbhMziRPhYyjn2uBddwGEzf/xhJv6+J11j8DMc8iwUkJYiK9rDVOAjuTBdAroFLZAE/nvkCCKE= X-Received: by 2002:a02:a584:: with SMTP id b4mr23503993jam.68.1597851758905; Wed, 19 Aug 2020 08:42:38 -0700 (PDT) MIME-Version: 1.0 References: <1597644455-8216-1-git-send-email-jiaxin.yu@mediatek.com> <1597644455-8216-3-git-send-email-jiaxin.yu@mediatek.com> <20200819103730.GB5441@sirena.org.uk> In-Reply-To: <20200819103730.GB5441@sirena.org.uk> From: Tzung-Bi Shih Date: Wed, 19 Aug 2020 23:42:27 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document To: Mark Brown Content-Type: text/plain; charset="UTF-8" Cc: ALSA development , howie.huang@mediatek.com, Takashi Iwai , Jiaxin Yu , Linux Kernel Mailing List , shane.chien@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, eason.yen@mediatek.com, Matthias Brugger , bicycle.tsai@mediatek.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Aug 19, 2020 at 6:38 PM Mark Brown wrote: > > On Mon, Aug 17, 2020 at 04:11:03PM +0800, Tzung-Bi Shih wrote: > > I misunderstood. It still needs the compatible string to match the > > corresponding driver. > > No, it doesn't. The MFD should be registering the platform device. I guess I see. It lists the mfd_cell when calling devm_mfd_add_devices() in drivers/mfd/mt6397-core.c. It falls back to use driver name and device name to match. As long as the name provided in mfd_cell matches the platform driver name, it works. But I found struct mfd_cell also contains member .of_compatible. What is the difference if we use compatible string (as is) for this device instead of falling back to use device name to match? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FFDC433E1 for ; Wed, 19 Aug 2020 15:42:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0DF320639 for ; Wed, 19 Aug 2020 15:42:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gNhtpKWC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="vyFC/q8s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0DF320639 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MMaE8VpI7pv8meWBnrtg5551cV8UItkZ3xfpXuqL6VM=; b=gNhtpKWCtYpDAdYR/B3hKJqPi bLumCbl5lYIVqC3mnN+KxvfUWbULlR9MkECOAaMVaG19Msbvp9KOyFlhUg9k2I+r2b9qTnEyu+tMP 0Q/mYbhdZlVNWOHPn5Li4v+lv9XET+q0Yp+5zyr7acKYv6DiKu3e5SklrDtpuHRm2RwaQjNtHWijg i6ljYamJgfhobkMByMUxLemSJQ7KkPz0t4VD8JNctZ++alpieGsmrXiOEAyRd1bo5bSZ4m/OGaFJm CqZxtrFQCWplyveVJtSRY1AhKoi/cbjiC7cT49B6WiOTuJdLUbNjAI7gwfCC5UtMTbqsfFM1aRbCR wsy1mSKuA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8QEf-0008Hx-TY; Wed, 19 Aug 2020 15:42:45 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8QEc-0008GB-Re for linux-mediatek@lists.infradead.org; Wed, 19 Aug 2020 15:42:44 +0000 Received: by mail-io1-xd42.google.com with SMTP id s189so25210706iod.2 for ; Wed, 19 Aug 2020 08:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ueFYm1qfrvuVokkg4cIykC1xT41ucWkogT7CDyG2LEU=; b=vyFC/q8s7Zxi5luvZu57+hMwrLU8LK8+zh8k/3QGJnwNPklGHQVFn2JSh/YLamJcLL dVyeG61lKntoHmN6060nH0IO4HWaUJX0LqqBgWtxW8WyLrtmgssiU5sjKlg4yhOX/q1t fdGs7fiCQ+sU2oEF/hOCkMLAqsZwGnmJHj4OpaUMI9oUOu7iL/SI8A5yu3wC5+GerAdd pl3GHIdx7erT7nBPzRnndZ08iGPoyojlCOo4MiTJ7ZXnz6wULYITEeIaKSor5wagiy/M mgDddCeDdC1Kn1z3f/ICNgJ4KaVFxiCrb1r/cqyLXk1krv+su7Z571TImb/kFrQFwsY7 OjAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ueFYm1qfrvuVokkg4cIykC1xT41ucWkogT7CDyG2LEU=; b=kvQQXoQ9DQGILyi3dtDB21Yf5A0Morn4cPRm25L0b/7MUZkxBzsQiWwCKODuKaAGgU g61SIROd1DP3MznqQO0Q4D7OGf8wRSmYlId3K7RhneccblzQTb/7Wf2e1AtKDX9vNgM0 qdYAkKm8fMj4mWYzeEPSCqysa4N+Z+WM2VFfdlBbzxh2w8CYQKVQiNrYsboSh9Z01sKf /a8Cun41/ZujLsorWzX4S8jHVs3Yz8EmOwvFb8WJcFQUBX1BfbR3Ah/++Is7J18/LsCL hfF/zqc4+h8uI6np+gmr/O16ZaIbyEM72TU4Ys4kvZwNR0kEliNDTvsLyaWizd+N2XPJ yr1w== X-Gm-Message-State: AOAM530B7eHvu1xHMIoSptJAk72QHSqscQd0Sw8L1/FAmw6OxEy5GFK2 Sl644eTu9zSjrkwWL1tFUGG55CX3C7LU92f1E7VVvg== X-Google-Smtp-Source: ABdhPJwRnmRf3OMplQbhMziRPhYyjn2uBddwGEzf/xhJv6+J11j8DMc8iwUkJYiK9rDVOAjuTBdAroFLZAE/nvkCCKE= X-Received: by 2002:a02:a584:: with SMTP id b4mr23503993jam.68.1597851758905; Wed, 19 Aug 2020 08:42:38 -0700 (PDT) MIME-Version: 1.0 References: <1597644455-8216-1-git-send-email-jiaxin.yu@mediatek.com> <1597644455-8216-3-git-send-email-jiaxin.yu@mediatek.com> <20200819103730.GB5441@sirena.org.uk> In-Reply-To: <20200819103730.GB5441@sirena.org.uk> From: Tzung-Bi Shih Date: Wed, 19 Aug 2020 23:42:27 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document To: Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_114242_993019_91847B9E X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA development , howie.huang@mediatek.com, Takashi Iwai , Jiaxin Yu , Linux Kernel Mailing List , shane.chien@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, eason.yen@mediatek.com, Matthias Brugger , bicycle.tsai@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Aug 19, 2020 at 6:38 PM Mark Brown wrote: > > On Mon, Aug 17, 2020 at 04:11:03PM +0800, Tzung-Bi Shih wrote: > > I misunderstood. It still needs the compatible string to match the > > corresponding driver. > > No, it doesn't. The MFD should be registering the platform device. I guess I see. It lists the mfd_cell when calling devm_mfd_add_devices() in drivers/mfd/mt6397-core.c. It falls back to use driver name and device name to match. As long as the name provided in mfd_cell matches the platform driver name, it works. But I found struct mfd_cell also contains member .of_compatible. What is the difference if we use compatible string (as is) for this device instead of falling back to use device name to match? _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B960DC433DF for ; Wed, 19 Aug 2020 15:43:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86A6820639 for ; Wed, 19 Aug 2020 15:43:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wcgFseZv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="vyFC/q8s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86A6820639 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E005/pqbcerGoF7LfErmOYLaieOBpGAVFTFucfH00u0=; b=wcgFseZvT5QglZS5OnL/k6AwT GnIkXCIYZ5VeMKwhSJ4kffqD0QOHDRglDEX1Vm9TavG0AQuLTwxqn7d/mRNt22rYNGrC4q9HvI2vC dnteN8PgozFW4aCeAq+Ku6BqOp8LqjOn89JhI0hBDVTgDEFBliRrmoWwLKKs+XOZzvtLt4gtbnah2 GHinNf80HgjQ2wb/KyEABf8bSQjwbRSYt6Rqzni5873Iw/yh6YQOoGcXaHt+V76l2VA62SbwYyf9W xFfvm6iPjUUTstzZEYL8MYXptM5U4zTsNXG0RX7fUgNGVx7xqrO6Itlux+ifNhFGgQzu8gTwke0I+ yYgFVOO5w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8QEh-0008IC-4N; Wed, 19 Aug 2020 15:42:47 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8QEc-0008GC-Sz for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 15:42:44 +0000 Received: by mail-io1-xd41.google.com with SMTP id g14so25257413iom.0 for ; Wed, 19 Aug 2020 08:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ueFYm1qfrvuVokkg4cIykC1xT41ucWkogT7CDyG2LEU=; b=vyFC/q8s7Zxi5luvZu57+hMwrLU8LK8+zh8k/3QGJnwNPklGHQVFn2JSh/YLamJcLL dVyeG61lKntoHmN6060nH0IO4HWaUJX0LqqBgWtxW8WyLrtmgssiU5sjKlg4yhOX/q1t fdGs7fiCQ+sU2oEF/hOCkMLAqsZwGnmJHj4OpaUMI9oUOu7iL/SI8A5yu3wC5+GerAdd pl3GHIdx7erT7nBPzRnndZ08iGPoyojlCOo4MiTJ7ZXnz6wULYITEeIaKSor5wagiy/M mgDddCeDdC1Kn1z3f/ICNgJ4KaVFxiCrb1r/cqyLXk1krv+su7Z571TImb/kFrQFwsY7 OjAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ueFYm1qfrvuVokkg4cIykC1xT41ucWkogT7CDyG2LEU=; b=ucqSzrNJp7O9+ujkmcUL3wUgZU0gkNnLVI9gbvZ10piKbAK6ohNr9uNqzNppx26v9S KuHm7lDil5TK08V5dUomETq6T/J42VCNNS1mndcyhzbv/xLpj8j2SUi3f0HPt7T8gzy3 6mZpoPvjGchz86+S1XFtg+1Cc1302minX8VGSE05wTGIiOougzT7+a6vVD8EWnW4M5yZ uAADHjmYnhaGzvr0oNTFcH85+z02BkGz4f9RZ29nsl/Q5b0dyxjzj/T22vaF0QjHYItK JMUfomDiHRQSrtrog5JDZuvvgY2xOkzPAPKZR/XLaLr5z73bGJ/YchcmiXlFAvuwnpDt WAfA== X-Gm-Message-State: AOAM5319qKlx/zAMv0TkL79XRlpkCWfMmN7xI1wYYLa16qwcCewBmrM6 GpCjED3FbtjUjweMWZd6l2IQvXPFKp7Xfhj750wyDw== X-Google-Smtp-Source: ABdhPJwRnmRf3OMplQbhMziRPhYyjn2uBddwGEzf/xhJv6+J11j8DMc8iwUkJYiK9rDVOAjuTBdAroFLZAE/nvkCCKE= X-Received: by 2002:a02:a584:: with SMTP id b4mr23503993jam.68.1597851758905; Wed, 19 Aug 2020 08:42:38 -0700 (PDT) MIME-Version: 1.0 References: <1597644455-8216-1-git-send-email-jiaxin.yu@mediatek.com> <1597644455-8216-3-git-send-email-jiaxin.yu@mediatek.com> <20200819103730.GB5441@sirena.org.uk> In-Reply-To: <20200819103730.GB5441@sirena.org.uk> From: Tzung-Bi Shih Date: Wed, 19 Aug 2020 23:42:27 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document To: Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_114243_022306_3E9B4FD4 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA development , howie.huang@mediatek.com, Takashi Iwai , Jiaxin Yu , Linux Kernel Mailing List , shane.chien@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, eason.yen@mediatek.com, Matthias Brugger , bicycle.tsai@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 19, 2020 at 6:38 PM Mark Brown wrote: > > On Mon, Aug 17, 2020 at 04:11:03PM +0800, Tzung-Bi Shih wrote: > > I misunderstood. It still needs the compatible string to match the > > corresponding driver. > > No, it doesn't. The MFD should be registering the platform device. I guess I see. It lists the mfd_cell when calling devm_mfd_add_devices() in drivers/mfd/mt6397-core.c. It falls back to use driver name and device name to match. As long as the name provided in mfd_cell matches the platform driver name, it works. But I found struct mfd_cell also contains member .of_compatible. What is the difference if we use compatible string (as is) for this device instead of falling back to use device name to match? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel