From: Tzung-Bi Shih <tzungbi@google.com>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Dylan Reid <dgreid@google.com>,
Jimmy Cheng-Yi Chiang <cychiang@google.com>
Subject: Re: [alsa-devel] [RESEND PATCH 4/4] ASoC: mediatek: mt8183-da7219: apply some refactors
Date: Thu, 13 Feb 2020 21:42:47 +0800 [thread overview]
Message-ID: <CA+Px+wUkmUZ=boWtXoNQfe+7ieGdwXCvsfL=tXHQTQ=otO6h=Q@mail.gmail.com> (raw)
In-Reply-To: <20200213122708.GE4333@sirena.org.uk>
On Thu, Feb 13, 2020 at 8:27 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Feb 13, 2020 at 11:27:28AM +0800, Tzung-Bi Shih wrote:
> > 1. Moves headset jack to card-specific storage.
> > 2. Removes trailing blank line.
> > 3. Moves card registration to the end of probe.
>
> I'll apply this but it feels like it should be at least two patches - if
> you're writing a changelog with numbered changes like this it's a big
> warning sign.
I see. Will pay more attention and won't squash small changes next time.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2020-02-13 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 3:27 [alsa-devel] [RESEND PATCH 0/4] ASoC: mediatek: mt8183-da7219: pick fixes from mt8183-mt6358 Tzung-Bi Shih
2020-02-13 3:27 ` [alsa-devel] [RESEND PATCH 1/4] ASoC: mediatek: mt8183-da7219: change supported formats of DL2 and UL1 Tzung-Bi Shih
2020-02-13 3:27 ` [alsa-devel] [RESEND PATCH 2/4] ASoC: mediatek: mt8183-da7219: pull TDM GPIO pins down when probed Tzung-Bi Shih
2020-02-13 12:24 ` Mark Brown
2020-02-13 13:42 ` Tzung-Bi Shih
2020-02-13 13:49 ` Mark Brown
2020-02-13 3:27 ` [alsa-devel] [RESEND PATCH 3/4] ASoC: mediatek: mt8183-da7219: support TDM out and 8ch I2S out Tzung-Bi Shih
2020-02-13 3:27 ` [alsa-devel] [RESEND PATCH 4/4] ASoC: mediatek: mt8183-da7219: apply some refactors Tzung-Bi Shih
2020-02-13 12:27 ` Mark Brown
2020-02-13 13:42 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Px+wUkmUZ=boWtXoNQfe+7ieGdwXCvsfL=tXHQTQ=otO6h=Q@mail.gmail.com' \
--to=tzungbi@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@google.com \
--cc=dgreid@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.