From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E5C3C43461 for ; Fri, 21 May 2021 08:06:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60D186135B for ; Fri, 21 May 2021 08:06:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232336AbhEUIH2 (ORCPT ); Fri, 21 May 2021 04:07:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbhEUIH1 (ORCPT ); Fri, 21 May 2021 04:07:27 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9D29C061574 for ; Fri, 21 May 2021 01:06:04 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id b25so962036iot.5 for ; Fri, 21 May 2021 01:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nLgutOYMl1GMr2L+DWd3t+nM78vyp11ue7Ti9kGh5WY=; b=RLCkpSbUTDgmL0IUkNKkbmahQomlAqn9LVv4OjtlEGPKEwf/we89iYS8PkEh7NMqj3 IAneffvJZrHAvht8if9QuBmdyHhvk2UDoSq1UvZpkI8SQDeMytix6Oq+ys82P4DA7qNd I3tazjWsnnIEfHimQYEFmcdmjmKEylDeeam+tOPNbq6OKawmBRtMkgc4/ai1bAA9Gmus Xe8Uj8dpmbD22hxVasY9Z+UH9ixx3pb0kr09WVsc5qI3+fYKN7JLXHncK4ZnUgmOonEb bWzKeZtQtZncb4z1KUPGbi/0rpc1JLKRSYLFNhFoV/XFQtYRwHp66ut8KjOGy/mVAgQk qJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nLgutOYMl1GMr2L+DWd3t+nM78vyp11ue7Ti9kGh5WY=; b=SGzV6z95STJO2LqkAc/jGqoWh6p/KLBN30iySsGvPh1SXUovBgJ/7T9nKBwtjOV/kp AIb6aJzB+xMTaLR8ucQtCbwZy0/HV2aj6nQxvfZf1yqby1SoSBhWjPgZcRAO7uSA+6h1 0OS/0+sk+QDk5Pv8tF2Vvh+7XzJFzKggPwI/bbq6EiSgiaThbNDT6OsJPAcyWUqu0m1g fAKQK8Gkj2BLgs8cy2L1Ka5TIisIHDtA0R7AfwmpLbkEJFH/ZE+iodbRhbgxux3OcXgN sMpGOyLaLdYFZiLsDMssIJR8BOoaR6GvgHWBqQfiBAZzIDCcs2woq1Wvp9a0rYVQmrdM Q6+A== X-Gm-Message-State: AOAM530Ils3B6/Hy8tk8KZ4PrYSjhooGyJoT4IDO+HABE5AYruHVP+ca OliwPZyl+7CW6inYgra8Xjp/hUbm5tT7E2qXvu9c7Q== X-Google-Smtp-Source: ABdhPJw8QQBmq3fEOwfOK/ErgYCCLNXidUnXXUKXQuBmy4OkSx4beXK+d27kBMvufIEEpLJJ2b2A29KuaUHg7Fqdpzg= X-Received: by 2002:a6b:e00a:: with SMTP id z10mr10832250iog.109.1621584363791; Fri, 21 May 2021 01:06:03 -0700 (PDT) MIME-Version: 1.0 References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-2-irui.wang@mediatek.com> In-Reply-To: <20210521070139.20644-2-irui.wang@mediatek.com> From: Tzung-Bi Shih Date: Fri, 21 May 2021 16:05:52 +0800 Message-ID: Subject: Re: [PATCH v4,1/6] media: mtk-vcodec: venc: remove redundant code To: Irui Wang Cc: Alexandre Courbot , Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yong Wu , Yunfei Dong , Fritz Koenig , Tzung-Bi Shih , linux-media@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , srv_heupstream@mediatek.com, "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 3:02 PM Irui Wang wrote: > > From: Alexandre Courbot > > vidioc_try_fmt() does clamp height and width when called on the OUTPUT > queue, so clamping them prior to calling this function is redundant. Set > the queue's parameters after calling vidioc_try_fmt() so we can use the > values it computed. > > Signed-off-by: Alexandre Courbot >From the guideline[1]: Notably, the last Signed-off-by: must always be that of the developer submitting the patch You should provide your signed-off. [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3DCC433B4 for ; Fri, 21 May 2021 08:06:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 619D3611AD for ; Fri, 21 May 2021 08:06:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 619D3611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HBYR3iYs8XPynE5lKFPZN/b01suWAkZowj/D2McwJtk=; b=M5P3g2RDxk07lEe6POwC2IN4wQ esk2eiz3OVTjeK+gV2jAfaD/+f+HZ1asnsu8RjgIovLH27tHM/zBECRQtc7CCmbTnPzj3uKhhmImG KJpjpoSwGbqY4UX6QdOTjrjgcMBJGD+vykhmG4ye8BNppBFCPBh604QAZBmRsikOSZdn5pme02TpA lswQlol1FbN35G7V3/DHUICk7KgAnd3EQC7ZOIVVqWVsAVs6QfvSo/6qLEb/qYxCNrEg0TJ0a0r8X u8m9tZByQhhvLvslci3QBwR61YCgecnxsY703xiFjkjmTOlDrp7eAP4l6EjzmU8hmPn6wgJzpGwvG XgNuxgVA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk0Ag-004Mcd-7r; Fri, 21 May 2021 08:06:14 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk0Ab-004May-Dh for linux-mediatek@desiato.infradead.org; Fri, 21 May 2021 08:06:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nLgutOYMl1GMr2L+DWd3t+nM78vyp11ue7Ti9kGh5WY=; b=ve56MKRsmCGvzfQgIi08DkFbnx RL3ryvJ0NKDsqPoc8/oJq15beWb/URYEY1f9xDhtc/vUMgw1YT6Kjb2ht5pwkRHsjsPMSQxXW2z1P C00HLh4o9LNSkVsOl1waU4D7mzeTMfAqaECK8udIub56xhe6/d8+mRCW6aMDW7EHrcgoVLHikzNRl J8E6WIrqccV1KSNmD2OVt30vmagzRAK/iLmOUC7g6gC/IeLy4ku/rr6iHi1hKkSc7ZVWydxVRLQdD qC+ZYpWSXCE8KT6V2fctd6Z4DnXSDolxUBwUwZMi+l7jkFJDhTvDFFCcIzOxdWjU+auyAUiKUJRGx oaCWP34Q==; Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk0AY-00Gvi0-Cw for linux-mediatek@lists.infradead.org; Fri, 21 May 2021 08:06:07 +0000 Received: by mail-io1-xd31.google.com with SMTP id e17so6755484iol.7 for ; Fri, 21 May 2021 01:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nLgutOYMl1GMr2L+DWd3t+nM78vyp11ue7Ti9kGh5WY=; b=RLCkpSbUTDgmL0IUkNKkbmahQomlAqn9LVv4OjtlEGPKEwf/we89iYS8PkEh7NMqj3 IAneffvJZrHAvht8if9QuBmdyHhvk2UDoSq1UvZpkI8SQDeMytix6Oq+ys82P4DA7qNd I3tazjWsnnIEfHimQYEFmcdmjmKEylDeeam+tOPNbq6OKawmBRtMkgc4/ai1bAA9Gmus Xe8Uj8dpmbD22hxVasY9Z+UH9ixx3pb0kr09WVsc5qI3+fYKN7JLXHncK4ZnUgmOonEb bWzKeZtQtZncb4z1KUPGbi/0rpc1JLKRSYLFNhFoV/XFQtYRwHp66ut8KjOGy/mVAgQk qJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nLgutOYMl1GMr2L+DWd3t+nM78vyp11ue7Ti9kGh5WY=; b=qpi7Tn+sU5fi++NPk+u0dVgiCsuUUFCk+c2Uz5uqEoPBO078n7NCYQ0luRFAQ3cdBT VdpTV6J7leQOw9QvZYjYSb/LSucUyhJrbc8hjE8lDuE3M49NGFBwgS3fXEesf1jBWQK4 C+n8afpcvQa3J7efARP/vrjNVCvVz5lLtn7HEVz00eX6Csudr2Hdo4jKiTf1A7f8somZ ZoeT8CauTveh8h/kWJKeA0QKROAQjaEJs/yqtofq5a/YfVCCAwxpxf0AkJjySozhS29S 4n8okuy30sHzUvj3sCNKLFiYj7PC97ekLNnnix0Ce+aSZSf+yoNT+e36vIKZq/hl8+oa aydw== X-Gm-Message-State: AOAM5337sxEgjmc7yUvzTFNBtfAHz+INL4UN8JMvs4fsrYz61R4Mxjl7 GXXg01R1pFbcZpQd6szI/9C/A5FO5CdaQkyiW6WsAw== X-Google-Smtp-Source: ABdhPJw8QQBmq3fEOwfOK/ErgYCCLNXidUnXXUKXQuBmy4OkSx4beXK+d27kBMvufIEEpLJJ2b2A29KuaUHg7Fqdpzg= X-Received: by 2002:a6b:e00a:: with SMTP id z10mr10832250iog.109.1621584363791; Fri, 21 May 2021 01:06:03 -0700 (PDT) MIME-Version: 1.0 References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-2-irui.wang@mediatek.com> In-Reply-To: <20210521070139.20644-2-irui.wang@mediatek.com> From: Tzung-Bi Shih Date: Fri, 21 May 2021 16:05:52 +0800 Message-ID: Subject: Re: [PATCH v4,1/6] media: mtk-vcodec: venc: remove redundant code To: Irui Wang Cc: Alexandre Courbot , Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yong Wu , Yunfei Dong , Fritz Koenig , Tzung-Bi Shih , linux-media@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , srv_heupstream@mediatek.com, "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_010606_445497_ADCE2C9F X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 3:02 PM Irui Wang wrote: > > From: Alexandre Courbot > > vidioc_try_fmt() does clamp height and width when called on the OUTPUT > queue, so clamping them prior to calling this function is redundant. Set > the queue's parameters after calling vidioc_try_fmt() so we can use the > values it computed. > > Signed-off-by: Alexandre Courbot >From the guideline[1]: Notably, the last Signed-off-by: must always be that of the developer submitting the patch You should provide your signed-off. [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95966C433ED for ; Fri, 21 May 2021 08:09:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AC85611AD for ; Fri, 21 May 2021 08:09:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AC85611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y69mqzpOTnxzwEC8+BQBSaDoQnvVh8iWvs9Cfpr5pAg=; b=bVMWSyedaJc74NojSVHE3ZKYOn g082UuuVokSsObjBNNHcPfgizsmHeGF1Zm7+wrjOSBCEk2kCIv7QRxijvBDPi/DCgZrfLN1wxokUI HshetVgdaqgm011H7rHsZ2XDsNL46HLielxyLLVLU0/J1iuEhdAzngpGxJKgRdP1pA4b3d01AtacK dzPGe1QXEs6hST3ENWtYYNif5/GOUfiEcXN3bfhxGBYTea6gZDpENavpysoWDlepXVPj10UoPpW8W AbeaAhewhAXy7cI+48fWHeXz4u+gw4i1xNAqlwLx+kuS5uAzAKJyf1ZGaSFeOaijRZqpHW+pxXLal H0i09xfw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk0Ai-004Mcl-PX; Fri, 21 May 2021 08:06:17 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk0Ab-004Mb0-Dh for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 08:06:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nLgutOYMl1GMr2L+DWd3t+nM78vyp11ue7Ti9kGh5WY=; b=ve56MKRsmCGvzfQgIi08DkFbnx RL3ryvJ0NKDsqPoc8/oJq15beWb/URYEY1f9xDhtc/vUMgw1YT6Kjb2ht5pwkRHsjsPMSQxXW2z1P C00HLh4o9LNSkVsOl1waU4D7mzeTMfAqaECK8udIub56xhe6/d8+mRCW6aMDW7EHrcgoVLHikzNRl J8E6WIrqccV1KSNmD2OVt30vmagzRAK/iLmOUC7g6gC/IeLy4ku/rr6iHi1hKkSc7ZVWydxVRLQdD qC+ZYpWSXCE8KT6V2fctd6Z4DnXSDolxUBwUwZMi+l7jkFJDhTvDFFCcIzOxdWjU+auyAUiKUJRGx oaCWP34Q==; Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk0AY-00Gvhz-D5 for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 08:06:08 +0000 Received: by mail-io1-xd2c.google.com with SMTP id a11so19323318ioo.0 for ; Fri, 21 May 2021 01:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nLgutOYMl1GMr2L+DWd3t+nM78vyp11ue7Ti9kGh5WY=; b=RLCkpSbUTDgmL0IUkNKkbmahQomlAqn9LVv4OjtlEGPKEwf/we89iYS8PkEh7NMqj3 IAneffvJZrHAvht8if9QuBmdyHhvk2UDoSq1UvZpkI8SQDeMytix6Oq+ys82P4DA7qNd I3tazjWsnnIEfHimQYEFmcdmjmKEylDeeam+tOPNbq6OKawmBRtMkgc4/ai1bAA9Gmus Xe8Uj8dpmbD22hxVasY9Z+UH9ixx3pb0kr09WVsc5qI3+fYKN7JLXHncK4ZnUgmOonEb bWzKeZtQtZncb4z1KUPGbi/0rpc1JLKRSYLFNhFoV/XFQtYRwHp66ut8KjOGy/mVAgQk qJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nLgutOYMl1GMr2L+DWd3t+nM78vyp11ue7Ti9kGh5WY=; b=Zmzd0jswZPV3pCswNA/TZWUT1UFqU5Mn8H3RLEipSPehyNBWPbm8j2uYAhVF+dbgwv laXlH8dY0qk8V8LrSheJ5h/ZHeLM8RSqv7OnylUrxDfgh7qJXzQ3bpVGklY6AR4Mis+s 8g8/QbG0YOUyndN8HL96COfLaa6af1krLjr5jLk4LdtZWFzv+bDHOPCaE29aNIetQI94 iWnKKWHD+kSg2BQrvMRvNVIIXiSaKLTrlol07C2SF3jPl+MBi6QF84XMXPNi1u4e73H+ YNCqO5Nbv0sOvu6y74zgwQn2dr1uLqWbqFI8FoBOmNhLFb4Rl2Bu5QrYrfs+nPqzkG/r BApg== X-Gm-Message-State: AOAM533FG12FpodTALHpBCpBpbTYTqBQY2Dy+iEwHCWOSzvDpAUGVgy1 Ca4PGmi5TJ0eZdXsBcOx92Ok+NCqsGqvj52KkTGuHQ== X-Google-Smtp-Source: ABdhPJw8QQBmq3fEOwfOK/ErgYCCLNXidUnXXUKXQuBmy4OkSx4beXK+d27kBMvufIEEpLJJ2b2A29KuaUHg7Fqdpzg= X-Received: by 2002:a6b:e00a:: with SMTP id z10mr10832250iog.109.1621584363791; Fri, 21 May 2021 01:06:03 -0700 (PDT) MIME-Version: 1.0 References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-2-irui.wang@mediatek.com> In-Reply-To: <20210521070139.20644-2-irui.wang@mediatek.com> From: Tzung-Bi Shih Date: Fri, 21 May 2021 16:05:52 +0800 Message-ID: Subject: Re: [PATCH v4,1/6] media: mtk-vcodec: venc: remove redundant code To: Irui Wang Cc: Alexandre Courbot , Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yong Wu , Yunfei Dong , Fritz Koenig , Tzung-Bi Shih , linux-media@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , srv_heupstream@mediatek.com, "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_010606_449058_24559195 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 3:02 PM Irui Wang wrote: > > From: Alexandre Courbot > > vidioc_try_fmt() does clamp height and width when called on the OUTPUT > queue, so clamping them prior to calling this function is redundant. Set > the queue's parameters after calling vidioc_try_fmt() so we can use the > values it computed. > > Signed-off-by: Alexandre Courbot >From the guideline[1]: Notably, the last Signed-off-by: must always be that of the developer submitting the patch You should provide your signed-off. [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel