From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-28.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E89C433B4 for ; Fri, 16 Apr 2021 18:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9088660FD9 for ; Fri, 16 Apr 2021 18:24:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236033AbhDPSYc (ORCPT ); Fri, 16 Apr 2021 14:24:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234312AbhDPSYb (ORCPT ); Fri, 16 Apr 2021 14:24:31 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7380C061756 for ; Fri, 16 Apr 2021 11:24:05 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id 101-20020a9d0d6e0000b02902816815ff62so20659202oti.9 for ; Fri, 16 Apr 2021 11:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc; bh=NGL2DZ81iiy8zZ9X98sR3lExSRtmhzsEE2kmMo2vY6Y=; b=qRxg1AQVpABQRxRIqNU5TKPRxviJzaAJJQvMgYRNOw77gh3Yu7WQSV0s+T33hqXGiZ YBFdsywjmDeOsHpxDxYDsyBhOUeP377VvaPhkfyg1tqcZdAk8HxXX3LG3j/0I+oOX4Yr ggCsVdEKnxJGiqAcoWSC1Eg4vrEBC8ZnMNIH93EITdtCdb3PHD2BnenltnN05fYQ2WMi gm48T9giGwX9vwYFGU0RAs+fLMtWFJ5iGTQJSlvpbPpgFGkXLK1+hmGMSI1W4ilk9T+O 8ruuAxK28VWV0B/hOOHgqrB69eysFrQkUM91ZAAW/yMAz7cEA/VNS3cd9pYTDqiN3rQw S2sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=NGL2DZ81iiy8zZ9X98sR3lExSRtmhzsEE2kmMo2vY6Y=; b=iAqqE4QDEcpSQUNa3O5+lg1/SgrwOLnUsElCcnuskKpOOaDm9x+p/ehG7xt/jbcY8j iYca0qjXQ5Ie3AdxI9Pq+DBgRcKxgUNavOGOvbTbliZqjS6lVGACm6Vqe0srWH9m/LU+ HVIcU4YeodAktQ8O5+E5EvVmRBUpINLVdGlY0K4dJFSvMY3yLaPA2zTI48OfjNml7OuX zX/mhGPJD+icdkkXiNHDzXuYr3dnStxewkhRfQ+h8S3BlWXsMOh5MsaZQVmyhziKqCDq 101vkYxqvM36fa+xPMdSy7MqsKu5BM+pKzQoazIwHh2aF385B9x3nPW5aNJvRQnE6AK6 cTuw== X-Gm-Message-State: AOAM531FE5sRI19mGl5WjzO5lXbVN/mdQJp1hauLzOW/ueGz9+IaKXY7 tC/DwwymivK5tsHLC4h9c2h69annVGNJxPyIADSkrQ== X-Received: by 2002:a05:6830:200e:: with SMTP id e14mt4156138otp.111.1618597444844; Fri, 16 Apr 2021 11:24:04 -0700 (PDT) MIME-Version: 1.0 References: <20210416181421.2374588-1-jiancai@google.com> In-Reply-To: <20210416181421.2374588-1-jiancai@google.com> From: Jian Cai Date: Fri, 16 Apr 2021 11:23:53 -0700 Message-ID: Subject: Re: [PATCH] arm64: vdso: remove commas between macro name and arguments Cc: "# 3.4.x" , Greg KH , Sasha Levin , Nick Desaulniers , Nathan Chancellor , Manoj Gupta , Luis Lozano , clang-built-linux , Catalin Marinas , Will Deacon , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I should've mentioned this patch is for 4.19 only as the code has been rewritten in later versions, but requires a large amount of backports (https://github.com/ClangBuiltLinux/linux/issues/1349). This is the only blocker for 4.19 migration to LLVM's integrated assembler on CrOS that I am aware of. Thanks, Jian On Fri, Apr 16, 2021 at 11:14 AM Jian Cai wrote: > > LLVM's integrated assembler does not support using commas separating > the name and arguments in .macro. However, only spaces are used in the > manual page. This replaces commas between macro names and the subsequent > arguments with space in calls to clock_gettime_return to make it > compatible with IAS. > > Link: > https://sourceware.org/binutils/docs/as/Macro.html#Macro > Signed-off-by: Jian Cai > --- > arch/arm64/kernel/vdso/gettimeofday.S | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kernel/vdso/gettimeofday.S b/arch/arm64/kernel/vdso/gettimeofday.S > index 856fee6d3512..7ee685d9adfc 100644 > --- a/arch/arm64/kernel/vdso/gettimeofday.S > +++ b/arch/arm64/kernel/vdso/gettimeofday.S > @@ -122,7 +122,7 @@ x_tmp .req x8 > 9998: > .endm > > - .macro clock_gettime_return, shift=0 > + .macro clock_gettime_return shift=0 > .if \shift == 1 > lsr x11, x11, x12 > .endif > @@ -227,7 +227,7 @@ realtime: > seqcnt_check fail=realtime > get_ts_realtime res_sec=x10, res_nsec=x11, \ > clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > monotonic: > @@ -250,7 +250,7 @@ monotonic: > clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9 > > add_ts sec=x10, nsec=x11, ts_sec=x3, ts_nsec=x4, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > monotonic_raw: > @@ -271,7 +271,7 @@ monotonic_raw: > clock_nsec=x15, nsec_to_sec=x9 > > add_ts sec=x10, nsec=x11, ts_sec=x13, ts_nsec=x14, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > realtime_coarse: > -- > 2.31.1.368.gbe11c130af-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, MISSING_HEADERS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457DCC433ED for ; Fri, 16 Apr 2021 18:26:33 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD8D2610FB for ; Fri, 16 Apr 2021 18:26:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD8D2610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j/X4O5TguJ2+Q9EQWFOmZ02lr5BzIRguKzRbGggYWcU=; b=CkAxHtJyJyHYgx DbL2aNGLoFZYrDut6Sms83MyJuJ3KHDKLXJwM0RFtwGRvlACl7NYJvuEoXJZdWomy8RpwYGesZn03 93utk/mnfEkTlDAzJp7gvCg2swO9kEtSLU5hM+11fx/AzmzETQERyUwLUHvmxw1cf6N3ujFDmR4tw EU3N1eg9grVIgnu3gfpBhWAbPJ9cdeQ/Mi5/yzSLwo9l5VHFuq5Sk0rmVgbs1RdMnLEvLyz1xVBPx qsaZwpgykyy/5Lq3Mrv8vrTP3b+CbKckDo2JxuXo0KgOjirXYPwf4BbRI++TGC1KRZPtwDjGE2KrO 6XqSwf947itsbcKvw7Lw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXT8c-00346s-AB; Fri, 16 Apr 2021 18:24:18 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXT8Y-00346b-9z for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 18:24:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To:To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NGL2DZ81iiy8zZ9X98sR3lExSRtmhzsEE2kmMo2vY6Y=; b=i0qht2jOW4k4PWd9Rj80spLFBO w83qIsCuY/VUxP268nB9EqdFlN+ZU6e+PHtFGEEmyg9yxwC9B6WyDj13XlOsQBzdYWv67VQdmKH4+ HB+9czvRSdnuYrGmADP5JSqeLXasSgUj5p0UXKH+5XjjK0VhbjnB+HrD8PsBuKDUhIRl9qb3Mh4iC Thjm6Vz6+zp08G3fm+zyQwIpt4NEjsCD8+ph8V1JNcvt9pBf1JZIZQ5/oRHEgr5oauwOiQd6dIJmk 2rucBhKM7TXixN9vTEASvIWN3Xt1ZAKSTUoDtBUXLXRCrR906WStiw7kJvI1hZHFaBr6s9nKQ4aoR DV+NWfDg==; Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXT8T-009ce6-3M for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 18:24:13 +0000 Received: by mail-ot1-x330.google.com with SMTP id v19-20020a0568300913b029028423b78c2dso17938675ott.8 for ; Fri, 16 Apr 2021 11:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc; bh=NGL2DZ81iiy8zZ9X98sR3lExSRtmhzsEE2kmMo2vY6Y=; b=qRxg1AQVpABQRxRIqNU5TKPRxviJzaAJJQvMgYRNOw77gh3Yu7WQSV0s+T33hqXGiZ YBFdsywjmDeOsHpxDxYDsyBhOUeP377VvaPhkfyg1tqcZdAk8HxXX3LG3j/0I+oOX4Yr ggCsVdEKnxJGiqAcoWSC1Eg4vrEBC8ZnMNIH93EITdtCdb3PHD2BnenltnN05fYQ2WMi gm48T9giGwX9vwYFGU0RAs+fLMtWFJ5iGTQJSlvpbPpgFGkXLK1+hmGMSI1W4ilk9T+O 8ruuAxK28VWV0B/hOOHgqrB69eysFrQkUM91ZAAW/yMAz7cEA/VNS3cd9pYTDqiN3rQw S2sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=NGL2DZ81iiy8zZ9X98sR3lExSRtmhzsEE2kmMo2vY6Y=; b=hIYyXtlaZRUIH4GoCLTQ0dUy/yaGZ0xAfOZYoopt373Lo3AsJiXMIi74hpJKIgS655 HHa6HIDJw94i7Cb8ZvkNDXamvANZs/NjhsyLPZcTYUyuOkyehe5R85s3BbFnh5J2rhzY EK/C2b7hqSxqs19oMkFL7T0iOyX4xYIThg1hPlT/AJv7wYqAMVTrHVlZ4Q9jlChebGd2 R4I5mBn5dS2QwIPbYFAzDKbYfTyEwFt1nI7xXrS5U7oOLAYQvXMZYDxaUt5p1EXmFLz9 HbFdZmP5YX29c71mGwFxemuRdB8mmlWlepahD+8A0Ekjp+SnOTLSeDl9pIc2QKMhiQHq ECtg== X-Gm-Message-State: AOAM5334kpLZGOj+55T6+19alGX6FC2IuIIfAovpUQrG1HB3qCizW72h 8O8Zw4HO/26QdJeu+nBFMWRiqBZMFAdlqhPNC/+bIw== X-Received: by 2002:a05:6830:200e:: with SMTP id e14mt4156137otp.111.1618597444844; Fri, 16 Apr 2021 11:24:04 -0700 (PDT) MIME-Version: 1.0 References: <20210416181421.2374588-1-jiancai@google.com> In-Reply-To: <20210416181421.2374588-1-jiancai@google.com> From: Jian Cai Date: Fri, 16 Apr 2021 11:23:53 -0700 Message-ID: Subject: Re: [PATCH] arm64: vdso: remove commas between macro name and arguments Cc: "# 3.4.x" , Greg KH , Sasha Levin , Nick Desaulniers , Nathan Chancellor , Manoj Gupta , Luis Lozano , clang-built-linux , Catalin Marinas , Will Deacon , Linux ARM , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_112409_170059_36D87C74 X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I should've mentioned this patch is for 4.19 only as the code has been rewritten in later versions, but requires a large amount of backports (https://github.com/ClangBuiltLinux/linux/issues/1349). This is the only blocker for 4.19 migration to LLVM's integrated assembler on CrOS that I am aware of. Thanks, Jian On Fri, Apr 16, 2021 at 11:14 AM Jian Cai wrote: > > LLVM's integrated assembler does not support using commas separating > the name and arguments in .macro. However, only spaces are used in the > manual page. This replaces commas between macro names and the subsequent > arguments with space in calls to clock_gettime_return to make it > compatible with IAS. > > Link: > https://sourceware.org/binutils/docs/as/Macro.html#Macro > Signed-off-by: Jian Cai > --- > arch/arm64/kernel/vdso/gettimeofday.S | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kernel/vdso/gettimeofday.S b/arch/arm64/kernel/vdso/gettimeofday.S > index 856fee6d3512..7ee685d9adfc 100644 > --- a/arch/arm64/kernel/vdso/gettimeofday.S > +++ b/arch/arm64/kernel/vdso/gettimeofday.S > @@ -122,7 +122,7 @@ x_tmp .req x8 > 9998: > .endm > > - .macro clock_gettime_return, shift=0 > + .macro clock_gettime_return shift=0 > .if \shift == 1 > lsr x11, x11, x12 > .endif > @@ -227,7 +227,7 @@ realtime: > seqcnt_check fail=realtime > get_ts_realtime res_sec=x10, res_nsec=x11, \ > clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > monotonic: > @@ -250,7 +250,7 @@ monotonic: > clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9 > > add_ts sec=x10, nsec=x11, ts_sec=x3, ts_nsec=x4, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > monotonic_raw: > @@ -271,7 +271,7 @@ monotonic_raw: > clock_nsec=x15, nsec_to_sec=x9 > > add_ts sec=x10, nsec=x11, ts_sec=x13, ts_nsec=x14, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > realtime_coarse: > -- > 2.31.1.368.gbe11c130af-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel