From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-gw0-f47.google.com ([74.125.83.47]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Qy946-00034z-0h for openembedded-core@lists.openembedded.org; Mon, 29 Aug 2011 23:08:18 +0200 Received: by gwb11 with SMTP id 11so4769523gwb.6 for ; Mon, 29 Aug 2011 14:03:25 -0700 (PDT) Received: by 10.236.72.233 with SMTP id t69mr27983301yhd.55.1314651803779; Mon, 29 Aug 2011 14:03:23 -0700 (PDT) Received: from mail-yw0-f47.google.com (mail-yw0-f47.google.com [209.85.213.47]) by mx.google.com with ESMTPS id j45sm120027yhe.36.2011.08.29.14.03.21 (version=SSLv3 cipher=OTHER); Mon, 29 Aug 2011 14:03:22 -0700 (PDT) Received: by ywa12 with SMTP id 12so4692018ywa.6 for ; Mon, 29 Aug 2011 14:03:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.86.2 with SMTP id o2mr3302989ybl.107.1314651801471; Mon, 29 Aug 2011 14:03:21 -0700 (PDT) Received: by 10.150.177.4 with HTTP; Mon, 29 Aug 2011 14:03:21 -0700 (PDT) In-Reply-To: References: <1314598341-2793-1-git-send-email-joelagnel@ti.com> Date: Mon, 29 Aug 2011 17:03:21 -0400 Message-ID: From: Jason Kridner To: Patches and discussions about the oe-core layer Cc: Graeme Gregory , Jason Kridner , "k-kooi@ti.com" Subject: Re: [RFC oe-core] mkcard: Add a script to parition and format an SD Card X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2011 21:08:18 -0000 Content-Type: text/plain; charset=ISO-8859-1 >>> >>> This script is BSP specific and shouldn't live in the OE-core layer. >> >> The only issue is this script is used from within the IMAGE_CMD_sdimg >> code which lives in OE-core (meta/classes/image_types. > > classes shouldn't be calling external scripts > Is the right approach to add parameters to the IMAGE_CMD_sdimg class such that it can be used generically to produce SD card images, instead of trying to move this to meta-ti? Should it perhaps be a bit closer to what is being done by the Linaro image tools [1]? [1] https://wiki.linaro.org/Source/ImageBuilding