[Buildroot] [PATCH v2 1/2] package/python-pydal: new package

[Angelo Compagnucci <angelo.compagnucci@gmail.com>]

Dear Thomas Petazzoni,

2015-04-13 16:17 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Dear Angelo Compagnucci,
>
> On Mon, 13 Apr 2015 15:57:26 +0200, Angelo Compagnucci wrote:
>
>> diff --git a/package/python-pydal/Config.in b/package/python-pydal/Config.in
>> new file mode 100644
>> index 0000000..eda2f77
>> --- /dev/null
>> +++ b/package/python-pydal/Config.in
>> @@ -0,0 +1,2 @@
>> +config BR2_PACKAGE_PYTHON_PYDAL
>> +     bool
>
> I understand that the source code for this package is copied into the
> web2py code, so that's why it's a prompt-less package. Is it the only
> way of doing things?

No. Unfortunately buildroot doesn't support git submodules: the
download helper makes a bare clone and zip the results without git
informations, so it's not possible to do a submodule init in a
POST_EXTRACT action.

The only way is to add a dummy package for the submodule and copy the
downloaded content to appropriate folders. I was inspired by other
packages (ex sunxi-mali-prop) that use the same exact method.

>> diff --git a/package/python-pydal/python-pydal.mk b/package/python-pydal/python-pydal.mk
>> new file mode 100644
>> index 0000000..a88bf8b
>> --- /dev/null
>> +++ b/package/python-pydal/python-pydal.mk
>> @@ -0,0 +1,13 @@
>> +################################################################################
>> +#
>> +# python-pydal
>> +#
>> +################################################################################
>> +
>> +PYTHON_PYDAL_VERSION = v15.03
>> +PYTHON_PYDAL_SITE = https://github.com/web2py/pydal.git
>> +PYTHON_PYDAL_SITE_METHOD = git
>
> github function?

Using this method I can use alternatively both commit id or tag.
Usually web2py uses a tagged pydal version as a submodule, sometimes
not.

>> +PYTHON_PYDAL_LICENSE = BSDv3
>
> BSDv3 does not exist. You're confusing GPLv3 and BSD-3c.

Doh! Probably also the original author is wrong:

"License
pyDAL is released under the BSDv3 License.
For further details, please check the LICENSE file."

I will submit a PR to Giovanni Barillari!

>> +PYTHON_PYDAL_LICENSE_FILES = LICENSE
>> +
>> +$(eval $(generic-package))
>
> A comment above this to explain why we have this generic-package that
> doesn't do anything.

Ok!

>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com



-- 
Profile: http://it.linkedin.com/in/compagnucciangelo