All of lore.kernel.org
 help / color / mirror / Atom feed
From: Diego Viola <diego.viola@gmail.com>
To: hdegoede@redhat.com
Cc: axboe@kernel.dk, tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9
Date: Fri, 26 Oct 2018 10:48:55 -0300	[thread overview]
Message-ID: <CA+ToGPH4+=6foUoBOiay9C97eBaUG=kn4RezrH7Wrr_CaL-=Tw@mail.gmail.com> (raw)
In-Reply-To: <6749376c-930a-3392-6a02-386431a9a432@redhat.com>

Hi Hans,

On Fri, Oct 26, 2018 at 8:59 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 26-10-18 03:58, Diego Viola wrote:
> > med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> > MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> >
> > Switching the LPM to max_performance fixes this issue.
> >
> > Signed-off-by: Diego Viola <diego.viola@gmail.com>
>
> Thank you for the patch, have you updated the firmware and
> confirmed that this happens with the latest firmware version too ?

No, I haven't tired the latest one yet.

The last time I saw, Samsung/Lenovo doesn't make it very easy for
Linux users, and I don't have a Windows installation to perform the
upgrade.

>
> If not please send a new version limiting the blacklist to your
> firmware version.

OK. Sent.

>
> Regards,
>
> Hans
>
>
>
>
> > ---
> >   drivers/ata/libata-core.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> > index a9dd4ea7467d..a7f5202a4815 100644
> > --- a/drivers/ata/libata-core.c
> > +++ b/drivers/ata/libata-core.c
> > @@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> >       /* These specific Samsung models/firmware-revs do not handle LPM well */
> >       { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
> >       { "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> > +     { "SAMSUNG MZ7TD256HAFV-000L9", NULL,       ATA_HORKAGE_NOLPM, },
> >
> >       /* devices that don't properly handle queued TRIM commands */
> >       { "Micron_M500IT_*",            "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
> >

Regards,
Diego

  reply	other threads:[~2018-10-26 13:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  1:58 [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9 Diego Viola
2018-10-26 11:59 ` Hans de Goede
2018-10-26 13:48   ` Diego Viola [this message]
2018-10-26 14:33     ` Diego Viola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ToGPH4+=6foUoBOiay9C97eBaUG=kn4RezrH7Wrr_CaL-=Tw@mail.gmail.com' \
    --to=diego.viola@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.