From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F238C433E9 for ; Mon, 8 Feb 2021 07:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0357A64E73 for ; Mon, 8 Feb 2021 07:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbhBHHMY (ORCPT ); Mon, 8 Feb 2021 02:12:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbhBHHMS (ORCPT ); Mon, 8 Feb 2021 02:12:18 -0500 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 958E0C06174A for ; Sun, 7 Feb 2021 23:11:33 -0800 (PST) Received: by mail-il1-x12e.google.com with SMTP id y15so11807464ilj.11 for ; Sun, 07 Feb 2021 23:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dtdVayBX6UDjQtmEyy8z/vQZLYAXfGsvcdYsRYL7i+A=; b=HsATA8BUgGSkKmvQzhNL2KUUQkazNMh7CvRkXUsvHcRUc31oM/ZM7tSHOr/tASzNzZ 6ozs5QEg3GCxoHBx7nZvxfHGD2eX3dN4pikX458C8MRak7tAFvMN/sdDYiiOMnfCEelm uBlL6WwSRnByoNIl8EHDMPrsa7dd0lQ5Nf7pOuNCk1ROQtH1GrkWQC1joQuQBzkLkKH6 Lwznclb8EX7D5dXy5Us+fx49uj5P/8C/2Kw0N9w9hFr7RO080NjnOzk04hFy7/FmXfE2 1EXE4ALH1RpoILjsfinxtwasYzJnTXeSxH59kmyRXK8ju6T+U2yC10rJQ3h1G2U8adqw 6eQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dtdVayBX6UDjQtmEyy8z/vQZLYAXfGsvcdYsRYL7i+A=; b=HQwc6WZ1BEs6bnnHL1Ur19sMraTlTZVTdUVt0tz03RUked/gyZKwMV4Pl/IayDT3KN 4zO2H/GGnJYzRDaqm0d4jkB3fbcoXHV/ys2i2wt4HMISnXqkZzgOdD47gM+jCH+B4jHv xe5g05nXbf9DogfNvcM4gaFQqHr4PmD8QsYCy9CRwArFf54pOgk0ci6Il32M/1FktDE9 z6Ji+DHiR6Ooway/p3fSd1myMbPa/ghtc0I9IRVrezN45j5cvRic3cfjJK3JM+G/EOTq NpvSfrubfK1sq5cJ7NZOyeFbhvw42z7xlOOeCmvRrCO81RxRAqaUYXw6pBlEeR/mmTfv uEqA== X-Gm-Message-State: AOAM532ZkXo/mrqrPxAQ+2SXu9CTBenUCdJLfG0NSJwTWexxTm4TsEu4 0bY1qcqbaf/4T73bA4ZQOUdHQpoHEDl3EjNoQtUWAmcwuMw= X-Google-Smtp-Source: ABdhPJxwanPIKjWAEb2mdk81izxTrL2Bpe4lwhW2kRvE21kNXluzZEDzCHMBZqRy6zdBjFhgGHDVrJiIA0Pyoc+6lIU= X-Received: by 2002:a92:d30d:: with SMTP id x13mr14343562ila.217.1612768292981; Sun, 07 Feb 2021 23:11:32 -0800 (PST) MIME-Version: 1.0 References: <20210207154623.433442-1-jic23@kernel.org> <20210207154623.433442-21-jic23@kernel.org> In-Reply-To: <20210207154623.433442-21-jic23@kernel.org> From: Alexandru Ardelean Date: Mon, 8 Feb 2021 09:11:21 +0200 Message-ID: Subject: Re: [PATCH 20/24] staging:iio:cdc:ad7150: Add of_match_table To: Jonathan Cameron Cc: linux-iio , Lars-Peter Clausen , Michael Hennerich , song.bao.hua@hisilicon.com, Rob Herring , Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, Feb 7, 2021 at 5:52 PM Jonathan Cameron wrote: > > From: Jonathan Cameron > > Rather than using the fallback path in the i2c subsystem and hoping > for no clashes across vendors, lets put in an explicit table for > matching. > > Signed-off-by: Jonathan Cameron > --- > drivers/staging/iio/cdc/ad7150.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index 0bc8c7a99883..33c8a78c076f 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -655,9 +656,16 @@ static const struct i2c_device_id ad7150_id[] = { > > MODULE_DEVICE_TABLE(i2c, ad7150_id); > > +static const struct of_device_id ad7150_of_match[] = { > + { "adi,ad7150" }, > + { "adi,ad7151" }, > + { "adi,ad7156" }, Is this missing some match_driver_data logic? Something like this: https://patchwork.kernel.org/project/linux-iio/patch/20210207154623.433442-7-jic23@kernel.org/ ? > + {} > +}; > static struct i2c_driver ad7150_driver = { > .driver = { > .name = "ad7150", > + .of_match_table = ad7150_of_match, > }, > .probe = ad7150_probe, > .id_table = ad7150_id, > -- > 2.30.0 >