From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Himanshu Jha" <himanshujha199640@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>
Subject: Re: [PATCH] iio:accel:adis16201: Fix wrong axis assignment that prevents loading
Date: Mon, 22 Mar 2021 09:43:57 +0200 [thread overview]
Message-ID: <CA+U=DsqiYC7Gq3N_htgAmLrRXBvJtfV1urFoG2aYVf=G15hB9Q@mail.gmail.com> (raw)
In-Reply-To: <20210321182956.844652-1-jic23@kernel.org>
On Sun, Mar 21, 2021 at 8:34 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Whilst running some basic tests as part of writing up the dt-bindings for
> this driver (to follow), it became clear it doesn't actually load
> currently.
>
> iio iio:device1: tried to double register : in_incli_x_index
> adis16201 spi0.0: Failed to create buffer sysfs interfaces
> adis16201: probe of spi0.0 failed with error -16
>
> Looks like a cut and paste / update bug. Fixes tag obviously not accurate
> but we don't want to bother carry thing back to before the driver moved
> out of staging.
>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
> Fixes: 591298e54cea ("Staging: iio: accel: adis16201: Move adis16201 driver out of staging")
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Himanshu Jha <himanshujha199640@gmail.com>
> Cc: Nuno Sá <nuno.sa@analog.com>
> ---
> drivers/iio/accel/adis16201.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
> index 3633a4e302c6..fe225990de24 100644
> --- a/drivers/iio/accel/adis16201.c
> +++ b/drivers/iio/accel/adis16201.c
> @@ -215,7 +215,7 @@ static const struct iio_chan_spec adis16201_channels[] = {
> ADIS_AUX_ADC_CHAN(ADIS16201_AUX_ADC_REG, ADIS16201_SCAN_AUX_ADC, 0, 12),
> ADIS_INCLI_CHAN(X, ADIS16201_XINCL_OUT_REG, ADIS16201_SCAN_INCLI_X,
> BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
> - ADIS_INCLI_CHAN(X, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
> + ADIS_INCLI_CHAN(Y, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
> BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
> IIO_CHAN_SOFT_TIMESTAMP(7)
> };
> --
> 2.31.0
>
next prev parent reply other threads:[~2021-03-22 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 18:29 [PATCH] iio:accel:adis16201: Fix wrong axis assignment that prevents loading Jonathan Cameron
2021-03-22 7:43 ` Alexandru Ardelean [this message]
2021-03-29 10:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+U=DsqiYC7Gq3N_htgAmLrRXBvJtfV1urFoG2aYVf=G15hB9Q@mail.gmail.com' \
--to=ardeleanalex@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=himanshujha199640@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.