From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roman Shaposhnik <rvs@apache.org>
Date: Fri, 9 Apr 2021 00:00:07 -0700
Subject: Running u-boot 2021.04 on Raspberry Pi 4
In-Reply-To: <7520b046-f60f-8903-d8aa-eea3b2755be7@gmail.com>
References: <CA+ULb+tVe0V7GdSYSCkODOBdU2_EvF_DszimsuPjVp+m_eh2Qw@mail.gmail.com>
 <7520b046-f60f-8903-d8aa-eea3b2755be7@gmail.com>
Message-ID: <CA+ULb+tLe=fu9JvLn4gx1FWd5iXWQr4OQ_VdobsGUnVyNhhgzQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, Apr 8, 2021 at 8:59 PM Sean Anderson <seanga2@gmail.com> wrote:

> On 4/8/21 8:18 PM, Roman Shaposhnik wrote:
> > Hi!
> >
> > first time poster, long time lurker here. Over at Project EVE
> > https://github.com/lf-edge/eve I've been trying to migrate
> > from our current u-boot v2020.07 + patches:
> >
> >
> https://github.com/lf-edge/eve/tree/master/pkg/u-boot/patches/patches-v2020.07
> > to the latest u-boot 2021.04.
> >
> > Great news is that most of the patches we dependent
> > on seem to have been pulled upstream. However, this
> > single *chunk* of one patchset wasn't:
> >
> >
> https://github.com/lf-edge/eve/blob/master/pkg/u-boot/patches/patches-v2020.07/0001-usb-xhci-Load-Raspberry-Pi-4-VL805-s-firmware.patch#L293
> >
> > I'm wondering what was the reason for leaving it behind,
>
> +CC Nicolas
>
> >  - Get rid of PCI core patch as not needed with correct DT PCI topology
>
> also from the cover letter
>
> > This also depends on a DT/bindings patch available on the linux-mailing
> lists:
> > https://www.mail-archive.com/linux-kernel at .../msg2205783.html
>
> The merged version of this series is
>
>
> https://patchwork.kernel.org/project/linux-usb/list/?series=310015&state=%2A&archive=both
>
> > Here is the relevant bit for reference/discussion:
> >
> >         &pcie0 {
> >                pci at 1,0 {
> >                        #address-cells = <3>;
> >                        #size-cells = <2>;
> >                        ranges;
> >
> >                        reg = <0 0 0 0 0>;
> >
> >                        usb at 1,0 {
> >                                reg = <0x10000 0 0 0 0>;
> >                                resets = <&reset
> RASPBERRYPI_FIRMWARE_RESET_ID_USB>;
> >                        };
> >                };
> >         };
>

Aha! Thank you so much -- this is super helpful!


> > since without it I don't seem to have functioning USB
> > devices on my  Raspberry Pi 4. In fact, adding it back:
> >
> >
> https://github.com/rvs/eve/tree/u-boot/pkg/u-boot/patches/patches-v2021.04
> > (just that one chunk -- 'cuz the reset got upstreamed)
> > seems to solve the issue for me.
> >
> > Another question I have is that the new u-boot seems to have
> > some kind of a regression that I can't quite debug. The SMBIOS
> > tables that it constructs during EFI boot sequence seem to be
> > broken (see the dmidecode output below). Again, this seems
> > to be a regression compared to  v2020.07. Any ideas on what
> > could be wrong or how can I start debugging it would be
>
> You can always bisect it ;)
>

LOL -- true! I was just hoping someone would recognize the issue perhaps.

Thanks,
Roman.