From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E04C43219 for ; Thu, 12 May 2022 17:59:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357409AbiELR7S (ORCPT ); Thu, 12 May 2022 13:59:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357402AbiELR7R (ORCPT ); Thu, 12 May 2022 13:59:17 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2BCEC5E65; Thu, 12 May 2022 10:59:16 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id r1so11181651ybo.7; Thu, 12 May 2022 10:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J5LtlSnb1TIcHp37520Io1xrdtlhcZMAgBg5VstQEIs=; b=lZCZ2kXNozLp6VEtKev9GPPb/Ca8b/GOWuDWEDnxFmr2PW5mkk1ayrdNjzUuBuce/O VkxoJG3V5PoOzzZKyugTt9/Hrse068GVKLuebuWMZ/J/7/xRLjWMXY+goPoOf/bfzd+N 5K00rCoHIdF4AaYqDf5vy9DpxTXwl8tHCEQg1tTtukrH8w/MYAfEs7qbwMQKw1KM46Sp Ak8PvTiEhvhtd288XIesDhwdkgGTh51UCMu52Zb6g4NfSRqN543Vbx38Xn/OW/h++DqE nS8HB9dQOrg2XkuTOmVdyY+NZMC6HnnqYeaWcGXjdOIAoFeeTc7tzgfRGBKi7pdk6vvU YWrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J5LtlSnb1TIcHp37520Io1xrdtlhcZMAgBg5VstQEIs=; b=ShH4EPnXZcgDcJForrgGvsks4TvTbdV/EMPH3aKSu7AvxTOXenJf3VHu7H8HmQ1qlV 9Qa3zayhSRmpB2oHJxXOsa6as0UzEdcuQj5LNfFxhRQ4j13f5m7FFkWJk4uvOoVZHKlF eTyK5rkrbi0F7Xwk0ejhgY0I55DtcGkmH0A8bXoca8pYTJxoQnTOn+aLLIe1h4UMBR9G JKgv1+IytSc7z7IlkD/BYGPrqfoEnqLr1IZzpjD/TjonSNgEi3stLWtWgWabWZXUCI4v 769LHZlFHwhm/Il7M7HlvWewzaO7f8dh9hLI2Ytudw5/t1h9Co1zNAQCs9nURDo/oEI/ yh6g== X-Gm-Message-State: AOAM533JXWDP93eGf7h7LynWl/LZh9CNBUbwybIa+O2ICFWWqU+gg17J pzWAubfUvXXKCXG3BJYedsPeiDahTdg3mt/Y8ItWDfhgqOzM8g== X-Google-Smtp-Source: ABdhPJw8oYdesn+Orxm9gx4EHBres66mmDLAcsb1yWz97gFDfmdusDw9XaS2ljei9H9t6Eh9/F7HKXvIaUPYBflpXjY= X-Received: by 2002:a25:83d1:0:b0:648:725c:6a05 with SMTP id v17-20020a2583d1000000b00648725c6a05mr1001961ybm.218.1652378355993; Thu, 12 May 2022 10:59:15 -0700 (PDT) MIME-Version: 1.0 References: <20220511183210.5248-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220511183210.5248-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 12 May 2022 18:58:49 +0100 Message-ID: Subject: Re: [PATCH v3 1/5] dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt Controller To: Geert Uytterhoeven Cc: Lad Prabhakar , Linus Walleij , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Bartosz Golaszewski , Philipp Zabel , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Phil Edworthy , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Geert, Thank you for the review. On Thu, May 12, 2022 at 7:43 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Wed, May 11, 2022 at 8:32 PM Lad Prabhakar > wrote: > > Add DT bindings for the Renesas RZ/G2L Interrupt Controller. > > > > Signed-off-by: Lad Prabhakar > > Thanks for the update! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > > @@ -0,0 +1,134 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/interrupt-controller/renesas,rzg2l-irqc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas RZ/G2L (and alike SoC's) Interrupt Controller (IA55) > > + > > +maintainers: > > + - Lad Prabhakar > > + - Geert Uytterhoeven > > + > > +description: | > > + IA55 performs various interrupt controls including synchronization for the external > > + interrupts of NMI, IRQ, and GPIOINT and the interrupts of the built-in peripheral > > + interrupts output by each IP. And it notifies the interrupt to the GIC > > + - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts > > + - GPIO pins used as external interrupt input pins, mapped to 32 GIC SPI interrupts > > + - NMI edge select (NMI is not treated as NMI exception and supports fall edge and > > + stand-up edge detection interrupts) > > + > > +allOf: > > + - $ref: /schemas/interrupt-controller.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - renesas,r9a07g044-irqc # RZ/G2L > > + - const: renesas,rzg2l-irqc > > + > > + '#interrupt-cells': > > + description: The first cell should contain interrupt number and the second cell > > + is used to specify the flag. > > The important part is still missing: which interrupt number (the general > description mentions 3 types)? > I believe the answer is "external interrupt number". > My bad will update to "The first cell should contain an external interrupt number (IRQ0-7) and the second cell is used to specify the flag." Cheers, Prabhakar > > + const: 2 > > + > > + > > Double blank line. > > > + '#address-cells': > > + const: 0 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds