All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-media <linux-media@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"Sakari Ailus" <sakari.ailus@iki.fi>,
	"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint
Date: Wed, 1 Jul 2020 19:46:17 +0100	[thread overview]
Message-ID: <CA+V-a8s6izi09GKU83LBmgXGaGcnuCDnf0ZZOSBTkHhB3JsxqQ@mail.gmail.com> (raw)
In-Reply-To: <20200701062140.12953-2-laurent.pinchart+renesas@ideasonboard.com>

Hi Laurent,

Thank you for the patch.

On Wed, Jul 1, 2020 at 7:21 AM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
>
> Drivers may need to test if a fwnode is a graph endpoint. To avoid
> hand-written solutions that wouldn't work for all fwnode types, add a
> new fwnode_graph_is_endpoint() function for this purpose. We don't need
> to wire it up to different backends for OF and ACPI for now, as the
> implementation can simply be based on checkout the presence of a
> remote-endpoint property.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  include/linux/property.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
--Prabhakar

> diff --git a/include/linux/property.h b/include/linux/property.h
> index 10d03572f52e..9f805c442819 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -389,6 +389,11 @@ struct fwnode_handle *
>  fwnode_graph_get_remote_node(const struct fwnode_handle *fwnode, u32 port,
>                              u32 endpoint);
>
> +static inline bool fwnode_graph_is_endpoint(struct fwnode_handle *fwnode)
> +{
> +       return fwnode_property_present(fwnode, "remote-endpoint");
> +}
> +
>  /*
>   * Fwnode lookup flags
>   *
> --
> Regards,
>
> Laurent Pinchart
>

  parent reply	other threads:[~2020-07-01 18:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  6:21 [PATCH v4 0/4] media: v4l2-async: Accept endpoints and devices for fwnode matching Laurent Pinchart
2020-07-01  6:21 ` [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint Laurent Pinchart
2020-07-01  7:34   ` Sakari Ailus
2020-07-01 12:19     ` Rafael J. Wysocki
2020-07-15 20:57       ` Sakari Ailus
2020-07-17  2:19         ` Laurent Pinchart
2020-07-17  7:56           ` Sakari Ailus
2020-07-01 17:06   ` Niklas Söderlund
2020-07-01 18:46   ` Lad, Prabhakar [this message]
2020-07-01 21:03   ` Kieran Bingham
2020-07-01  6:21 ` [PATCH v4 2/4] media: v4l2-async: Accept endpoints and devices for fwnode matching Laurent Pinchart
2020-07-01  6:21 ` [PATCH v4 3/4] media: v4l2-async: Pass notifier pointer to match functions Laurent Pinchart
2020-07-01  6:21 ` [PATCH v4 4/4] media: v4l2-async: Log message in case of heterogeneous fwnode match Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+V-a8s6izi09GKU83LBmgXGaGcnuCDnf0ZZOSBTkHhB3JsxqQ@mail.gmail.com \
    --to=prabhakar.csengg@gmail.com \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=rjw@rjwysocki.net \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.