From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AC3C6FA86 for ; Sat, 24 Sep 2022 11:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233469AbiIXLig (ORCPT ); Sat, 24 Sep 2022 07:38:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbiIXLie (ORCPT ); Sat, 24 Sep 2022 07:38:34 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF07D10B23F; Sat, 24 Sep 2022 04:38:32 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id c30so2128908edn.2; Sat, 24 Sep 2022 04:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=dyM/rt0gKNSVbo2LRmeJCOAYDEu/aCHyvBr+3Af8zq8=; b=fmAeP3hPmDf+RNnACiFP0vinV3rvcS+CuIuamPXvHu+P0MgDyl46tIxHNM44QYE13l aHDrv1G+8cK8o62yQb2IiG1mcuQ3FBda9rDKziRGcBoUY6/aLDGDRnfytIYFi4RgmVwU qUvjqoGwd9KtFIsnCtpvYqSmu/WKgzkTL7yiqILov98cmzYpTcgQTvtOgwc2WFwN9yj1 HeORF7f6fTrOALdzZw/V4gsbyQHcr7FaF/dgwTC75wbPIHSZ73xFSK6UYuHWNIb1JXwY uYJcOME+Sm5WKDtFKfAFcm4yXZKX3Xn/lrbP1MhxY7qOoLXYtom21l1epJXWDQ3lXe0Q C7yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=dyM/rt0gKNSVbo2LRmeJCOAYDEu/aCHyvBr+3Af8zq8=; b=rd1WL8JuBf8CxtEumpdidRA17iecQkSQ4axkqsmFqLjrtHo8Bh50zZn7D4MwQH8cwy oJr698YHMgx6S3ZjD4Osv6hcXoo3Gro689gS1Oc+GFZzMHKaEFfE3TTjT+fXBq5w7VXN CZRWkyeh2sLPxchogA9rLmOx88MUpNBHXzu65ZVgu9wsMczvBgbR6x3yLWZ5kHnxxz6h IWyyJkVYXFpxFY8b7GJ6iyAqYcUSu+8pUSIdlOzsImJ399J+yW40xdHbjOpGeZ+4n0nS ckogahrsmRjjSMiknN8IUBnTdf0Bgex69HzGkgSc5gpuzqPJvx3CT1QlxMS+qN2fdZGN Y4Wg== X-Gm-Message-State: ACrzQf1z1dPypoBA/cSeLJfkioj6AEjGGbg+6HLsQNlTgysTFEWD/aZE tOeGD4Zzt5Fa/A6zewap2mKRh6CA9TYsMVg4MhU= X-Google-Smtp-Source: AMsMyM6npIX132f34bc7kQx5JR4oEJq+EDLjQufM/wqFTh6f/M7O179otOQTl3hUY00Wt62O1jTuICK0Jn692CCz7hY= X-Received: by 2002:a05:6402:350b:b0:452:2b68:90db with SMTP id b11-20020a056402350b00b004522b6890dbmr12971523edd.255.1664019511404; Sat, 24 Sep 2022 04:38:31 -0700 (PDT) MIME-Version: 1.0 References: <20220905230406.30801-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220905230406.30801-5-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Sat, 24 Sep 2022 12:38:03 +0100 Message-ID: Subject: Re: [PATCH v2 4/4] media: platform: Add Renesas RZ/G2L CRU driver To: Sakari Ailus Cc: Lad Prabhakar , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Jacopo Mondi , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Hans Verkuil , Geert Uytterhoeven , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sakari, Thank you for the review. On Fri, Sep 23, 2022 at 9:14 PM Sakari Ailus wrote: > > Hi Prabhakar, > > On Tue, Sep 06, 2022 at 12:04:06AM +0100, Lad Prabhakar wrote: > ... > > > +#define to_buf_list(vb2_buffer) (&container_of(vb2_buffer, \ > > + struct rzg2l_cru_buffer, \ > > + vb)->list) > > #define to_buf_list(vb2_buffer) \ > (&container_of(vb2_buffer, struct rzg2l_cru_buffer, vb)->list) > OK. > > ... > > > +static int rzg2l_cru_open(struct file *file) > > +{ > > + struct rzg2l_cru_dev *cru = video_drvdata(file); > > + int ret; > > + > > + ret = clk_prepare_enable(cru->pclk); > > + if (ret) > > + return ret; > > + > > + ret = clk_prepare_enable(cru->vclk); > > + if (ret) > > + goto disable_pclk; > > + > > + ret = clk_prepare_enable(cru->aclk); > > + if (ret) > > + goto disable_vclk; > > + > > + ret = mutex_lock_interruptible(&cru->lock); > > + if (ret) > > + goto disable_aclk; > > + > > + file->private_data = cru; > > + ret = v4l2_fh_open(file); > > + if (ret) > > + goto err_unlock; > > + > > + ret = v4l2_pipeline_pm_get(&cru->vdev.entity); > > Please use runtime PM instead in sensor drivers, we're trying to get rid of > this function. > OK. > It'd be nice to have it in this one as well. > I'll will switch to runtime PM. > > + if (ret < 0) > > + goto err_open; > > + > > + mutex_unlock(&cru->lock); > > + > > + return 0; > > +err_open: > > + v4l2_fh_release(file); > > +err_unlock: > > + mutex_unlock(&cru->lock); > > +disable_aclk: > > + clk_disable_unprepare(cru->aclk); > > +disable_vclk: > > + clk_disable_unprepare(cru->vclk); > > +disable_pclk: > > + clk_disable_unprepare(cru->pclk); > > + > > + return ret; > > +} > > ... > > > +void rzg2l_cru_v4l2_unregister(struct rzg2l_cru_dev *cru) > > +{ > > + if (!video_is_registered(&cru->vdev)) > > + return; > > + > > + v4l2_info(&cru->v4l2_dev, "Removed %s\n", > > + video_device_node_name(&cru->vdev)); > > I'd just leave this out. Same for the similar message on registration. > OK, I'll drop both the messages. Cheers, Prabhakar