From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbbBRWuA (ORCPT ); Wed, 18 Feb 2015 17:50:00 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:47623 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbbBRWt7 (ORCPT ); Wed, 18 Feb 2015 17:49:59 -0500 MIME-Version: 1.0 In-Reply-To: <54E1D78C.3000305@xs4all.nl> References: <1421965128-10470-1-git-send-email-prabhakar.csengg@gmail.com> <54CF5E70.3000302@xs4all.nl> <54E1D78C.3000305@xs4all.nl> From: "Lad, Prabhakar" Date: Wed, 18 Feb 2015 22:49:26 +0000 Message-ID: Subject: Re: [PATCH v2 00/15] media: blackfin: bfin_capture enhancements To: Hans Verkuil Cc: LMML , Scott Jiang , adi-buildroot-devel@lists.sourceforge.net, LKML , Mauro Carvalho Chehab Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans On Mon, Feb 16, 2015 at 11:42 AM, Hans Verkuil wrote: > On 02/02/2015 12:24 PM, Hans Verkuil wrote: >> On 01/30/2015 04:49 PM, Lad, Prabhakar wrote: >>> Hello Scott, >>> >>> On Thu, Jan 22, 2015 at 10:18 PM, Lad, Prabhakar >>> wrote: >>>> This patch series, enhances blackfin capture driver with >>>> vb2 helpers. >>>> >>>> Changes for v2: >>>> -------------- >>>> Only patches 5/15 and 8/15 as per Scott's suggestions. >>>> >>>> Lad, Prabhakar (15): >>>> media: blackfin: bfin_capture: drop buf_init() callback >>>> media: blackfin: bfin_capture: release buffers in case >>>> start_streaming() call back fails >>>> media: blackfin: bfin_capture: set min_buffers_needed >>>> media: blackfin: bfin_capture: improve buf_prepare() callback >>>> media: blackfin: bfin_capture: improve queue_setup() callback >>>> media: blackfin: bfin_capture: use vb2_fop_mmap/poll >>>> media: blackfin: bfin_capture: use v4l2_fh_open and vb2_fop_release >>>> media: blackfin: bfin_capture: use vb2_ioctl_* helpers >>>> media: blackfin: bfin_capture: make sure all buffers are returned on >>>> stop_streaming() callback >>>> media: blackfin: bfin_capture: return -ENODATA for *std calls >>>> media: blackfin: bfin_capture: return -ENODATA for *dv_timings calls >>>> media: blackfin: bfin_capture: add support for vidioc_create_bufs >>>> media: blackfin: bfin_capture: add support for VB2_DMABUF >>>> media: blackfin: bfin_capture: add support for VIDIOC_EXPBUF >>>> media: blackfin: bfin_capture: set v4l2 buffer sequence >>>> >>>> drivers/media/platform/blackfin/bfin_capture.c | 311 ++++++++----------------- >>>> 1 file changed, 99 insertions(+), 212 deletions(-) >>>> >>> Can you ACK the series ? so that its easier for Hans to pick it up. >> >> ping! >> >> Scott, I can't take it unless you Ack it. Actually, I'd like to see a >> 'Tested-by' tag. >> >> And if you are testing anyway, then I would really like to see the output >> of 'v4l2-compliance -s', using the v4l2-compliance from the latest v4l-utils.git. >> >> I'm curious to see the results of that. > > Ping! Again, I need an Ack. > Oops I need to respin fixing one of the patch. Cheers, --Prabhakar Lad