From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 222D1C433DF for ; Mon, 10 Aug 2020 10:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 027D92070B for ; Mon, 10 Aug 2020 10:35:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ql9nfHDI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726507AbgHJKfk (ORCPT ); Mon, 10 Aug 2020 06:35:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbgHJKfh (ORCPT ); Mon, 10 Aug 2020 06:35:37 -0400 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67EF1C061756; Mon, 10 Aug 2020 03:35:37 -0700 (PDT) Received: by mail-yb1-xb42.google.com with SMTP id a34so4874965ybj.9; Mon, 10 Aug 2020 03:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1EybH9wbQy4mO2vt6lzN7Vrc2o0dnsrjSRnczK3afhk=; b=ql9nfHDIXvPzRo6BqJuftyl9vZdyc2pY8NddWOOzKoJUrS2iigiHqtfq7PwvsuTsZj GGqALwj8+bWtOCp6lKh+cLbVWRic0oX8e+hzRsCNtgiKrFMt7I+yEq13q0M32E47IjMH odPtlARDQQVqtWS5wRaHcRLpCxnQOSvkKm3In5F3hBV9pvyjhlIaLPwZMZiigp09BnLO fc379WrDRe869rkFmDls2rvY/Fsn4/cndyqC/0JDBFxPzTVqDaUSqKLmptIyk8jKLsQJ NwSdKo+9trDaNtNw2iFtHN/S9Ub/JwuCYlQjzAROMoLNjsgwLfcSYR4QTq/QK07QUbHw WLxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1EybH9wbQy4mO2vt6lzN7Vrc2o0dnsrjSRnczK3afhk=; b=lWl0ixuht2azzBr1hMrHHEK+SKd71oQ63hbCtcERjGch/wi0YrGH0idWK9FoN74vA6 ayQcwK1bZxrNQxF41pF48jq6NlSVEESCdjQjW0YK/jbp64IL2v1VxD49+41JL5QWfIzC LxplBj+j/SD2RYjPuPZ0FVUHt5XJamDpFuEZ+tZ3xIungdy+syRyxbPy/2E9zWo/5uTy Zc4M3gW8xuZ7ccTMwNqcSjyRE7PTrpp3vpx27e0koIFgEj6oX8NM1I8d6DKWM6B6JwR+ xxOFC932fX+rGaCEKFaH8R/ATUCppuz5eyqrIIWXj9LH6aTb/c59CTtX2j31UrB+AH9f qDQQ== X-Gm-Message-State: AOAM533qQw8aL6RwJzJsREiPBK3nK/fyddHsYGD70XddyosfF8qk0U6i Y+XOSvuTeHeEIL0soHH4R9BliJVmGfITDAmeTv8= X-Google-Smtp-Source: ABdhPJyvQ7P8sYbiS8LPxHzeimpJrb76KiAlFlZXMVJEgex+WAdQFrcSYFVxG+scUu8pHuwS/usrX8q1/7CzxwLmuO0= X-Received: by 2002:a25:c743:: with SMTP id w64mr36285444ybe.127.1597055736618; Mon, 10 Aug 2020 03:35:36 -0700 (PDT) MIME-Version: 1.0 References: <20200810092208.27320-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200810092208.27320-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Mon, 10 Aug 2020 11:35:09 +0100 Message-ID: Subject: Re: [PATCH 2/2] arm64: dts: renesas: r8a774e1: Add VSP instances To: Geert Uytterhoeven Cc: Lad Prabhakar , Geert Uytterhoeven , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Magnus Damm , Linux Kernel Mailing List , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the review. On Mon, Aug 10, 2020 at 11:29 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Mon, Aug 10, 2020 at 11:22 AM Lad Prabhakar > wrote: > > From: Marian-Cristian Rotariu > > > > The RZ/G2H (R8A774E1) has 6 VSP instances. > > > > Based on the work done for r8a7795 SoC. > > > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi > > @@ -2374,6 +2374,72 @@ > > status = "disabled"; > > }; > > > > + vspbc: vsp@fe920000 { > > + compatible = "renesas,vsp2"; > > + reg = <0 0xfe920000 0 0x8000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 624>; > > + power-domains = <&sysc R8A774E1_PD_A3VP>; > > + resets = <&cpg 624>; > > + > > + renesas,fcp = <&fcpvb1>; > > + }; > > + > > + vspbd: vsp@fe960000 { > > + compatible = "renesas,vsp2"; > > + reg = <0 0xfe960000 0 0x8000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 626>; > > + power-domains = <&sysc R8A774E1_PD_A3VP>; > > + resets = <&cpg 626>; > > + > > + renesas,fcp = <&fcpvb1>; > > According to "FCPVB0 (for VSPBD): H' FE96_F000", this should be > > renesas,fcp = <&fcpvb0>; > > ? If you agree, I can fix that while applying. > Agreed should be fcpvb0, thank you for taking care of it. Cheers, Prabhakar > Reviewed-by: Geert Uytterhoeven > i.e. will queue in renesas-devel for v5.10. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds