From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C034C433DF for ; Thu, 13 Aug 2020 10:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68B97206A4 for ; Thu, 13 Aug 2020 10:38:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sa5APNLz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbgHMKia (ORCPT ); Thu, 13 Aug 2020 06:38:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbgHMKia (ORCPT ); Thu, 13 Aug 2020 06:38:30 -0400 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21134C061757; Thu, 13 Aug 2020 03:38:30 -0700 (PDT) Received: by mail-yb1-xb41.google.com with SMTP id i10so3030184ybt.11; Thu, 13 Aug 2020 03:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZMZSesP5yzJziVUDR23hWsW+wrdDKjDsymbEjLFqlsQ=; b=sa5APNLzKf8++yFtOdgr0UmEUTQkjLHKmS98JuZjQU8iiXX9W5fsI/pxHxvkQp/pre L1wPQ8UHos5VVPsod04HhKTtIHOLqCwGOMlyfvXCcfcYtXAd05//mXXnj+9Nr9O79lig Gmg5K5MyoBIiiK++bUONSQhbZz3DX0telXDWdsqeEvvcmoILrHlY/SnhCJIMArT17mfw Rf3FgbdozoaaWJpGB9uqw7ZTRP2fGpvxNJCXU52ayjvkDrIsZAC3ZDEurBGTgXoxpL4I 2nTC1uKgB/j8/gZ5YLYOkzCNzufavMKERpimxZM9fsOm3Zqt4weTSFvTBDax4QRTAziy xivw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZMZSesP5yzJziVUDR23hWsW+wrdDKjDsymbEjLFqlsQ=; b=pNsY2mFodD2LeRnMlanKT0HMO9EMo2CMsP3hkPzQ/PV73wOVCaXNeqffivTlo/Qjm4 6LHdztjWCxMqExzsiKCvqcx9TVWB7//MB06fwiEO+4/IiPU5qla1s6TrRymj533R02jn HAowrkrC2bCUeC7F0VbgTJXByPCT3c2HCiF4wCZIx9tmV/Ptd/dok4ngS8QxgLT+xpRg mbVBdsy4E2kzGLZHD/RguT984Pwk4oI0y+vEJc9mrlGIXxq/llCxigalDqGyEdEXedyc CL6FK4VH+jL8LKpr6nNUKDxL8mp4QaL0Dll8n+kIsCg95GxnmC3qycwcIHeWzE/qjOZT d3yA== X-Gm-Message-State: AOAM5315XcLBk7geYmV12EB8A8JnsbRTNm2p5oDBU7d3s+AGtHtUtwjl TwxsH26jqF9zuJbEXEPoZsGc+HA+9fzBtT6fG1U= X-Google-Smtp-Source: ABdhPJxlD8cvv3MGdWdeGBFCofqNyFiyRzL6aLDFdKQMT546vAVCQ0J4+sbcoOKuURBKl4JSRx8EFeWSlvxap8nxl8c= X-Received: by 2002:a25:6ad6:: with SMTP id f205mr5654937ybc.76.1597315109361; Thu, 13 Aug 2020 03:38:29 -0700 (PDT) MIME-Version: 1.0 References: <20200812140217.24251-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200812140217.24251-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 13 Aug 2020 11:38:03 +0100 Message-ID: Subject: Re: [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings To: Geert Uytterhoeven , Laurent Pinchart , Kieran Bingham , Chris Paterson , Biju Das Cc: Lad Prabhakar , David Airlie , Daniel Vetter , Rob Herring , Magnus Damm , DRI Development , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the review. On Thu, Aug 13, 2020 at 10:05 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, Laurent, Kieran, > > On Wed, Aug 12, 2020 at 4:02 PM Lad Prabhakar > wrote: > > From: Marian-Cristian Rotariu > > > > Document the RZ/G2H (a.k.a. r8a774e1) SoC in the R-Car DU bindings. > > > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > > --- > > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > > index 51cd4d162770..67cded5ad827 100644 > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > @@ -10,6 +10,7 @@ Required Properties: > > - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU > > - "renesas,du-r8a774b1" for R8A774B1 (RZ/G2N) compatible DU > > - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU > > + - "renesas,du-r8a774e1" for R8A774E1 (RZ/G2H) compatible DU > > - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU > > - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU > > - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU > > @@ -75,6 +76,7 @@ corresponding to each DU output. > > R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 - > > R8A774B1 (RZ/G2N) DPAD 0 HDMI 0 LVDS 0 - > > R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 - > > + R8A774E1 (RZ/G2H) DPAD 0 HDMI 0 LVDS 0 - > > As LVDS 0 is the fourth channel (DU3), should it be listed under port 3 > instead of port 2? > > I know we did it the same for R-Car M3-N and RZ/G2N. > But my main worry is adding support for R-Car H3-N later. > I do agree too, with the below diff I tested the LVDS output on RZ/G2N Rev2 board and things work fine. But only thing it doesn't explain is why does LVDS work on DU2 for G2[H/N] boards :D Geert, Laurent, Kieran If you agree with the below changes I shall post a proper patch fixing it for RZ/G2[HN] diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi index d661724fc28a..0b087d287202 100644 --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi @@ -2540,8 +2540,8 @@ remote-endpoint = <&dw_hdmi0_in>; }; }; - port@2 { - reg = <2>; + port@3 { + reg = <3>; du_out_lvds0: endpoint { remote-endpoint = <&lvds0_in>; }; diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 3e67cf70f040..419d81c7763e 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -153,7 +153,7 @@ static const struct rcar_du_device_info rcar_du_r8a774b1_info = { }, [RCAR_DU_OUTPUT_LVDS0] = { .possible_crtcs = BIT(0), - .port = 2, + .port = 3, }, }, .num_lvds = 1, Cheers, Prabhakar > > R8A7779 (R-Car H1) DPAD 0 DPAD 1 - - > > R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 - > > R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - - > > Apart from that: > Reviewed-by: Geert Uytterhoeven > > {oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28E2C433E3 for ; Mon, 17 Aug 2020 07:07:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B98E02072D for ; Mon, 17 Aug 2020 07:07:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sa5APNLz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B98E02072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E6E946E4EC; Mon, 17 Aug 2020 07:06:54 +0000 (UTC) Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3370C6E9A5 for ; Thu, 13 Aug 2020 10:38:30 +0000 (UTC) Received: by mail-yb1-xb42.google.com with SMTP id m200so3034907ybf.10 for ; Thu, 13 Aug 2020 03:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZMZSesP5yzJziVUDR23hWsW+wrdDKjDsymbEjLFqlsQ=; b=sa5APNLzKf8++yFtOdgr0UmEUTQkjLHKmS98JuZjQU8iiXX9W5fsI/pxHxvkQp/pre L1wPQ8UHos5VVPsod04HhKTtIHOLqCwGOMlyfvXCcfcYtXAd05//mXXnj+9Nr9O79lig Gmg5K5MyoBIiiK++bUONSQhbZz3DX0telXDWdsqeEvvcmoILrHlY/SnhCJIMArT17mfw Rf3FgbdozoaaWJpGB9uqw7ZTRP2fGpvxNJCXU52ayjvkDrIsZAC3ZDEurBGTgXoxpL4I 2nTC1uKgB/j8/gZ5YLYOkzCNzufavMKERpimxZM9fsOm3Zqt4weTSFvTBDax4QRTAziy xivw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZMZSesP5yzJziVUDR23hWsW+wrdDKjDsymbEjLFqlsQ=; b=JytYm6uKN57hNZp2BU21iQ4ll2fFgEmPgN95r2IQHmuIht4KXVViDuyp/Am+7kMMDe gDjbWr9h4qjPMiVKqvIwqC9tGbvXUTwbdnBFGC/eGffAbfB7nKJfZlc33kn+Atui4iVj MhKtrvQYoTQD3K9PUlysNBX2bM1OdKfdSjaw1gyCLiaggw8/jw6rAoUaUZ0Uri8GgbhK hU43Dsx0cd8dV/+i6kr/ER5u9XpHNEAP2jYlis6l91a6qwDlAE8DkWK1Cdh4Ap+MzmLG RdJdip51wiV0rtA6wsw/aIikf5jlaam779dF2GhJ7sHbYjIKrg21EkXPEdXNfwRY6i2F vZ8Q== X-Gm-Message-State: AOAM530tt7mIVNjC3HL2waIm4+dVrUKQFmOZ9UF1KjGCLYzJRExSEbw0 3YTJqLjku/Ufb5ZDcjRrm52XNSiYr8p+ack8ZOg= X-Google-Smtp-Source: ABdhPJxlD8cvv3MGdWdeGBFCofqNyFiyRzL6aLDFdKQMT546vAVCQ0J4+sbcoOKuURBKl4JSRx8EFeWSlvxap8nxl8c= X-Received: by 2002:a25:6ad6:: with SMTP id f205mr5654937ybc.76.1597315109361; Thu, 13 Aug 2020 03:38:29 -0700 (PDT) MIME-Version: 1.0 References: <20200812140217.24251-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200812140217.24251-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 13 Aug 2020 11:38:03 +0100 Message-ID: Subject: Re: [PATCH 1/9] dt-bindings: display: renesas, du: Document r8a774e1 bindings To: Geert Uytterhoeven , Laurent Pinchart , Kieran Bingham , Chris Paterson , Biju Das X-Mailman-Approved-At: Mon, 17 Aug 2020 07:06:11 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , David Airlie , Magnus Damm , Lad Prabhakar , DRI Development , Linux Kernel Mailing List , Linux-Renesas , Rob Herring Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Geert, Thank you for the review. On Thu, Aug 13, 2020 at 10:05 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, Laurent, Kieran, > > On Wed, Aug 12, 2020 at 4:02 PM Lad Prabhakar > wrote: > > From: Marian-Cristian Rotariu > > > > Document the RZ/G2H (a.k.a. r8a774e1) SoC in the R-Car DU bindings. > > > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > > --- > > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > > index 51cd4d162770..67cded5ad827 100644 > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > @@ -10,6 +10,7 @@ Required Properties: > > - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU > > - "renesas,du-r8a774b1" for R8A774B1 (RZ/G2N) compatible DU > > - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU > > + - "renesas,du-r8a774e1" for R8A774E1 (RZ/G2H) compatible DU > > - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU > > - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU > > - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU > > @@ -75,6 +76,7 @@ corresponding to each DU output. > > R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 - > > R8A774B1 (RZ/G2N) DPAD 0 HDMI 0 LVDS 0 - > > R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 - > > + R8A774E1 (RZ/G2H) DPAD 0 HDMI 0 LVDS 0 - > > As LVDS 0 is the fourth channel (DU3), should it be listed under port 3 > instead of port 2? > > I know we did it the same for R-Car M3-N and RZ/G2N. > But my main worry is adding support for R-Car H3-N later. > I do agree too, with the below diff I tested the LVDS output on RZ/G2N Rev2 board and things work fine. But only thing it doesn't explain is why does LVDS work on DU2 for G2[H/N] boards :D Geert, Laurent, Kieran If you agree with the below changes I shall post a proper patch fixing it for RZ/G2[HN] diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi index d661724fc28a..0b087d287202 100644 --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi @@ -2540,8 +2540,8 @@ remote-endpoint = <&dw_hdmi0_in>; }; }; - port@2 { - reg = <2>; + port@3 { + reg = <3>; du_out_lvds0: endpoint { remote-endpoint = <&lvds0_in>; }; diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 3e67cf70f040..419d81c7763e 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -153,7 +153,7 @@ static const struct rcar_du_device_info rcar_du_r8a774b1_info = { }, [RCAR_DU_OUTPUT_LVDS0] = { .possible_crtcs = BIT(0), - .port = 2, + .port = 3, }, }, .num_lvds = 1, Cheers, Prabhakar > > R8A7779 (R-Car H1) DPAD 0 DPAD 1 - - > > R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 - > > R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - - > > Apart from that: > Reviewed-by: Geert Uytterhoeven > > {oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel