From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA183FA372C for ; Thu, 7 Nov 2019 09:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A49962166E for ; Thu, 7 Nov 2019 09:26:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JaRiVyVn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387826AbfKGJ0K (ORCPT ); Thu, 7 Nov 2019 04:26:10 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:39918 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfKGJ0K (ORCPT ); Thu, 7 Nov 2019 04:26:10 -0500 Received: by mail-oi1-f193.google.com with SMTP id v138so1361665oif.6; Thu, 07 Nov 2019 01:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=svJecAxqhlBawitftrz5LXbFY8d5ATbDsx3obREbmBk=; b=JaRiVyVnWoErWMwSLJsT3edCIFkLrM3bw9K+3t2YOtpGSIe5jPWeSfJJ3zV3UcGXyj wwR2NS63eTI2jFJYHyvrY1LIrbvvYORCOjhiH8sOou1LG6PPH6s0hxYi668s+Ia/fGNp mD+dKjP+i/vpXdma4xZtepheZ7yutdc9rzN+mceieTuhWlkhAMrPEFb/Jt3ett6SzSg9 ELmfrBZVVLKH9oU9mvJlKOogzz4Xf2ygwEAneNX6k9Q9/CL4uLnu6olfZ/Y8MyINIPDf l05fDkGxYqctkz/xtGJFKge5gK+fg8G8ZLe5jNs9w3+fRrpZp6HQVuJW4G6WswW642hk BRQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=svJecAxqhlBawitftrz5LXbFY8d5ATbDsx3obREbmBk=; b=eWvCLpGlJ2B931V8o+ejF2ZRR2cbg1lISYEndpgZJ2HzTVpWuQbR8IeuDWUjFtDd+o 6fucU+L5TPQzoHalkxOKuWrHUWq3DW3hvU4RadKH45FcP6X1JusIKHClZVKqU3ytBsP7 Lf6oV+qc0CifUt1nbzAW1A6tJmc2+I6eqF9MO+1Dp82LcUumI0GhMXsHe0O8GATUBj/G Sg76/eVBJvXJmdY6Ppd2S5uLd7NDVwdObjzqta5rMcIk4MB5vGoJQcKb+qrp1EMEz2AW yHTQ52Po1a2DkT+hmHGuEgmNOhSxlfBYg//Lqxzr1pDWPKt7yG02osWQXo18lVm31Zie Xqrw== X-Gm-Message-State: APjAAAVOi6G9kEFp7kl8s1QvE3I/qjfTyaL3ll1VKlwF/a3T8sKOj8E9 h25vMlN+mS/0reJgR4/SybIHS630Vv3sR252mBoSP8QtILzD0w== X-Google-Smtp-Source: APXvYqzl/mjJb58YCZv+1rPoz9YmBODStqICfxXp/t7vlm94pbfdzMz/foObeQbkPEnjt5Qa5497EWxx2Gk87u9uMzM= X-Received: by 2002:aca:5cc6:: with SMTP id q189mr2405318oib.101.1573118768684; Thu, 07 Nov 2019 01:26:08 -0800 (PST) MIME-Version: 1.0 References: <20191106193609.19645-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191106193609.19645-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 7 Nov 2019 09:25:42 +0000 Message-ID: Subject: Re: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings To: Geert Uytterhoeven Cc: Bjorn Helgaas , Rob Herring , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , linux-pci , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux ARM , Linux-Renesas , Chris Paterson , "Lad, Prabhakar" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the review. On Thu, Nov 7, 2019 at 8:44 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Wed, Nov 6, 2019 at 8:36 PM Lad Prabhakar wrote: > > From: "Lad, Prabhakar" > > > > This patch adds the bindings for the R-Car PCIe endpoint driver. > > > > Signed-off-by: Lad, Prabhakar > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > @@ -0,0 +1,43 @@ > > +* Renesas R-Car PCIe Endpoint Controller DT description > > + > > +Required properties: > > + "renesas,pcie-ep-r8a774c0" for the R8A774C0 SoC; > > + "renesas,pcie-ep-rcar-gen3" for a generic R-Car Gen3 or > > + RZ/G2 compatible device. > > Unless I'm missing something, this is for the exact same hardware block as > Documentation/devicetree/bindings/pci/rcar-pci.txt? > So shouldn't you amend those bindings, instead of adding new compatible > values? > Please remember that DT describes hardware, not software policy. > So IMHO choosing between host and endpoint is purely a configuration > issue, and could be indicated by the presence or lack of some DT properties. > E.g. host mode requires both "bus-range" and "device_type" properties, > so their absence could indicate endpoint mode. > yes its the same hardware block as described in the rcar-pci.txt, I did think about amending it but it might turn out to be bit messy, required properties host ======required properties Endpoint ====================||================== 1: reg || reg 2:bus-range || reg names 3: device_type || resets 4: ranges || clocks 5: dma-ranges || clock-names 6: interrupts || 7: interrupt-cells || 8: interrupt-map-mask || 9: clocks || 10: clock-names || and if I go ahead with the same compatible string that would mean to add support for endpoint mode in the host driver itself. I did follow the examples of rockchip/cadence/designware where its the same hardware block but has two different binding files one for host mode and other for endpoint mode. > > +- reg: Five register ranges as listed in the reg-names property > > +- reg-names: Must include the following names > > + - "apb-base" > > + - "memory0" > > + - "memory1" > > + - "memory2" > > + - "memory3" > > What is the purpose of the last 4 regions? > Can they be chosen by the driver, at runtime? > no the driver cannot choose them at runtime, as these are the only PCIE memory(0/1/2/3) ranges in the AXI address space where host memory can be mapped. > > +- resets: Must contain phandles to PCIe-related reset lines exposed by IP block > > +- clocks: from common clock binding: clock specifiers for the PCIe controller > > + clock. > > +- clock-names: from common clock binding: should be "pcie". > > + > > +Optional Property: > > +- max-functions: Maximum number of functions that can be configured (default 1). > > + > > +Example: > > + > > +SoC-specific DT Entry: > > + > > + pcie_ep: pcie_ep@fe000000 { > > + compatible = "renesas,pcie-r8a7791", "renesas,pcie-rcar-gen2"; > > These compatible values do not match with the ones above > (but they match with what I'd like to see ;-) > my bad I'll update them to reflect the above. Cheers, --Prabhakar > > + reg = <0 0xfe000000 0 0x80000>, > > + <0x0 0xfe100000 0 0x100000>, > > + <0x0 0xfe200000 0 0x200000>, > > + <0x0 0x30000000 0 0x8000000>, > > + <0x0 0x38000000 0 0x8000000>; > > + reg-names = "apb-base", "memory0", "memory1", "memory2", "memory3"; > > + clocks = <&cpg CPG_MOD 319>; > > + clock-names = "pcie"; > > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > > + resets = <&cpg 319>; > > + }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAB1C5DF60 for ; Thu, 7 Nov 2019 09:26:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6873218AE for ; Thu, 7 Nov 2019 09:26:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SwqNwEpS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JaRiVyVn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6873218AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/3dpyEdFxBSoh6CO1Q+ZCzljoDmFHIIvLqhvsVQeC/E=; b=SwqNwEpSZmMeFk elh7v11+iBjjjovg8YBB3JlIMMBO9om98Db3y2AqAQKkWz5s9oTsC7P0Irrz3q6cg9Has1mqIRJGp 5pBHb1khNvSs9xyKF4dmhPXPCoChabWpO/py+QW2/72dEHWBD6e3kA5fJt74InuFxi0vQymP9ot2I vR+qoaqj5MeR6Cu0eNftB1aoNanDyU/bkNUMoIYXZQf7M4TdcUDNDhuHjYrXYML7BS/yY0l9nBQbe 6Bl9c0sNFU8GWqwGdM++eobWLR93NheKn1E8+T0MinTpCqUegBCTSRQny4bjK0TV24zPxHfhm7lDy amGu7NF953b5Qul/hCIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSe3a-0006ur-HO; Thu, 07 Nov 2019 09:26:22 +0000 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSe3O-0006ju-EK for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2019 09:26:13 +0000 Received: by mail-oi1-x244.google.com with SMTP id a14so1366123oid.5 for ; Thu, 07 Nov 2019 01:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=svJecAxqhlBawitftrz5LXbFY8d5ATbDsx3obREbmBk=; b=JaRiVyVnWoErWMwSLJsT3edCIFkLrM3bw9K+3t2YOtpGSIe5jPWeSfJJ3zV3UcGXyj wwR2NS63eTI2jFJYHyvrY1LIrbvvYORCOjhiH8sOou1LG6PPH6s0hxYi668s+Ia/fGNp mD+dKjP+i/vpXdma4xZtepheZ7yutdc9rzN+mceieTuhWlkhAMrPEFb/Jt3ett6SzSg9 ELmfrBZVVLKH9oU9mvJlKOogzz4Xf2ygwEAneNX6k9Q9/CL4uLnu6olfZ/Y8MyINIPDf l05fDkGxYqctkz/xtGJFKge5gK+fg8G8ZLe5jNs9w3+fRrpZp6HQVuJW4G6WswW642hk BRQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=svJecAxqhlBawitftrz5LXbFY8d5ATbDsx3obREbmBk=; b=OkIndQl32ADQzrlTc6RQCUyW+9LyMcIxsmXeX1pEueL5OgOH2ilEPxpz8zhDdI5KKc 9BgrgEpnM2JVBhJR3uqLLoO9e/4ZJTmlE1ubJlaoUw6Uh45dRW4vnr+zgMHuycJEzSM9 HtOpJHKWO4Xq2WqfkHyTmsHVD4RWgiles80aGmYeWdD1vANvz0tBSbhD0JDR+l4kNH9F lF6XKV6KcOMmJMb6hsyAbyS69G+XUtoJGGR63C39LPtNLeFSvYFGM1oANR+s/iEens3H ZZbKuiJjP4RKXwhGx6r1KNmHDxel0yZzPGOwcuUr86w9GZrT0I0HetKPc3gcH5Y8ZzPI 33Dw== X-Gm-Message-State: APjAAAWQEyEoCh4BPv0pnKVuGLKYljJ+/WwGk+5rnro7NkfnbHK1tKxb QOBi6j02Nx32YI5PwQKgBsb7o/gkqXzs2mx7r1U= X-Google-Smtp-Source: APXvYqzl/mjJb58YCZv+1rPoz9YmBODStqICfxXp/t7vlm94pbfdzMz/foObeQbkPEnjt5Qa5497EWxx2Gk87u9uMzM= X-Received: by 2002:aca:5cc6:: with SMTP id q189mr2405318oib.101.1573118768684; Thu, 07 Nov 2019 01:26:08 -0800 (PST) MIME-Version: 1.0 References: <20191106193609.19645-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191106193609.19645-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 7 Nov 2019 09:25:42 +0000 Message-ID: Subject: Re: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings To: Geert Uytterhoeven X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191107_012610_496253_C781E7B4 X-CRM114-Status: GOOD ( 27.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Lorenzo Pieralisi , "Lad, Prabhakar" , Arnd Bergmann , Geert Uytterhoeven , Greg Kroah-Hartman , linux-pci , Yoshihiro Shimoda , Magnus Damm , Linux Kernel Mailing List , Kishon Vijay Abraham I , Linux-Renesas , Rob Herring , Catalin Marinas , Bjorn Helgaas , Andrew Murray , Will Deacon , Linux ARM , Marek Vasut Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, Thank you for the review. On Thu, Nov 7, 2019 at 8:44 AM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Wed, Nov 6, 2019 at 8:36 PM Lad Prabhakar wrote: > > From: "Lad, Prabhakar" > > > > This patch adds the bindings for the R-Car PCIe endpoint driver. > > > > Signed-off-by: Lad, Prabhakar > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > @@ -0,0 +1,43 @@ > > +* Renesas R-Car PCIe Endpoint Controller DT description > > + > > +Required properties: > > + "renesas,pcie-ep-r8a774c0" for the R8A774C0 SoC; > > + "renesas,pcie-ep-rcar-gen3" for a generic R-Car Gen3 or > > + RZ/G2 compatible device. > > Unless I'm missing something, this is for the exact same hardware block as > Documentation/devicetree/bindings/pci/rcar-pci.txt? > So shouldn't you amend those bindings, instead of adding new compatible > values? > Please remember that DT describes hardware, not software policy. > So IMHO choosing between host and endpoint is purely a configuration > issue, and could be indicated by the presence or lack of some DT properties. > E.g. host mode requires both "bus-range" and "device_type" properties, > so their absence could indicate endpoint mode. > yes its the same hardware block as described in the rcar-pci.txt, I did think about amending it but it might turn out to be bit messy, required properties host ======required properties Endpoint ====================||================== 1: reg || reg 2:bus-range || reg names 3: device_type || resets 4: ranges || clocks 5: dma-ranges || clock-names 6: interrupts || 7: interrupt-cells || 8: interrupt-map-mask || 9: clocks || 10: clock-names || and if I go ahead with the same compatible string that would mean to add support for endpoint mode in the host driver itself. I did follow the examples of rockchip/cadence/designware where its the same hardware block but has two different binding files one for host mode and other for endpoint mode. > > +- reg: Five register ranges as listed in the reg-names property > > +- reg-names: Must include the following names > > + - "apb-base" > > + - "memory0" > > + - "memory1" > > + - "memory2" > > + - "memory3" > > What is the purpose of the last 4 regions? > Can they be chosen by the driver, at runtime? > no the driver cannot choose them at runtime, as these are the only PCIE memory(0/1/2/3) ranges in the AXI address space where host memory can be mapped. > > +- resets: Must contain phandles to PCIe-related reset lines exposed by IP block > > +- clocks: from common clock binding: clock specifiers for the PCIe controller > > + clock. > > +- clock-names: from common clock binding: should be "pcie". > > + > > +Optional Property: > > +- max-functions: Maximum number of functions that can be configured (default 1). > > + > > +Example: > > + > > +SoC-specific DT Entry: > > + > > + pcie_ep: pcie_ep@fe000000 { > > + compatible = "renesas,pcie-r8a7791", "renesas,pcie-rcar-gen2"; > > These compatible values do not match with the ones above > (but they match with what I'd like to see ;-) > my bad I'll update them to reflect the above. Cheers, --Prabhakar > > + reg = <0 0xfe000000 0 0x80000>, > > + <0x0 0xfe100000 0 0x100000>, > > + <0x0 0xfe200000 0 0x200000>, > > + <0x0 0x30000000 0 0x8000000>, > > + <0x0 0x38000000 0 0x8000000>; > > + reg-names = "apb-base", "memory0", "memory1", "memory2", "memory3"; > > + clocks = <&cpg CPG_MOD 319>; > > + clock-names = "pcie"; > > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > > + resets = <&cpg 319>; > > + }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel