From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752205AbaAWJGc (ORCPT ); Thu, 23 Jan 2014 04:06:32 -0500 Received: from mail-vc0-f176.google.com ([209.85.220.176]:32999 "EHLO mail-vc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbaAWJG0 (ORCPT ); Thu, 23 Jan 2014 04:06:26 -0500 MIME-Version: 1.0 From: Prabhakar Lad Date: Thu, 23 Jan 2014 14:36:05 +0530 Message-ID: Subject: To: Mark Brown , broonie@kernel.org Cc: LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, I see a issue with one of the davinci boards, where regulator_get() fails from this patch "regulator: core: Provide a dummy regulator with full constraints". as I see regulator_get() supports dummy regulators by default. So currently I am booting it traditional way (NON DT way) and regulator_dev_lookup() fails (return NULL) and for this check it fails. + if (ret && ret != -ENODEV) { regulator = ERR_PTR(ret); goto out; } In the NON-DT case the 'ret' is never updated in regulator_dev_lookup(). I tried adding regulator_has_full_constraints(); call in .init_machine but results the same. Any pointer would be helpfull. Thanks, --Prabhakar Lad