From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D9FC43457 for ; Fri, 9 Oct 2020 08:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69DEB2087D for ; Fri, 9 Oct 2020 08:41:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OB3axd98" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732873AbgJIIl5 (ORCPT ); Fri, 9 Oct 2020 04:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729347AbgJIIl4 (ORCPT ); Fri, 9 Oct 2020 04:41:56 -0400 Received: from mail-yb1-xb43.google.com (mail-yb1-xb43.google.com [IPv6:2607:f8b0:4864:20::b43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B332DC0613D2; Fri, 9 Oct 2020 01:41:56 -0700 (PDT) Received: by mail-yb1-xb43.google.com with SMTP id x20so6662635ybs.8; Fri, 09 Oct 2020 01:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pWRP8OPHPDiX0yGCyQ3J0h/q/llirJbt+mqaV/WGwCI=; b=OB3axd98zHIsRnDSu/UtTEPGs47EBcf4Y4koXk28s84hO2oWgDLzMM6W08DQFtFL64 mxjE8A7HDcigDW/izDXy3Eav1yN467U/rqtwMWGTNKAVJGajkM3eN/n4BiJmPgwJWEvQ 3Id3ZueLBSOdl604SVqobVIGmfQKw9fUW6Hd8PjODje6hV6e617VVH3zt3gKewJmd+Nk euLtLARbeV3PLkdEOh4SqWUwkR5XqP4oSxLMrPcW2ZbNV8tA9OGRj4tZfVOhT5Cogyg6 tSNxwNECCGQ/mLpwOzb31hm6BkSeXu6F3DE2pv+r3aEcN6cPPUnqtq6FirEcoVLVjy2U MBAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pWRP8OPHPDiX0yGCyQ3J0h/q/llirJbt+mqaV/WGwCI=; b=S06xQSBkPK5zgioq5x/OzjEMOXdQbV/H5+nmuFtJOEmzl73KPAsmDbYNdhgCwjBA3R k6ddni8AeS8GrShP4ckDfLPmSCk1HnHggJgL5QN1XYp0GI4HPMGrg3P9JMFG3S+X1Fbk f8OYwd23cDPY8mVGeJiCkehgELLrPNzfSiyQRkE/cdnlpJX5ttd8LmUtelQWoFTbrG5I 6t007pkzzE9eBxgDPTmsKVvJUQ+M6FYHFkWKj2ZHTOK8i7agKW7P5Ji/xs0J9voXlLAD q2ivvhpeQLRu+49nD4lSXr7pAb5FNeVodfq9692xF/dGvCx2AnluDfv8FYZGbLBI+5fq 89ig== X-Gm-Message-State: AOAM532fzwZic+DRaxQvNcqbFVQqOfxE5jOHmZoqrOjRcpuvpyNb/sp6 YINRZUahnv5CQ4a7PjGSQeFxb/KtbSfoH3YXBHE= X-Google-Smtp-Source: ABdhPJz0JVUhDD/zJs0nsn0utlR+VgQJg6uPI+zxcTJA1LBqbdXee85q9E4iPysbq7EaWVNJvRMfv+CpCz525f26zMg= X-Received: by 2002:a25:ce81:: with SMTP id x123mr17387616ybe.445.1602232915836; Fri, 09 Oct 2020 01:41:55 -0700 (PDT) MIME-Version: 1.0 References: <20200907155541.2011-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200907155541.2011-4-prabhakar.mahadev-lad.rj@bp.renesas.com> <20201009073349.GD10335@amd> In-Reply-To: <20201009073349.GD10335@amd> From: "Lad, Prabhakar" Date: Fri, 9 Oct 2020 09:41:29 +0100 Message-ID: Subject: Re: [PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication To: Pavel Machek Cc: Lad Prabhakar , Geert Uytterhoeven , Magnus Damm , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, Thank you for the review. On Fri, Oct 9, 2020 at 8:33 AM Pavel Machek wrote: > > Hi! > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > > @@ -63,6 +63,16 @@ > > enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>; > > }; > > > > + leds { > > + compatible = "gpio-leds"; > > + > > + sdhi2_led { > > + label = "sdio-led"; > > This should use appropriate label... probably mmc1:green:activity. > $ grep -nr mmc | grep -i activity $ grep -nr sd | grep -i activity Results in 0 outputs in dts folder. Cheers, Prabhakar