From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762256AbbA2K0o (ORCPT ); Thu, 29 Jan 2015 05:26:44 -0500 Received: from mail-wi0-f178.google.com ([209.85.212.178]:32825 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758055AbbA2K0m (ORCPT ); Thu, 29 Jan 2015 05:26:42 -0500 MIME-Version: 1.0 In-Reply-To: <1422479867-3370921-4-git-send-email-arnd@arndb.de> References: <1422479867-3370921-1-git-send-email-arnd@arndb.de> <1422479867-3370921-4-git-send-email-arnd@arndb.de> From: "Lad, Prabhakar" Date: Thu, 29 Jan 2015 10:26:08 +0000 Message-ID: Subject: Re: [PATCH 3/7] [media] staging/davinci/vpfe/dm365: add missing dependencies To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , LKML , LAK , linux-media Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 28, 2015 at 9:17 PM, Arnd Bergmann wrote: > This driver can only be built when VIDEO_V4L2_SUBDEV_API > and VIDEO_DAVINCI_VPBE_DISPLAY are also provided by the > kernel. > > drivers/staging/media/davinci_vpfe/dm365_isif.c: In function '__isif_get_format': > drivers/staging/media/davinci_vpfe/dm365_isif.c:1410:3: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration] > return v4l2_subdev_get_try_format(fh, pad); > ^ > > Signed-off-by: Arnd Bergmann > Cc: Greg Kroah-Hartman Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- > drivers/staging/media/davinci_vpfe/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/media/davinci_vpfe/Kconfig b/drivers/staging/media/davinci_vpfe/Kconfig > index 4de2f082491d..f40a06954a92 100644 > --- a/drivers/staging/media/davinci_vpfe/Kconfig > +++ b/drivers/staging/media/davinci_vpfe/Kconfig > @@ -2,6 +2,8 @@ config VIDEO_DM365_VPFE > tristate "DM365 VPFE Media Controller Capture Driver" > depends on VIDEO_V4L2 && ARCH_DAVINCI_DM365 && !VIDEO_DM365_ISIF > depends on HAS_DMA > + depends on VIDEO_V4L2_SUBDEV_API > + depends on VIDEO_DAVINCI_VPBE_DISPLAY > select VIDEOBUF2_DMA_CONTIG > help > Support for DM365 VPFE based Media Controller Capture driver. > -- > 2.1.0.rc2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: prabhakar.csengg@gmail.com (Lad, Prabhakar) Date: Thu, 29 Jan 2015 10:26:08 +0000 Subject: [PATCH 3/7] [media] staging/davinci/vpfe/dm365: add missing dependencies In-Reply-To: <1422479867-3370921-4-git-send-email-arnd@arndb.de> References: <1422479867-3370921-1-git-send-email-arnd@arndb.de> <1422479867-3370921-4-git-send-email-arnd@arndb.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 28, 2015 at 9:17 PM, Arnd Bergmann wrote: > This driver can only be built when VIDEO_V4L2_SUBDEV_API > and VIDEO_DAVINCI_VPBE_DISPLAY are also provided by the > kernel. > > drivers/staging/media/davinci_vpfe/dm365_isif.c: In function '__isif_get_format': > drivers/staging/media/davinci_vpfe/dm365_isif.c:1410:3: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration] > return v4l2_subdev_get_try_format(fh, pad); > ^ > > Signed-off-by: Arnd Bergmann > Cc: Greg Kroah-Hartman Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- > drivers/staging/media/davinci_vpfe/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/media/davinci_vpfe/Kconfig b/drivers/staging/media/davinci_vpfe/Kconfig > index 4de2f082491d..f40a06954a92 100644 > --- a/drivers/staging/media/davinci_vpfe/Kconfig > +++ b/drivers/staging/media/davinci_vpfe/Kconfig > @@ -2,6 +2,8 @@ config VIDEO_DM365_VPFE > tristate "DM365 VPFE Media Controller Capture Driver" > depends on VIDEO_V4L2 && ARCH_DAVINCI_DM365 && !VIDEO_DM365_ISIF > depends on HAS_DMA > + depends on VIDEO_V4L2_SUBDEV_API > + depends on VIDEO_DAVINCI_VPBE_DISPLAY > select VIDEOBUF2_DMA_CONTIG > help > Support for DM365 VPFE based Media Controller Capture driver. > -- > 2.1.0.rc2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel